| Message ID | 4d252cf1-e2e6-59cd-5328-f90e28a1a770@redhat.com |
|---|---|
| State | New, archived |
| Headers |
Received: (qmail 55878 invoked by alias); 27 Apr 2018 19:32:24 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 55816 invoked by uid 89); 27 Apr 2018 19:32:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, SPF_HELO_PASS autolearn=unavailable version=3.3.2 spammy= X-HELO: mx1.redhat.com Subject: Re: Remove tilegx port To: Richard Biener <richard.guenther@gmail.com>, gcc-patches@gcc.gnu.org, Joseph Myers <joseph@codesourcery.com> Cc: libc-alpha@sourceware.org References: <alpine.DEB.2.20.1804271534430.17705@digraph.polyomino.org.uk> <4f6f6682-1fd3-18b3-8b8c-bbd0fb38fb17@redhat.com> <2DDA84B0-56C7-4B4B-8C23-DEF2001B6BEB@gmail.com> From: Jeff Law <law@redhat.com> Openpgp: preference=signencrypt Autocrypt: addr=law@redhat.com; prefer-encrypt=mutual; keydata= xsBNBFkbIO8BCACVIqDhDVh9ur8C+zNV1J/cXfwvVDAUcphDEFl4jyHqZORK4Pd3Db8oWqLm Q8lOCr/VOS7lrCtdpVMQkLGOGA16oJ8g7hzhnojpjY09UjsoUiG7oKacuxj8skfp6SIx93Zl +iNYPRa4S+za6nY8qiVjyUuiyX04ZPZMrKp2c2sGi+HnBKUZXGhrz/Jdzdox3tjajWZnObyy nhEN6hn9L3KawTtGPE/R6A/1RhHTD9FQmIWIeucpaY5c6GNKXTFpj2VYx57LY5hve1R5vhrJ IZcgwZAiOtmik5lVi96glY5h6bugRwpexjhwORTLPBCkwiYotSxX99mWd6EHL576i5CNABEB AAHNGUplZmYgTGF3IDxsYXdAcmVkaGF0LmNvbT7CwI4EEwEIADgWIQR+niGjtnP5P/8PpRq8 fP682pgzWwUCWRsg7wIbAwULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRC8fP682pgzW5QG B/9VATJmx5235RB+8jiDYGXQf3vd9gBfPy/l1tsaK400eFAevDzfGvKmeCKe+uGnlrH3vyT8 rg9zqH+s5a1Y+lDXPOpJAFmmzbOLU4FW4ucbawmtYvBL65PqpQneCTYnC802/OAcxjm/Onem HlgeK6WicNsBTPwYN/0araDFUejyYBIFi9CNqqflwk5Z3brKbQ9bAYIkysVLC/c3njKPmM0c WPFHG91ubLbWCHwTIK0+mAL714eTD74dXzOjO2ZDBPLGlFN/kO3+YjaO6UOD2O8acvAMCivT kWLr7JwRgLIQDN2DkhQDd3LTPqQE/yOcMcXBTO+fxm8KG0iKQBqWMyGJzsBNBFkbIO8BCACy qbOsv7XegSeea8XORt5zMaBVWKoSyhmmcCmlxZFS2cuYOBt79MO13lZE2DlO3Lv5IKikj/D4 ketGVO4+h5psEMH5Yz5P8bx0TmgwbK1GxPZrzeXozUFJDvvCDbIlT0v0pwUXuK3hg8Ieo2h5 uTed/cn1OjySXW5BqLxN0cyr5hL+J6dcsHvKLT/N3nTgCQhoJXK2MrEMhAGgF3jKpMn3CoS4 i/ZbNI2MQR6LWHwdZ95f0fI8NzHSfVzeLtzCKQec7nr9fgd6Ylk1ZpGWQUPlQmKjzYgeCeTK NO04cwt20WIrQWeWiZFPA0U86NDBdSBrYp4kG3dfIXE+wSSvE7qPABEBAAHCwHYEGAEIACAW IQR+niGjtnP5P/8PpRq8fP682pgzWwUCWRsg7wIbDAAKCRC8fP682pgzW3REB/9cT7iKRPg/ OK9bpLlllIEDM90IaKC79DQrv+fRudOR78cdV4XUwPSFnyHUsP3VJ4lDy5FhiKCwGie0BK53 EsxgMrLy1L8hboFdTE4Vi0xzCheMaMVp4hATDU29k1cuxu1VPpCa8E3mYeHjNV7ip0HN5L4D rfs8lRPJE/oM1vGs9DgQFZrCPPNRNGKC97BH+DHccesEJr7tSsQrkPkt0z/FTKr5wIM02vSx OJjgmcVbGB7dc2j/Sx8loXmuKnuKtM35668kUG8jeJvSQk3o/VHpD27bhl0rR68R2jN6G6kQ egMVb6dPu1Ius8rBE5rFw88J4JEb5q4hMNClWWUFHIdP Message-ID: <4d252cf1-e2e6-59cd-5328-f90e28a1a770@redhat.com> Date: Fri, 27 Apr 2018 13:32:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <2DDA84B0-56C7-4B4B-8C23-DEF2001B6BEB@gmail.com> Content-Type: multipart/mixed; boundary="------------9BF012828BB2121418EDCAE4" |
Commit Message
Jeff Law
April 27, 2018, 7:32 p.m. UTC
On 04/27/2018 11:42 AM, Richard Biener wrote: > On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law <law@redhat.com> wrote: >> On 04/27/2018 09:36 AM, Joseph Myers wrote: >>> Since tile support has been removed from the Linux kernel for 4.17, >>> this patch removes the (unmaintained) port to tilegx from glibc (the >>> tilepro support having been previously removed). This reflects the >>> general principle that a glibc port needs upstream support for the >>> architecture in all the components it build-depends on (so binutils, >>> GCC and the Linux kernel, for the normal case of a port supporting >> the >>> Linux kernel but no other OS), in order to be maintainable. >>> >>> Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile >>> (omitted from the diffs below), there are updates to various comments >>> referencing tile for which removal of those references seemed >>> appropriate. The configuration is removed from README and from >>> build-many-glibcs.py. contrib.texi keeps mention of removed >>> contributions, but I updated Chris Metcalf's entry to reflect that he >>> also contributed the non-removed support for the generic Linux kernel >>> syscall interface. __ASSUME_FADVISE64_64_NO_ALIGN support is >> removed, >>> as it was only used by tile. >> Given tilegx/tilepro removal from the kernel and glibc, should we go >> ahead and deprecate them in GCC? The only tilegx/tilepro >> configurations >> are -linux. > > Makes sense to me. Let's deprecate it for GCC 8 and remove from trunk. > > Richard. > >> Jeff > Here's what I committed to the trunk and the release branch. I'll find/update the appropriate web page momentarily. jeff
Comments
On Fri, Apr 27, 2018 at 9:32 PM Jeff Law <law@redhat.com> wrote: > > On 04/27/2018 11:42 AM, Richard Biener wrote: > > On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law <law@redhat.com> wrote: > >> On 04/27/2018 09:36 AM, Joseph Myers wrote: > >>> Since tile support has been removed from the Linux kernel for 4.17, > >>> this patch removes the (unmaintained) port to tilegx from glibc (the > >>> tilepro support having been previously removed). This reflects the > >>> general principle that a glibc port needs upstream support for the > >>> architecture in all the components it build-depends on (so binutils, > >>> GCC and the Linux kernel, for the normal case of a port supporting > >> the > >>> Linux kernel but no other OS), in order to be maintainable. > >>> > >>> Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile > >>> (omitted from the diffs below), there are updates to various comments > >>> referencing tile for which removal of those references seemed > >>> appropriate. The configuration is removed from README and from > >>> build-many-glibcs.py. contrib.texi keeps mention of removed > >>> contributions, but I updated Chris Metcalf's entry to reflect that he > >>> also contributed the non-removed support for the generic Linux kernel > >>> syscall interface. __ASSUME_FADVISE64_64_NO_ALIGN support is > >> removed, > >>> as it was only used by tile. > >> Given tilegx/tilepro removal from the kernel and glibc, should we go > >> ahead and deprecate them in GCC? The only tilegx/tilepro > >> configurations > >> are -linux. > > > > Makes sense to me. Let's deprecate it for GCC 8 and remove from trunk. > > > > Richard. > > > >> Jeff > > > > Here's what I committed to the trunk and the release branch. I'll > find/update the appropriate web page momentarily. It's been deprecated since GCC 8 now but the port is still on trunk, guarded by --enable-obsolete - is it time to remove it? Richard. > jeff
On 9/10/2021 5:50 AM, Richard Biener via Libc-alpha wrote: > On Fri, Apr 27, 2018 at 9:32 PM Jeff Law <law@redhat.com> wrote: >> On 04/27/2018 11:42 AM, Richard Biener wrote: >>> On April 27, 2018 7:26:19 PM GMT+02:00, Jeff Law <law@redhat.com> wrote: >>>> On 04/27/2018 09:36 AM, Joseph Myers wrote: >>>>> Since tile support has been removed from the Linux kernel for 4.17, >>>>> this patch removes the (unmaintained) port to tilegx from glibc (the >>>>> tilepro support having been previously removed). This reflects the >>>>> general principle that a glibc port needs upstream support for the >>>>> architecture in all the components it build-depends on (so binutils, >>>>> GCC and the Linux kernel, for the normal case of a port supporting >>>> the >>>>> Linux kernel but no other OS), in order to be maintainable. >>>>> >>>>> Apart from removal of sysdeps/tile and sysdeps/unix/sysv/linux/tile >>>>> (omitted from the diffs below), there are updates to various comments >>>>> referencing tile for which removal of those references seemed >>>>> appropriate. The configuration is removed from README and from >>>>> build-many-glibcs.py. contrib.texi keeps mention of removed >>>>> contributions, but I updated Chris Metcalf's entry to reflect that he >>>>> also contributed the non-removed support for the generic Linux kernel >>>>> syscall interface. __ASSUME_FADVISE64_64_NO_ALIGN support is >>>> removed, >>>>> as it was only used by tile. >>>> Given tilegx/tilepro removal from the kernel and glibc, should we go >>>> ahead and deprecate them in GCC? The only tilegx/tilepro >>>> configurations >>>> are -linux. >>> Makes sense to me. Let's deprecate it for GCC 8 and remove from trunk. >>> >>> Richard. >>> >>>> Jeff >> Here's what I committed to the trunk and the release branch. I'll >> find/update the appropriate web page momentarily. > It's been deprecated since GCC 8 now but the port is still on trunk, > guarded by --enable-obsolete - is it time to remove it? Definitely. Folks have had years to complain. If you wanted to add cr16 to the deprecated ports list, I'd fully support that as well. It hasn't built since dropping cc0 and there doesn't appear to be anyone interested in making it work. jeff
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 4db67b8d069..f81b09f8739 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,7 @@ +2018-04-27 Jeff Law <law@redhat.com> + + * config.gcc: Mark tile* targets as deprecated/obsolete. + 2018-04-27 Richard Biener <rguenther@suse.de> * config/aarch64/aarch64.c: Simplify ap.__stack advance and diff --git a/gcc/config.gcc b/gcc/config.gcc index e58494c1c17..a5defb0f005 100644 --- a/gcc/config.gcc +++ b/gcc/config.gcc @@ -237,6 +237,7 @@ md_file= # Obsolete configurations. case ${target} in powerpc*-*-*spe* \ + | tile*-*-* \ ) if test "x$enable_obsolete" != xyes; then echo "*** Configuration ${target} is obsolete." >&2