From patchwork Fri Sep 11 13:03:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 40395 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 937D73987479; Fri, 11 Sep 2020 13:04:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 937D73987479 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1599829449; bh=oN2GBAl+kmxsEbMenIaqhLEfRaEraYWz42vM3w1hcjQ=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=b0uMWJukmltdeDftABNyupiropbnDCnKdcbZLx7lgnofYymDdtyIBBVhrmpXjoq41 ynMiwmw2gYWxeazszCCLzUmOsziQIPH7Y38v1jKYCFFTYXyP4Yl+7I9tPMrnkm/v88 D22uDETXpRImw0yTIsB6ZJdV2JPBIp2+sUzU2CAg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 17B553987474 for ; Fri, 11 Sep 2020 13:04:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 17B553987474 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-197-T2Ijvm5RMZmNujj3-a4jMg-1; Fri, 11 Sep 2020 09:04:02 -0400 X-MC-Unique: T2Ijvm5RMZmNujj3-a4jMg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6F3F564096 for ; Fri, 11 Sep 2020 13:04:01 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-113-142.rdu2.redhat.com [10.10.113.142]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B083A81C48 for ; Fri, 11 Sep 2020 13:04:00 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH 2/3] support: Provide a way to clear the RA bit in DNS server responses In-Reply-To: <55f9a2d387df8fae7d44275e2cf7dce8eccd120e.1599829382.git.fweimer@redhat.com> References: <55f9a2d387df8fae7d44275e2cf7dce8eccd120e.1599829382.git.fweimer@redhat.com> X-From-Line: 4d0f3a89d11cfdf2aa406019180b8a18c3b7fd7e Mon Sep 17 00:00:00 2001 Message-Id: <4d0f3a89d11cfdf2aa406019180b8a18c3b7fd7e.1599829382.git.fweimer@redhat.com> Date: Fri, 11 Sep 2020 15:03:58 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0.002 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" --- support/resolv_test.c | 4 +++- support/resolv_test.h | 4 ++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/support/resolv_test.c b/support/resolv_test.c index e343c4b516..9878a040a3 100644 --- a/support/resolv_test.c +++ b/support/resolv_test.c @@ -181,7 +181,9 @@ resolv_response_init (struct resolv_response_builder *b, b->buffer[2] |= b->query_buffer[2] & 0x01; /* Copy the RD bit. */ if (flags.tc) b->buffer[2] |= 0x02; - b->buffer[3] = 0x80 | flags.rcode; /* Always set RA. */ + b->buffer[3] = flags.rcode; + if (!flags.clear_ra) + b->buffer[3] |= 0x80; if (flags.ad) b->buffer[3] |= 0x20; diff --git a/support/resolv_test.h b/support/resolv_test.h index c46de32ff4..31a5c1c3e7 100644 --- a/support/resolv_test.h +++ b/support/resolv_test.h @@ -148,6 +148,10 @@ struct resolv_response_flags /* If true, the AD (authenticated data) flag will be set. */ bool ad; + /* If true, do not set the RA (recursion available) flag in the + response. */ + bool clear_ra; + /* Initial section count values. Can be used to artificially increase the counts, for malformed packet testing.*/ unsigned short qdcount;