From patchwork Fri Dec 9 10:36:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Vogt X-Patchwork-Id: 61726 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DF2B13871D11 for ; Fri, 9 Dec 2022 10:36:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF2B13871D11 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1670582196; bh=6jpFYq8uBkKWc9PCKYweDfgRr5W2fDjPW9xZ/zkirrY=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=ZD/3kvtHyhGV2cwgHovjzPgYzEIGDPl6NkYlNfXyj5sC/zJnk0+VHuU9MolJhAZWL YdYQfic2KDHgqAdfDRNYw5OR3LqrIzkmlCFHv3meAC5kTVaXMkfXtUNAZR4mv5AmX2 fp+HMtTModQP733xW2ehVPbOpsMCevmX6e5IiDys= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 2B3BF384D6E9 for ; Fri, 9 Dec 2022 10:36:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2B3BF384D6E9 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5B5F321D09; Fri, 9 Dec 2022 10:36:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4EA48138E0; Fri, 9 Dec 2022 10:36:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dTXIEpwPk2N+DgAAMHmgww (envelope-from ); Fri, 09 Dec 2022 10:36:12 +0000 To: libc-alpha@sourceware.org Cc: hjl.tools@gmail.com, aurelien@aurel32.net Subject: [PATCH] x86: include OSXSAVE in x86-64-v3 level Date: Fri, 09 Dec 2022 11:36:11 +0100 Message-ID: <4789070.31r3eYUQgx@linux-e202.suse.de> MIME-Version: 1.0 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Fabian Vogt via Libc-alpha From: Fabian Vogt Reply-To: Fabian Vogt Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" For some reason the initial x86-64-v3 detection code was missing checks for BMI, BMI2 and OSXSAVE, which are all required for that level to be met. BMI and BMI2 got added recently, but OSXSAVE was still missing. Add it. Signed-off-by: Fabian Vogt --- sysdeps/x86/get-isa-level.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sysdeps/x86/get-isa-level.h b/sysdeps/x86/get-isa-level.h index 5b4dd5f062..d62bf92cde 100644 --- a/sysdeps/x86/get-isa-level.h +++ b/sysdeps/x86/get-isa-level.h @@ -52,7 +52,8 @@ get_isa_level (const struct cpu_features *cpu_features) && CPU_FEATURE_USABLE_P (cpu_features, F16C) && CPU_FEATURE_USABLE_P (cpu_features, FMA) && CPU_FEATURE_USABLE_P (cpu_features, LZCNT) - && CPU_FEATURE_USABLE_P (cpu_features, MOVBE)) + && CPU_FEATURE_USABLE_P (cpu_features, MOVBE) + && CPU_FEATURE_USABLE_P (cpu_features, OSXSAVE)) { isa_level |= GNU_PROPERTY_X86_ISA_1_V3; if (CPU_FEATURE_USABLE_P (cpu_features, AVX512F)