diff mbox

[PATCHv2,10/14] Add note about nexttoward test cases in libm-test.inc

Message ID 439d259329baf002fe902500c3cf80aa67f5512e.1463779745.git.murphyp@linux.vnet.ibm.com
State Superseded
Headers

Commit Message

Paul E. Murphy May 20, 2016, 9:37 p.m. UTC 
  The second argument always takes a long double.  Leave
a note here in case someone attempts a global update
similar to the previous commit.

	* math/libm-test.inc (nexttoward_test_data):
	Add comment about long double second argument.
---
 math/libm-test.inc | 2 ++
 1 file changed, 2 insertions(+)

Comments

Joseph Myers May 23, 2016, 4:58 p.m. UTC | #1 
On Fri, 20 May 2016, Paul E. Murphy wrote:

> +    /* Note, FUNC(nexttoward) always takes a long double as a second argument.  It is also not included as part of
> +       of TS 18661-3.  */

Lines in comments should not exceed 79 columns.  (This is a general rule 
for all lines in source files unless there is some clear reason not to 
wrap things - as is the case for the actual *tests* in libm-test.inc, 
where gen-libm-test.pl relies on each test being on a single line.)
Zack Weinberg May 23, 2016, 5:16 p.m. UTC | #2 
On Mon, May 23, 2016 at 5:58 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Fri, 20 May 2016, Paul E. Murphy wrote:
>
>> +    /* Note, FUNC(nexttoward) always takes a long double as a second argument.  It is also not included as part of
>> +       of TS 18661-3.  */
>
> Lines in comments should not exceed 79 columns.

Also, as will be more obvious once the comment is rewrapped, you've
got an "of of" in there.
diff mbox

Patch

diff --git a/math/libm-test.inc b/math/libm-test.inc
index 6c85b40..3ba0b2d 100644
--- a/math/libm-test.inc
+++ b/math/libm-test.inc
@@ -9995,6 +9995,8 @@  static const struct test_ff_f_data_nexttoward nexttoward_test_data[] =
     TEST_ff_f (nexttoward, -min_subnorm_value, 0, minus_zero, INEXACT_EXCEPTION|UNDERFLOW_EXCEPTION|ERRNO_ERANGE),
     TEST_ff_f (nexttoward, -min_subnorm_value, minus_zero, minus_zero, INEXACT_EXCEPTION|UNDERFLOW_EXCEPTION|ERRNO_ERANGE),
 
+    /* Note, FUNC(nexttoward) always takes a long double as a second argument.  It is also not included as part of
+       of TS 18661-3.  */
 #if TEST_COND_binary32
     TEST_ff_f (nexttoward, 1.0, 1.1L, 0x1.000002p0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),
     TEST_ff_f (nexttoward, 1.0, LDBL_MAX, 0x1.000002p0, NO_INEXACT_EXCEPTION|ERRNO_UNCHANGED),