[1/4] nptl_db: Install libthread_db under a regular implementation name

Message ID 33e06caaa6f9da0321f68d47090164b804429f2a.1623312996.git.fweimer@redhat.com
State Committed
Commit 86f0179bc003ffc34ffaa8d528a7a90153ac06c6
Headers
Series Do not install shared objects under versioned names |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Florian Weimer June 10, 2021, 8:23 a.m. UTC
  Currently, the name is always libthread_db-1.0.so.  It does not change
with the glibc version, like the other libraries.

GDB hard-codes libthread_db.so.1 (the soname), so this change does not
affect loading libthread_db.

Tested on x86_64-linux-gnu, in an environment where the nptl GDB tests
actually run.
---
 nptl_db/Makefile | 2 --
 1 file changed, 2 deletions(-)
  

Comments

Carlos O'Donell June 27, 2021, 9:32 p.m. UTC | #1
On 6/10/21 4:23 AM, Florian Weimer via Libc-alpha wrote:
> Currently, the name is always libthread_db-1.0.so.  It does not change
> with the glibc version, like the other libraries.

Correct.
 
> GDB hard-codes libthread_db.so.1 (the soname), so this change does not
> affect loading libthread_db.

Right.

No regressions on x86_64 or i686. Installed files look good.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>

> Tested on x86_64-linux-gnu, in an environment where the nptl GDB tests
> actually run.
> ---
>  nptl_db/Makefile | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/nptl_db/Makefile b/nptl_db/Makefile
> index ea721c1dcf..1f79c018a1 100644
> --- a/nptl_db/Makefile
> +++ b/nptl_db/Makefile
> @@ -21,8 +21,6 @@ subdir          := nptl_db
>  
>  include ../Makeconfig
>  
> -nptl_db-version = 1.0
> -
>  extra-libs = libthread_db
>  extra-libs-others := $(extra-libs)
>  
>
  

Patch

diff --git a/nptl_db/Makefile b/nptl_db/Makefile
index ea721c1dcf..1f79c018a1 100644
--- a/nptl_db/Makefile
+++ b/nptl_db/Makefile
@@ -21,8 +21,6 @@  subdir          := nptl_db
 
 include ../Makeconfig
 
-nptl_db-version = 1.0
-
 extra-libs = libthread_db
 extra-libs-others := $(extra-libs)