From patchwork Mon Aug 1 10:45:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Weimer X-Patchwork-Id: 56466 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6E2C43857B8B for ; Mon, 1 Aug 2022 10:46:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6E2C43857B8B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659350771; bh=k2uS8Mz+qrofMkQNKV0LF3NlWPqREMaVt2JaQxqKvSI=; h=To:Subject:In-Reply-To:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=mLXCv2HRuA3WeBoOa1EdysxQj4G7qUT+d48XriFX8ntGyH9nvzpihwDnD+GPqLU5L WmHgxuYOwacztlbcTkEwkdGvYk5d/YXApYt8sBl32RV5ofc3S1Pqtj4ZE5edNgZKO/ OXgiKIa+ksJ06Dk7CULx+4ZCDE4dkS1xiT5sEFO0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E07F63858018 for ; Mon, 1 Aug 2022 10:45:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E07F63858018 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-595-cWwJTx82P4WSnYRVrFhbwA-1; Mon, 01 Aug 2022 06:45:48 -0400 X-MC-Unique: cWwJTx82P4WSnYRVrFhbwA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 457E03C0E20E for ; Mon, 1 Aug 2022 10:45:48 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AECDF906B9 for ; Mon, 1 Aug 2022 10:45:47 +0000 (UTC) To: libc-alpha@sourceware.org Subject: [PATCH 2/3] nptl: Remove uses of assert_perror In-Reply-To: References: X-From-Line: 2d9e7fb75a80c85c50d6cbc227af2bde281c4fc6 Mon Sep 17 00:00:00 2001 Message-Id: <2d9e7fb75a80c85c50d6cbc227af2bde281c4fc6.1659350650.git.fweimer@redhat.com> Date: Mon, 01 Aug 2022 12:45:46 +0200 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Florian Weimer via Libc-alpha From: Florian Weimer Reply-To: Florian Weimer Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" __pthread_sigmask cannot actually fail with valid pointer arguments (it would need a really broken seccomp filter), and we do not check for errors elsewhere. Reviewed-by: Adhemerval Zanella --- sysdeps/nptl/gai_misc.h | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/sysdeps/nptl/gai_misc.h b/sysdeps/nptl/gai_misc.h index c09350c2ed..4196eac6e6 100644 --- a/sysdeps/nptl/gai_misc.h +++ b/sysdeps/nptl/gai_misc.h @@ -81,9 +81,7 @@ __gai_start_notify_thread (void) { sigset_t ss; sigemptyset (&ss); - int sigerr __attribute__ ((unused)); - sigerr = __pthread_sigmask (SIG_SETMASK, &ss, NULL); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &ss, NULL); } extern inline int @@ -106,15 +104,12 @@ __gai_create_helper_thread (pthread_t *threadp, void *(*tf) (void *), sigset_t ss; sigset_t oss; sigfillset (&ss); - int sigerr __attribute__ ((unused)); - sigerr = __pthread_sigmask (SIG_SETMASK, &ss, &oss); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &ss, &oss); int ret = __pthread_create (threadp, &attr, tf, arg); /* Restore the signal mask. */ - sigerr = __pthread_sigmask (SIG_SETMASK, &oss, NULL); - assert_perror (sigerr); + (void) __pthread_sigmask (SIG_SETMASK, &oss, NULL); (void) __pthread_attr_destroy (&attr); return ret;