From patchwork Tue Apr 23 20:59:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 88936 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69767384AB6D for ; Tue, 23 Apr 2024 21:00:17 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x42a.google.com (mail-pf1-x42a.google.com [IPv6:2607:f8b0:4864:20::42a]) by sourceware.org (Postfix) with ESMTPS id 3F6403858C62 for ; Tue, 23 Apr 2024 20:59:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3F6403858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3F6403858C62 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713905995; cv=none; b=gBTILdmXPa99Muw/lr2dbjRukI6UcdDLxoQNvFAnKfckt5ukERVAE3jV7ZDWNOp+AZ6zdbEjJJL7yaMhStXWF3eCPDuscBco+zOPT3bT1VhvlN5g16sD8Q/qUav1xtvKbqthZRsOjIG0odTjfnNYhiQQ4k2RdxrMvOrdebYAp00= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713905995; c=relaxed/simple; bh=7uP7vp/ayVvR/QWdf2fqnE/Y21wujO1CXAyWzuNHZRA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=s6irC+Duk6NNzExBYsUNHKvLXcAX3SxelmqHgvlI/NBfC7RuJyumPNtgVsc1/qEpl/1FRKjpwxIXnBkPLHzSGIdH64u1DagBizmiSVH1cJE2ZaRHz+mYo77UaSPeoe1U4n22cuwW86Z5EE78a50WTvDQkymXYHVGMLYy6Qv1+w0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-6eff2be3b33so5828311b3a.2 for ; Tue, 23 Apr 2024 13:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1713905992; x=1714510792; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XGJpuo86Jrv/GitUBT+uMk2wMR/OM4zbTBh+sSGDfyc=; b=Qy3jpkhyJ+fsTxSR9ph01e99KVvyaqKm+/K/1pmAmL3cMYizScJ813KUsIzzB1H6qa JVOx2Tz0ev+U3FkzaMnhNHfTaR4h6/gKVfyOYyoPMX/1boeSxy67MK/Mc0cqKPM4gVKh tJQD8N3ivV36pir/h6VHgvqHwTH5GuzVKscKkTqBxjJAh9yAS5598vZ5I1cMXaqj7t+V cUpQ1+eO59sjUyQWppWDgWuC+29uhg6kxGo0ilyzx0L6WsWkxK/tOeSrbddyMWCR5zht Vhj1nzGTnlUBdMv09uT4w1EK24QrjovNoUUwa30BQHclhFb3D+DZA/jRNs0CUHJCsnxx grUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713905992; x=1714510792; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XGJpuo86Jrv/GitUBT+uMk2wMR/OM4zbTBh+sSGDfyc=; b=rGlS2rqyTtXGacz6yVfmXihjmEgz43IWW1oJlO559XqSev/CVuYPyJw9rQq21Tqkdp 8Cq+ZM34Xi6dHHGkdePvJeR7S3jnB2SvdPuG9htFYIOx39poLIhIMSj9dvNRYcbvUs1V NpZWsxkkJPDiwuCYhzMzeVAHFY880lPcRaM/R70q9edesVSUXNly7RZ5IcrH7XvnPJfj xkDPMazh0IBqxCm034KgoALK3F0/VRc0OPbQnzOdpaQ4viqfbm7S6hLkA1rv4dBXeodT bRc2YRNfYb3aAu/LwP9Otn17wh/uk6+G7OXhjlz2XIOvFOOQ8EYtwlijL8gnPBp/VOXC kh9g== X-Gm-Message-State: AOJu0YwwnH3QIvc8G+B5Ya1bvE0Q3rN04uEe02oGS650qIt2RFy1o/hb bB+wshBMsa5oBWRoU/fglMfMeV8ANXI+Na2y9q4ohF7CoQ4gQO4i X-Google-Smtp-Source: AGHT+IGlUHeXUchy7VcPDZUR1I2nKyjZl+n+ZL+BM3bgDSsl8y7xF/fBGVCS9vETQ1Fg4Zve333eZQ== X-Received: by 2002:a05:6a20:12cc:b0:1a3:c3a9:53b7 with SMTP id v12-20020a056a2012cc00b001a3c3a953b7mr685435pzg.55.1713905992083; Tue, 23 Apr 2024 13:59:52 -0700 (PDT) Received: from gnu-cfl-3.localdomain ([172.56.168.158]) by smtp.gmail.com with ESMTPSA id p8-20020a17090a930800b002a513cc466esm11633243pjo.45.2024.04.23.13.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Apr 2024 13:59:51 -0700 (PDT) Received: from gnu-cfl-3.. (localhost [IPv6:::1]) by gnu-cfl-3.localdomain (Postfix) with ESMTP id AAE3D7402B9; Tue, 23 Apr 2024 13:59:50 -0700 (PDT) From: "H.J. Lu" To: libc-alpha@sourceware.org Cc: fweimer@redhat.com, skpgkp2@gmail.com Subject: [PATCH v2] x86: Define MINIMUM_X86_ISA_LEVEL in config.h [BZ #31676] Date: Tue, 23 Apr 2024 13:59:50 -0700 Message-ID: <20240423205950.52500-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.44.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3022.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Define MINIMUM_X86_ISA_LEVEL at configure time to avoid /usr/bin/ld: …/build/elf/librtld.os: in function `init_cpu_features': …/git/elf/../sysdeps/x86/cpu-features.c:1202: undefined reference to `_dl_runtime_resolve_fxsave' /usr/bin/ld: …/build/elf/librtld.os: relocation R_X86_64_PC32 against undefined hidden symbol `_dl_runtime_resolve_fxsave' can not be used when making a shared object /usr/bin/ld: final link failed: bad value collect2: error: ld returned 1 exit status when glibc is built with -march=x86-64-v3 and configured with --with-rtld-early-cflags=-march=x86-64, which is used to allow ld.so to print an error message on unsupported CPUs: Fatal glibc error: CPU does not support x86-64-v3 This fixes BZ #31676. Reviewed-by: Sunil K Pandey --- config.h.in | 3 +++ sysdeps/x86/configure | 7 +++++++ sysdeps/x86/configure.ac | 5 +++++ sysdeps/x86/isa-level.h | 4 +++- 4 files changed, 18 insertions(+), 1 deletion(-) diff --git a/config.h.in b/config.h.in index 69ac450356..c4cc7d3b9a 100644 --- a/config.h.in +++ b/config.h.in @@ -285,6 +285,9 @@ /* Define if x86 ISA level should be included in shared libraries. */ #undef INCLUDE_X86_ISA_LEVEL +/* The x86 ISA level. 1 for baseline. Undefined on non-x86. */ +#undef MINIMUM_X86_ISA_LEVEL + /* Define if -msahf is enabled by default on x86. */ #undef HAVE_X86_LAHF_SAHF diff --git a/sysdeps/x86/configure b/sysdeps/x86/configure index 2a5421bb31..d28d9bcb29 100644 --- a/sysdeps/x86/configure +++ b/sysdeps/x86/configure @@ -151,6 +151,13 @@ printf "%s\n" "$libc_cv_have_x86_isa_level" >&6; } else libc_cv_have_x86_isa_level=baseline fi +if test $libc_cv_have_x86_isa_level = baseline; then + printf "%s\n" "#define MINIMUM_X86_ISA_LEVEL 1" >>confdefs.h + +else + printf "%s\n" "#define MINIMUM_X86_ISA_LEVEL $libc_cv_have_x86_isa_level" >>confdefs.h + +fi config_vars="$config_vars have-x86-isa-level = $libc_cv_have_x86_isa_level" config_vars="$config_vars diff --git a/sysdeps/x86/configure.ac b/sysdeps/x86/configure.ac index 78ff7c8f41..5b0acd03d2 100644 --- a/sysdeps/x86/configure.ac +++ b/sysdeps/x86/configure.ac @@ -105,6 +105,11 @@ EOF else libc_cv_have_x86_isa_level=baseline fi +if test $libc_cv_have_x86_isa_level = baseline; then + AC_DEFINE_UNQUOTED(MINIMUM_X86_ISA_LEVEL, 1) +else + AC_DEFINE_UNQUOTED(MINIMUM_X86_ISA_LEVEL, $libc_cv_have_x86_isa_level) +fi LIBC_CONFIG_VAR([have-x86-isa-level], [$libc_cv_have_x86_isa_level]) LIBC_CONFIG_VAR([x86-isa-level-3-or-above], [3 4]) LIBC_CONFIG_VAR([enable-x86-isa-level], [$libc_cv_include_x86_isa_level]) diff --git a/sysdeps/x86/isa-level.h b/sysdeps/x86/isa-level.h index 11fe1ca90c..2c7f74212b 100644 --- a/sysdeps/x86/isa-level.h +++ b/sysdeps/x86/isa-level.h @@ -61,8 +61,10 @@ # define __X86_ISA_V4 0 #endif -#define MINIMUM_X86_ISA_LEVEL \ +#ifndef MINIMUM_X86_ISA_LEVEL +# define MINIMUM_X86_ISA_LEVEL \ (__X86_ISA_V1 + __X86_ISA_V2 + __X86_ISA_V3 + __X86_ISA_V4) +#endif /* Depending on the minimum ISA level, a feature check result can be a compile-time constant.. */