From patchwork Thu Mar 14 18:18:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 87212 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 400363857738 for ; Thu, 14 Mar 2024 18:18:56 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-ot1-x335.google.com (mail-ot1-x335.google.com [IPv6:2607:f8b0:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 247B23857BAF for ; Thu, 14 Mar 2024 18:18:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 247B23857BAF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 247B23857BAF Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::335 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710440303; cv=none; b=dlxlMf2Se4lPaSNSgvJhGJUo4UrHM663HDRqR/ZtaVE93WzOVznzhuQJYrVQiCYqbrYT3EsbRyld28vDqBDkTXZbj+M6jpvL895fU6ZpOJLbpcpWo4kZ4dT5xXyQUoE5+rL45SEP7mf00GWZrzaGC1+/qkvwlDzM/h1SRxPYq8A= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710440303; c=relaxed/simple; bh=nJzWTB8epvhuZbidDHEBfu96p85fifF7yXYsdbyVL+4=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=RKfWBF6lhB9xFn5h6yfeLw+aLNSaT2QVoRI7f6aMPBX13F+uCapdsH10fVPXFbSJOPdX3C6F0YtGx9qr61oz3UOEP0bdy/x1CWcTSugGFHZrggb63L24266cR4SIuZBQ5N0CVAwzetlgbqslm+BD8I+Rv5TyI7wixbIBsmeG+Bg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x335.google.com with SMTP id 46e09a7af769-6e677008501so150895a34.1 for ; Thu, 14 Mar 2024 11:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710440300; x=1711045100; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=O+69J1nBrkmIqPnAVQISOg5Bruj1PyCsHc7Ssoxhn6Y=; b=eYVc3A8cY3y1LaOjf5UQ5CjlSLt32y95TyAve96ciHw9k5hz3Xn5arubk5xAtaVW+V DnhiRikh9BbK4A9mwJoHdBnqglb9L8NMAQHDQtUAV1lVubpEXRnBFi6qP7EYWbKaFRlP ekBW7z1mPDeNl8CtfKkKVCxj05GKe8J4LGUj027zRRHeKebxrAcmNSmwC6Uc0r6Wiiim X+uYMRetrTF3bJY0zh7QU3TAzUut8SFZdSpk90YcmmlG8YE7/hKHiRvMJrIFloSXZL5k 3ajb7yoyic3awoNO/OpmfrcgdL1hlnBbxoMi2cDlcZjuEd+kJRnPK8hYWxN6UvCnKSrl x4lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710440300; x=1711045100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O+69J1nBrkmIqPnAVQISOg5Bruj1PyCsHc7Ssoxhn6Y=; b=K1YNbPFcBGz8mujjBEJL5guta5RE9kFb06v0fQ33Fnhu87rHGZVx2ty6VBWP2wx8go l0FPPA47X1f+4L919DxzkgLYoVA+cE8HLrkjLyBqbIRsDSrUo9rdmzCZh8yqviz9egMU JGpU+TyfiLkSZBS4of4qkz4hfrCXZq1gpIhsF+m2Np4dWjDokSqUMhj7GfH0MOeVKbb1 g55P/gCaBSKgVmCvqNqT5fibiiUt2XjqAvQtbgZcPPEwXnnLuOdIiE1nGHd9LJl3YWru poZeyfLpvKyWWVnzs/0Q9bKxI9Geru2XEnaWo51ouIcCUeKy5SrVbp1if6JzwvPY2bTT cDyQ== X-Gm-Message-State: AOJu0YxH419bfyLdghSw4jpcgsMoGcPqH+iHDqz5RRCsV9A3V2LgIX9+ qrDxvlp7hAER+CDgCkH1SXydgj+P+LH47waAw5NlMcAafeYmTNEIjlAEUPD/imoa46DKsUB1L1V y X-Google-Smtp-Source: AGHT+IFXUDAToOiYA9igMvlbKFbb6Hz6I/QSSwdnEasRR26D79XQHfjqTLg691Ij/NICtS++NRXNIQ== X-Received: by 2002:a05:6358:59a2:b0:17e:b568:2af5 with SMTP id c34-20020a05635859a200b0017eb5682af5mr1609607rwf.7.1710440299691; Thu, 14 Mar 2024 11:18:19 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c2:8dfd:b85a:7d6:59ce:add5]) by smtp.gmail.com with ESMTPSA id n188-20020a6327c5000000b005dc491ccdcesm1013469pgn.14.2024.03.14.11.18.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Mar 2024 11:18:19 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 3/3] i386: Use generic fmodf Date: Thu, 14 Mar 2024 15:18:10 -0300 Message-Id: <20240314181810.1330836-4-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240314181810.1330836-1-adhemerval.zanella@linaro.org> References: <20240314181810.1330836-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org The resulting performance is similiar: * sysdeps/i386/fpu/e_fmodf.S "fmodf": { "subnormals": { "duration": 3.68732e+09, "iterations": 2.2912e+08, "max": 71.447, "min": 15.836, "mean": 16.0934 }, "normal": { "duration": 3.75848e+09, "iterations": 5.5296e+07, "max": 273.208, "min": 15.725, "mean": 67.9702 }, "close-exponents": { "duration": 3.69035e+09, "iterations": 2.07872e+08, "max": 64.454, "min": 15.762, "mean": 17.753 } } * master "fmodf": { "subnormals": { "duration": 3.6863e+09, "iterations": 2.23616e+08, "max": 65.453, "min": 16.243, "mean": 16.485 }, "normal": { "duration": 3.71129e+09, "iterations": 5.3248e+07, "max": 281.57, "min": 16.169, "mean": 69.6983 }, "close-exponents": { "duration": 3.70274e+09, "iterations": 2.03776e+08, "max": 81.474, "min": 16.206, "mean": 18.1706 } } --- sysdeps/i386/fpu/e_fmodf.S | 18 ------------------ sysdeps/i386/fpu/math_err.c | 1 - sysdeps/i386/fpu/w_fmodf_compat.c | 15 --------------- sysdeps/unix/sysv/linux/i386/libm.abilist | 1 + 4 files changed, 1 insertion(+), 34 deletions(-) delete mode 100644 sysdeps/i386/fpu/e_fmodf.S delete mode 100644 sysdeps/i386/fpu/math_err.c delete mode 100644 sysdeps/i386/fpu/w_fmodf_compat.c diff --git a/sysdeps/i386/fpu/e_fmodf.S b/sysdeps/i386/fpu/e_fmodf.S deleted file mode 100644 index f73ce9da1e..0000000000 --- a/sysdeps/i386/fpu/e_fmodf.S +++ /dev/null @@ -1,18 +0,0 @@ -/* - * Public domain. - */ - -#include -#include - -ENTRY(__ieee754_fmodf) - flds 8(%esp) - flds 4(%esp) -1: fprem - fstsw %ax - sahf - jp 1b - fstp %st(1) - ret -END(__ieee754_fmodf) -libm_alias_finite (__ieee754_fmodf, __fmodf) diff --git a/sysdeps/i386/fpu/math_err.c b/sysdeps/i386/fpu/math_err.c deleted file mode 100644 index 1cc8931700..0000000000 --- a/sysdeps/i386/fpu/math_err.c +++ /dev/null @@ -1 +0,0 @@ -/* Not needed. */ diff --git a/sysdeps/i386/fpu/w_fmodf_compat.c b/sysdeps/i386/fpu/w_fmodf_compat.c deleted file mode 100644 index 5a61693e51..0000000000 --- a/sysdeps/i386/fpu/w_fmodf_compat.c +++ /dev/null @@ -1,15 +0,0 @@ -/* i386 provides an optimized __ieee752_fmodf. */ -#include -#ifdef SHARED -# undef SHLIB_COMPAT -# define SHLIB_COMPAT(a, b, c) 1 -# undef LIBM_SVID_COMPAT -# define LIBM_SVID_COMPAT 1 -# undef compat_symbol -# define compat_symbol(a, b, c, d) -# include -libm_alias_float (__fmod_compat, fmod) -#else -#include -#include -#endif diff --git a/sysdeps/unix/sysv/linux/i386/libm.abilist b/sysdeps/unix/sysv/linux/i386/libm.abilist index dccd7ccd79..73c14a914e 100644 --- a/sysdeps/unix/sysv/linux/i386/libm.abilist +++ b/sysdeps/unix/sysv/linux/i386/libm.abilist @@ -1189,3 +1189,4 @@ GLIBC_2.35 fsqrtl F GLIBC_2.35 hypot F GLIBC_2.35 hypotf F GLIBC_2.38 fmod F +GLIBC_2.38 fmodf F