From patchwork Wed Mar 13 00:04:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Palmer Dabbelt X-Patchwork-Id: 87100 X-Patchwork-Delegate: arjun.is@lostca.se Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 669453857C5B for ; Wed, 13 Mar 2024 00:11:45 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by sourceware.org (Postfix) with ESMTPS id 911C93858D1E for ; Wed, 13 Mar 2024 00:11:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 911C93858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 911C93858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::62c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710288678; cv=none; b=rkWTgMPILzSlEBmwDPA4qpFf5lV+BiqK2vmw/FcgDQ/CKIjvXSAXs44lHNb12UepE3GeaOCELVJb2L1Lz2Tt/pFSLgHCxr/4TDuS3ZTomugnXkkvIUN/MkvweMGCMlGbhCED9Ohy9iyTO7ft4FQQdQAp894xKlFeRScnODwNlc8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710288678; c=relaxed/simple; bh=AJBoZtybYc9+q4QG3lYhq6fF9XtoVVdx3ybCxwoiuhM=; h=DKIM-Signature:Subject:Date:Message-ID:MIME-Version:From:To; b=kRINFPT9z4F4OndQcUIXLhHFLlD1VrHUeSQvIEvU7QMqP4V7G0G+jOoGjKfrlAEl2V/9WxAUUDAKWWgmhm33Z0mpRNEiLI9V7U80wRKqp5bYdQ8hqv4pmPIth+jRoDhOc3p/dvrD0F2ISbbF+TQD9yFUBRT+h/DdthfJfKkJ5Dw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1dd922cbcc7so23029275ad.2 for ; Tue, 12 Mar 2024 17:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1710288675; x=1710893475; darn=sourceware.org; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:from:to:cc:subject:date:message-id:reply-to; bh=MjdnvM6ZMI5H50kU9v5O+GebdQRJ/9ovQ9yibx9KGvM=; b=pZwu0rLCTKDEpof1EL63XtqFvXdzd3gU/ZMXYowfoci2yShJnPSvleEPdOhcRaXcP+ EgPiLNz/1xnnWZQjcj9EVXsugfrPn9Lhp8iNI9X3gFO3s2FlmqOkQ4WK4ijEoRNgpyIZ 0mUAUZ71pzQMc9exPIKBMhUAwC/eksDmMUbxSSDED2Y3HbfcGqi/TMOvgk2yl1GVhhbE /vUo4TXear9NJUmhB1cc9FsFufRowOKhTnwqkwA+ppNv8C3EMecpC9fa67q/NoSkIl6E 3NSWJ+eEIBpzDtvdC/oqx4aEPc2aXfAgGTEjOvESfCkWbBlzQ+Ug5GT+gMX+H6aCv++B 8Wvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710288675; x=1710893475; h=to:from:cc:content-transfer-encoding:mime-version:message-id:date :subject:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MjdnvM6ZMI5H50kU9v5O+GebdQRJ/9ovQ9yibx9KGvM=; b=kmeJ/nugFq3SH2B6xFjuZWv27cz1uYjE0+m+e1LlIrgmAYcCMYCCn5O2gwXn6H+zuC Kn+31WoQUrjcHe0RM0HYsf0X0YhNzy0E2m4KX43EjWAk0hnlSY30o/Y+bxnxSMPm7tM0 4QwH0yGwU4U8Bg4Ws+X70us3MeBvX44lPENBCfnNx2/AAQEGr26nRNL2zfmndlGnJKsI FwV6lT3rLWH4j04t9/7Hq8ceOFCPyS78xg9rbqogVkEzBEYPC1wPkrYfmeIvQz5/NJAy xMdYdfLAXCnPaAOK8kvn1ax1rtELDZekllsWt5DacsMdmRy9ef0Z+w2FQYTLhhUbR/UY RflQ== X-Gm-Message-State: AOJu0Yz7oqDIJ2D6lycZiAWpvN/0NZx8582h24W/nn8Q3iihSmMNbSNW fw1XT2LU5WJxuiMCX8b5I1RJsE7EHSQqlDArQ2Flc10iiGeBm1349K4P8uxyEaUOJx2QsvhTsj0 z X-Google-Smtp-Source: AGHT+IGR9LKpI8FDd42ZqMPNdseQRsl396Bcn9CEDkULPDPV4lzM+vbMMeFqpXUcRlFHVzddLHep1A== X-Received: by 2002:a17:902:c3c6:b0:1dd:7b1d:af7f with SMTP id j6-20020a170902c3c600b001dd7b1daf7fmr12199884plj.58.1710288674821; Tue, 12 Mar 2024 17:11:14 -0700 (PDT) Received: from localhost ([50.213.54.97]) by smtp.gmail.com with ESMTPSA id w18-20020a170902e89200b001dd82855d47sm6710743plg.265.2024.03.12.17.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Mar 2024 17:11:14 -0700 (PDT) Subject: [PATCH v2] build-many-glibcs.py: Avoid loading user/system configurations Date: Tue, 12 Mar 2024 17:04:30 -0700 Message-ID: <20240313000429.23213-2-palmer@rivosinc.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Cc: libc-alpha@sourceware.org, Palmer Dabbelt From: Palmer Dabbelt To: simon.chopin@canonical.com, Carlos O'Donell X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org I have commit verification turned on by default, which trips up pulling when there is a non-signed commit at HEAD. There's likely a whole class of similar configuration issues that could crop up, so this just ignores user configuration files entirely. Signed-off-by: Palmer Dabbelt --- This has been pretty lightly tested, but it seems to not be breaking anything on my end. Changes since v1 <20240112185846.24483-1-palmer@rivosinc.com/>: * Ignore the git configs rather than passing "--no-verify-signatures" to "git pull" commands. --- scripts/build-many-glibcs.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py index cc30dd5862..0d06ca1ba4 100755 --- a/scripts/build-many-glibcs.py +++ b/scripts/build-many-glibcs.py @@ -1976,8 +1976,15 @@ def check_for_required_tools(): if count_old_tools > 0 or count_missing_tools > 0: exit (1); +def setup_env_vars(): + # Prevents git from loading configuration files, to avoid tripping over + # user settings like --verify-signatures. + os.environ["GIT_CONFIG_GLOBAL"] = "/dev/null" + os.environ["GIT_CONFIG_NOSYSTEM"] = "1" + def main(argv): """The main entry point.""" + setup_env_vars(); check_for_required_tools(); parser = get_parser() opts = parser.parse_args(argv)