From patchwork Thu Nov 30 18:32:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Evan Green X-Patchwork-Id: 81048 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3FC84385E008 for ; Thu, 30 Nov 2023 18:33:32 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by sourceware.org (Postfix) with ESMTPS id 69923385C423 for ; Thu, 30 Nov 2023 18:32:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 69923385C423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 69923385C423 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::42c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701369181; cv=none; b=QhveGIg2t3UZsd6GRdkKAt/jo1MOCSdppIHb/hMCp1BXWd9+i9p0qzvJ9H42jPg3gJvR7mqgM2lflbUDTtV2Feo1Y4L9bss9GJI3iCIyECgp57JqAGMhR6nxIhXsBN1Vc7X7jyNV8aoJarMd71iG5KlsMkAkQZFkd3mSr3QPcFw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701369181; c=relaxed/simple; bh=95bimGb4Wi1MoWmr4NkrTJX0yPrzk1X0RlkHN7FXf1Y=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=jl5mUYiS1TZ+85F7zxCR3A6rYxl5zLJhV4TviMiH1UxTwKdkK8W2TTJVVf2JLlp1N16OnlN1GGXLuFguthTTMM7Y0zxdo5s71HgB7CO3PySz28XQn5osGnJkPxXB5/lqSO+RIG1MLLble8MwKWSLwHa+iXHfpoO5pjAXTe6Vtqw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-6cbe716b511so1262225b3a.3 for ; Thu, 30 Nov 2023 10:32:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1701369177; x=1701973977; darn=sourceware.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gQBKb7U+e0DvkgZoB/Y+fqXWGiLbnYCp30WGnIDkx6A=; b=Qg3+dkwHc0ScK3n19e6jyShHtqqtETjrDqPSjsjktkN8Ut0F5Re3N5kzQJJjvAR6gA 4iUx5b9iQqioPmSEMZCp4+F9YCIAaJfAYiXJ6y0EufHfGo5imocmDjgW2G5ymFwJRh1n 7mKgh53RpDZ95KV2+y2rJE5ojigmW/SC1QT7kY+n6wQWmg3YylU4/CcfuxzmHTLBUe2n +Cx9VERNqzm1zIQQ/ZgjVtb+b2Ub50aSyOvYVupIA1ncDLYeu/41eNPFLDS5JJzbE9Hu a7vZmnBwYX6nC/Gx5pzPuZXKHnhprJGJhhjILPo9ZkIlG/W3GmLaKbR9fK0aMuoBlPeE 3/wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701369177; x=1701973977; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gQBKb7U+e0DvkgZoB/Y+fqXWGiLbnYCp30WGnIDkx6A=; b=MVqLU8zVa8DrS+LaP5evY69NtwHlH5u5Fas2F3gVcdW5rD7khpWKiJB/VQIhO1lusu lfXYKiuw87zF9N5K0Y5znwjZkZaARv8GxOqInFIfETPt3klrxJO1fO0bMsCMQBd1NRoZ vYA3BGfSr6xFO/7BsiuZhOmvp6EyF9I702dQ6ocqjJ8wBXp47lNfK4Nmg7wzzsZ7kfr4 /WMvIcjsTmi/Zd3ZDNQUJdrWtbDsoK9FaP7QAwvbsIvtreUQo+1H9ayho7W69kwy9Ey6 ciuu3yebHPqlN+DYWmEe4rC13phQ9vBsgSudJP9creMESKWwvCkJR9OsVkN51Jp4lcYr kfpg== X-Gm-Message-State: AOJu0YztnwHlFVbltrwqSqImqvCLvGjg5uiowX/6dUrLWFvWrgNzJhCG 7G/lyT1hpPqlwqA2MyrMNycMdwdoPLAA5NeHHUI= X-Google-Smtp-Source: AGHT+IHR1ubDtvD6CKPTwSTG5/lr+os7B4rNE+SajRaVqPhb3gS3Ismpwjmpq3Gc59lc7UzFPnM8tw== X-Received: by 2002:a05:6a00:2918:b0:6bd:3157:2dfe with SMTP id cg24-20020a056a00291800b006bd31572dfemr23666236pfb.7.1701369177169; Thu, 30 Nov 2023 10:32:57 -0800 (PST) Received: from evan.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id p3-20020a62ab03000000b0068fd026b496sm1512939pff.46.2023.11.30.10.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 10:32:56 -0800 (PST) From: Evan Green To: libc-alpha@sourceware.org Cc: Florian Weimer , palmer@rivosinc.com, vineetg@rivosinc.com, slewis@rivosinc.com, Evan Green Subject: [PATCH v9 4/6] riscv: Enable multi-arg ifunc resolvers Date: Thu, 30 Nov 2023 10:32:37 -0800 Message-Id: <20231130183239.598100-5-evan@rivosinc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231130183239.598100-1-evan@rivosinc.com> References: <20231130183239.598100-1-evan@rivosinc.com> MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org RISC-V is apparently the first architecture to pass more than one argument to ifunc resolvers. The helper macros in libc-symbols.h, __ifunc_resolver(), __ifunc(), and __ifunc_hidden(), are incompatible with this. These macros have an "arg" (non-final) parameter that represents the parameter signature of the ifunc resolver. The result is an inability to pass the required comma through in a single preprocessor argument. Rearrange the __ifunc_resolver() macro to be variadic, and pass the types as those variable parameters. Move the guts of __ifunc() and __ifunc_hidden() into new macros, __ifunc_args(), and __ifunc_args_hidden(), that pass the variable arguments down through to __ifunc_resolver(). Then redefine __ifunc() and __ifunc_hidden(), which are used in a bunch of places, to simply shuffle the arguments down into __ifunc_args[_hidden]. Finally, define a riscv-ifunc.h header, which provides convenience macros to those looking to write ifunc selectors that use both arguments. Signed-off-by: Evan Green --- Changes in v9: - Fix a couple of typos causing powerpc not to build (build-many-glibcs) Changes in v6: - Introduced riscv-ifunc.h for multi-arg ifunc selectors. --- include/libc-symbols.h | 28 +++++++++++++++++----------- sysdeps/riscv/riscv-ifunc.h | 27 +++++++++++++++++++++++++++ 2 files changed, 44 insertions(+), 11 deletions(-) create mode 100644 sysdeps/riscv/riscv-ifunc.h diff --git a/include/libc-symbols.h b/include/libc-symbols.h index 5794614488..b45fad72b3 100644 --- a/include/libc-symbols.h +++ b/include/libc-symbols.h @@ -665,9 +665,9 @@ for linking") #endif /* Helper / base macros for indirect function symbols. */ -#define __ifunc_resolver(type_name, name, expr, arg, init, classifier) \ +#define __ifunc_resolver(type_name, name, expr, init, classifier, ...) \ classifier inhibit_stack_protector \ - __typeof (type_name) *name##_ifunc (arg) \ + __typeof (type_name) *name##_ifunc (__VA_ARGS__) \ { \ init (); \ __typeof (type_name) *res = expr; \ @@ -675,13 +675,13 @@ for linking") } #ifdef HAVE_GCC_IFUNC -# define __ifunc(type_name, name, expr, arg, init) \ +# define __ifunc_args(type_name, name, expr, init, ...) \ extern __typeof (type_name) name __attribute__ \ ((ifunc (#name "_ifunc"))); \ - __ifunc_resolver (type_name, name, expr, arg, init, static) + __ifunc_resolver (type_name, name, expr, init, static, __VA_ARGS__) -# define __ifunc_hidden(type_name, name, expr, arg, init) \ - __ifunc (type_name, name, expr, arg, init) +# define __ifunc_args_hidden(type_name, name, expr, init, ...) \ + __ifunc_args (type_name, name, expr, init, __VA_ARGS__) #else /* Gcc does not support __attribute__ ((ifunc (...))). Use the old behaviour as fallback. But keep in mind that the debug information for the ifunc @@ -692,18 +692,24 @@ for linking") different signatures. (Gcc support is disabled at least on a ppc64le Ubuntu 14.04 system.) */ -# define __ifunc(type_name, name, expr, arg, init) \ +# define __ifunc_args(type_name, name, expr, init, ...) \ extern __typeof (type_name) name; \ - __typeof (type_name) *name##_ifunc (arg) __asm__ (#name); \ - __ifunc_resolver (type_name, name, expr, arg, init,) \ + __typeof (type_name) *name##_ifunc (__VA_ARGS__) __asm__ (#name); \ + __ifunc_resolver (type_name, name, expr, init, , __VA_ARGS__) \ __asm__ (".type " #name ", %gnu_indirect_function"); -# define __ifunc_hidden(type_name, name, expr, arg, init) \ +# define __ifunc_args_hidden(type_name, name, expr, init, ...) \ extern __typeof (type_name) __libc_##name; \ - __ifunc (type_name, __libc_##name, expr, arg, init) \ + __ifunc (type_name, __libc_##name, expr, __VA_ARGS__, init) \ strong_alias (__libc_##name, name); #endif /* !HAVE_GCC_IFUNC */ +#define __ifunc(type_name, name, expr, arg, init) \ + __ifunc_args (type_name, name, expr, init, arg) + +#define __ifunc_hidden(type_name, name, expr, arg, init) \ + __ifunc_args_hidden (type_name, name, expr, init, arg) + /* The following macros are used for indirect function symbols in libc.so. First of all, you need to have the function prototyped somewhere, say in foo.h: diff --git a/sysdeps/riscv/riscv-ifunc.h b/sysdeps/riscv/riscv-ifunc.h new file mode 100644 index 0000000000..7bff591d1e --- /dev/null +++ b/sysdeps/riscv/riscv-ifunc.h @@ -0,0 +1,27 @@ +/* Common definition for ifunc resolvers. Linux/RISC-V version. + This file is part of the GNU C Library. + Copyright (C) 2023 Free Software Foundation, Inc. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +#include +#include +#include + +#define INIT_ARCH() + +#define riscv_libc_ifunc(name, expr) \ + __ifunc_args (name, name, expr(hwcap, hwprobe), INIT_ARCH, \ + uint64_t hwcap, __riscv_hwprobe_t hwprobe)