From patchwork Mon Nov 20 18:47:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Carlos O'Donell X-Patchwork-Id: 80384 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 48A903858D37 for ; Mon, 20 Nov 2023 18:47:55 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2E4653858D33 for ; Mon, 20 Nov 2023 18:47:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2E4653858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2E4653858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700506063; cv=none; b=ASPRznP0chvhpTK7q30vhrPdB+eTIw0NRo8DRSRGENl2oXS3AaNBA9bUkPDG6xL2+J9U/XXObZf0mfjEF9GqnZcOMhEj+FrgVPPn1+JBlwF9dVcQ7sgZTIL8YEOw9zhJlB1/vqIzYZq1RCg5E/8eYWa9Bt1wgwJiITCC0uE54d8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700506063; c=relaxed/simple; bh=JkJ1cPvCq+DnLOtl7INDGsKkyIzJm2HmoBnWQjKQ6QI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=D2LCHQJmdUQrImdmAuw09j5zZwfj0ATE7+gZxMmURgOelW/VA0OSDrIoZHG58PBIEVOArg48fe4FCDr/rhY3aAu1YvjId/59EpZqObJS8XLwVyff9GexIe1kRN4iNtPB0cMLE3Vk7KoQPo/zEXq5BxOyG05pce3IMrJUrEk8+Qc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700506061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MzoFtddpqkQs3wUMuIM+m2ss5DE7Vq5cda+/Ow8FB7g=; b=djkUd62m9lUzj0vNc063ZcllXUkdW+hOt3RpPp+8m/rXfOVj5QWm0gQZsyL5xqu8X8tGZ/ 7lccDc6/XpG8NTDZt40TQgPwhI2qxfjYd8rFhHvQoQ8JUC7ZU3HR5BqzyBd/eKgvUkXnCA /TujHuCJVFHmle9G2PnUnU9HDD8u2bk= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-Nue_R0EkPuac7REppBwUzQ-1; Mon, 20 Nov 2023 13:47:40 -0500 X-MC-Unique: Nue_R0EkPuac7REppBwUzQ-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-58a21120248so4358696eaf.0 for ; Mon, 20 Nov 2023 10:47:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700506059; x=1701110859; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MzoFtddpqkQs3wUMuIM+m2ss5DE7Vq5cda+/Ow8FB7g=; b=CtLebYrBqQopucQD144diQrGsUFakhkp5pgo4YXkydWGmi7hnH2ZghmPZmO6Yea5Ro gwq+0BxqZeZINRoxHLA8CQ5FHO4DJM8n0hzOkIwllaPnyMsQYwbG3wBiQCzWlHBmJKgx lmvAP2fN0D39k6uJSbY2Uu/CoeQph+zJEJQcq4xY6F9nNLM0AYXYx7cfhEnvnIbDYvUL WgsTbOZgOKpqjCyiMzQYD6xqa8aUYGiFbHdC9klf9aKuo7EPDaxM9ikWLiQ5sm3qiDao oE2ZyxMJ85p0EMKFK86iQlgu0GMGVux/JPy4CI4Ae4i8Rou2v7tzdMdUPyr1g4mZWG+V J2lQ== X-Gm-Message-State: AOJu0YwRo2nUAzgJv3ueTaGoWQRrfoYYAhpgsRmBJSITqDGDAnPekeoe sCpF5mEmZBbajNwPs8Sdyf2afZl1rSsR3yk6h6an4BDdq6V3MrySCsL0gSvRWTfNXLpts2rEduV vyFDVyC06nIPT9LfW3K45J0ZveDEXOqev+FYARc97RM+BBKWKHfO80mo5RY34ojQlslQGdRfiQf OOwA== X-Received: by 2002:a05:6358:5922:b0:16b:faa5:383a with SMTP id g34-20020a056358592200b0016bfaa5383amr3704513rwf.27.1700506059571; Mon, 20 Nov 2023 10:47:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IFNxpdkVXaSXZzaHdoufKylbVrdvXbsQOqKurqm+z9aGkle5+l1M7Wsb9+RMsD47bDrnB51KQ== X-Received: by 2002:a05:6358:5922:b0:16b:faa5:383a with SMTP id g34-20020a056358592200b0016bfaa5383amr3704494rwf.27.1700506059209; Mon, 20 Nov 2023 10:47:39 -0800 (PST) Received: from athas.redhat.com ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id ph7-20020a0562144a4700b006731d3380f1sm3146432qvb.15.2023.11.20.10.47.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 10:47:38 -0800 (PST) From: Carlos O'Donell To: libc-alpha@sourceware.org Cc: Carlos O'Donell Subject: [PATCH] manual: Fix termios.c example. (Bug 31078) Date: Mon, 20 Nov 2023 13:47:25 -0500 Message-ID: <20231120184732.1590032-1-carlos@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-type: text/plain; charset=UTF-8 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Remove the unused 'char *name;' from the example. Use write instead of putchar to write input as it is read. Example tested on x86_64 by compiling and running the example. Tested by building the manual pdf and reviewing the results. Reviewed-by: Florian Weimer --- manual/examples/termios.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/manual/examples/termios.c b/manual/examples/termios.c index 751e57ad71..65bedad9cc 100644 --- a/manual/examples/termios.c +++ b/manual/examples/termios.c @@ -34,7 +34,6 @@ void set_input_mode (void) { struct termios tattr; - char *name; /* Make sure stdin is a terminal. */ if (!isatty (STDIN_FILENO)) @@ -70,7 +69,7 @@ main (void) if (c == '\004') /* @kbd{C-d} */ break; else - putchar (c); + write (STDOUT_FILENO, &c, 1); } return EXIT_SUCCESS;