From patchwork Sat Sep 23 15:49:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manjunath Matti X-Patchwork-Id: 76604 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 543723857B9B for ; Sat, 23 Sep 2023 15:50:14 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 97D6F3858C66 for ; Sat, 23 Sep 2023 15:50:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 97D6F3858C66 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38NFo0Qh021858 for ; Sat, 23 Sep 2023 15:50:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=228NKjT7/duuV9DgaJFWNxUBpZQov6pkKzLsOlxoW8w=; b=bopfU7+Al9xQAv0srX0IDZRGrSVC91AZ5RZeSWiRo4phQj4wknQ6XKy+mSIDc+NKtete HXluHixGcCpYwaC+BciN190sK6Go0F51H6nbu05rKZ/Z+QT/V+aBwIZfjRomJ+pFzu7a rgdNdCPpnrjdFjIRD34YjMzdxJBkZR6CngKLVLFrss1m+vdvlKB37JfHX34Oq84rj5fM wqVKa+4b+6ygpFIe5jJXfTCNT0lbf2A2JJp7XPLfSC9xC+pAav+/LF9BMS40hUoruvJs xPCP1LrvtYUQGgPiUh2oqtPGyt/gkZOXIYaZCRmbXuiYeopikyVuPICUGI/wBL+nSVSi rg== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ta2f28d10-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 23 Sep 2023 15:49:59 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 38NEUL5e014944 for ; Sat, 23 Sep 2023 15:49:59 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3t8tsmxrga-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 23 Sep 2023 15:49:59 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 38NFntRf27525508 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 23 Sep 2023 15:49:55 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C114920040; Sat, 23 Sep 2023 15:49:55 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DC57120043; Sat, 23 Sep 2023 15:49:54 +0000 (GMT) Received: from ltcden2-lp1.aus.stglabs.ibm.com (unknown [9.3.90.43]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Sat, 23 Sep 2023 15:49:54 +0000 (GMT) From: Manjunath Matti To: libc-alpha@sourceware.org Cc: rajis@linux.ibm.com, Manjunath Matti , Carl Love Subject: [PATCH] [powerpc] fegetenv_and_set_rn now uses the builtins provided by GCC. Date: Sat, 23 Sep 2023 10:49:51 -0500 Message-Id: <20230923154951.3783611-1-mmatti@linux.ibm.com> X-Mailer: git-send-email 2.39.3 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Vx8OjV140nYBxlx9cvJ_X_xvhQcF3aqY X-Proofpoint-GUID: Vx8OjV140nYBxlx9cvJ_X_xvhQcF3aqY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-09-23_12,2023-09-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 suspectscore=0 mlxlogscore=709 adultscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 spamscore=0 mlxscore=0 phishscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2309230131 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org On powerpc, SET_RESTORE_ROUND uses inline assembly to optimize the prologue get/save/set rounding mode operations for POWER9 and later by using 'mffscrn' where possible, this was introduced by commit f1c56cdff09f650ad721fae026eb6a3651631f3d. GCC version 14 onwards supports builtins as __builtin_set_fpscr_rn which now returns the FPSCR fields in a double. This feature is available on Power9 when the __SET_FPSCR_RN_RETURNS_FPSCR__ macro is defined. GCC commit ef3bbc69d15707e4db6e2f198c621effb636cc26 adds this feature. Changes are done to use __builtin_set_fpscr_rn instead of mffscrn or mffscrni in __fe_mffscrn(rn). Suggested-by: Carl Love Reviewed-by: Adhemerval Zanella --- sysdeps/powerpc/fpu/fenv_libc.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sysdeps/powerpc/fpu/fenv_libc.h b/sysdeps/powerpc/fpu/fenv_libc.h index fa5e1c697e..a2a12d914b 100644 --- a/sysdeps/powerpc/fpu/fenv_libc.h +++ b/sysdeps/powerpc/fpu/fenv_libc.h @@ -68,6 +68,14 @@ extern const fenv_t *__fe_mask_env (void) attribute_hidden; __fr; \ }) +/* Starting with GCC 14 __builtin_set_fpscr_rn can be used to return the + FPSCR fields as a double. This support is available + on Power9 when the __SET_FPSCR_RN_RETURNS_FPSCR__ macro is defined. + To retain backward compatibility with older GCC, we still retain the + old inline assembly implementation.*/ +#ifdef __SET_FPSCR_RN_RETURNS_FPSCR__ +#define __fe_mffscrn(rn) __builtin_set_fpscr_rn (rn) +#else #define __fe_mffscrn(rn) \ ({register fenv_union_t __fr; \ if (__builtin_constant_p (rn)) \ @@ -83,6 +91,7 @@ extern const fenv_t *__fe_mask_env (void) attribute_hidden; } \ __fr.fenv; \ }) +#endif /* Like fegetenv_control, but also sets the rounding mode. */ #ifdef _ARCH_PWR9