From patchwork Tue Jul 25 15:16:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 73165 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 071983870897 for ; Tue, 25 Jul 2023 15:17:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 071983870897 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1690298244; bh=DgJ6I3dc3z2MUek6sIZJn5wSYmQl6Rm26C+SFS7Ffp8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=PE72GkmxXOMREaGmYoBSJ4OjVKX6LYfFD8qUgO7I1bWc9rwIimI63P2s89cXLWrBx rNZEwYtl+701iYJr1mKVPFGaSdWkk2MWVgpfyPKq9afaD7EThjSJvoQ2SFE5V9Vwzo fYEYTSDfrXJZEjXPAJJvMreC7PAaqaqC6GQH7w8o= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id ECF17385AF94 for ; Tue, 25 Jul 2023 15:16:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ECF17385AF94 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-1bb5ce75e43so1312322fac.3 for ; Tue, 25 Jul 2023 08:16:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690298212; x=1690903012; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DgJ6I3dc3z2MUek6sIZJn5wSYmQl6Rm26C+SFS7Ffp8=; b=O1k5otr4grF5ZqqZWz2F1j5NGLFOEpbvn4fsDigSpOOds4CRFXDC/58g0LsGNvOPNs mWeBhMEle7SgMSxTj1iMXoRMGcQG2+X9L8rCP1DACia3Ql0fKCNtt3WHHdYvKt3jkfyp Kw5Z9FjKhyVFRnFA7CbLd998NS55M4CnpE4iSy4mkqx10ehxrkj2R1UthDmYPEX1/4iM 3SJJ7qkjKtikSmYcD5BlrFU/eKGxnRZ/gOLifQPsEE2+Rw2GYEeRcp1Q5znancjErxbh NwZT1yZwRIMVKLF0LIw2f2lnVW3filoMFQxpaBUiIX4y9uNxL7WP+rwFJAHyGoGTlv1v 47wA== X-Gm-Message-State: ABy/qLaK5PIVpXdvuoWJr/xmoTnxlrVnUau5NrXR6GOdx3MF9O/IcuOR DwbKV0Yn7I4//GW1zfFGly0ta7UepFAYIT8R9pXTtA== X-Google-Smtp-Source: APBJJlH44p1rGvbdLc2dOXa0ZWILjCsb52LAe+JFKZr4V6SGYcfun5tjZoBjP7q0CMFaAuFt3AnI/Q== X-Received: by 2002:a05:6870:82a3:b0:1b0:18e8:9535 with SMTP id q35-20020a05687082a300b001b018e89535mr12532476oae.56.1690298212530; Tue, 25 Jul 2023 08:16:52 -0700 (PDT) Received: from mandiga.. ([2804:1b3:a7c0:d4d2:3277:e224:7a6f:4feb]) by smtp.gmail.com with ESMTPSA id ea3-20020a056870070300b001bb9d01fe3dsm525439oab.5.2023.07.25.08.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 08:16:51 -0700 (PDT) To: libc-alpha@sourceware.org, Frederic Berat Subject: [PATCH 3/4] linux: Fix i686 with gcc6 Date: Tue, 25 Jul 2023 12:16:40 -0300 Message-Id: <20230725151641.923083-4-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230725151641.923083-1-adhemerval.zanella@linaro.org> References: <20230725151641.923083-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Netto Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" On __convert_scm_timestamps GCC 6 issues an warning that tvts[0]/tvts[1] maybe be used uninitialized, however it would be used if type is set to a value different than 0 (done by either COMPAT_SO_TIMESTAMP_OLD or COMPAT_SO_TIMESTAMPNS_OLD) which will fallthrough to 'common' label. It does not show with gcc 7 or more recent versions. Checked on i686-linux-gnu. Reviewed-by: Carlos O'Donell --- sysdeps/unix/sysv/linux/convert_scm_timestamps.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/sysdeps/unix/sysv/linux/convert_scm_timestamps.c b/sysdeps/unix/sysv/linux/convert_scm_timestamps.c index 42f9613416..06c8adeee1 100644 --- a/sysdeps/unix/sysv/linux/convert_scm_timestamps.c +++ b/sysdeps/unix/sysv/linux/convert_scm_timestamps.c @@ -23,6 +23,7 @@ # include # include # include +# include /* It converts the first SO_TIMESTAMP or SO_TIMESTAMPNS with 32-bit time and appends it to the control buffer. The 32-bit time field is kept as-is. @@ -44,7 +45,15 @@ __convert_scm_timestamps (struct msghdr *msg, socklen_t msgsize) 'struct __kernel_sock_timeval' while for SO_TIMESTAMPNS_NEW is a 'struct __kernel_timespec'. In either case it is two uint64_t members. */ + + /* GCC 6 issues an warning that tvts[0]/tvts[1] maybe be used uninitialized, + however it would be used if type is set to a value different than 0 + (done by either COMPAT_SO_TIMESTAMP_OLD or COMPAT_SO_TIMESTAMPNS_OLD) + which will fallthrough to 'common' label. */ + DIAG_PUSH_NEEDS_COMMENT; + DIAG_IGNORE_NEEDS_COMMENT (6, "-Wmaybe-uninitialized"); int64_t tvts[2]; + DIAG_POP_NEEDS_COMMENT; int32_t tmp[2]; struct cmsghdr *cmsg, *last = NULL;