From patchwork Wed May 3 21:16:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roy Eldar X-Patchwork-Id: 68708 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AA3403858289 for ; Wed, 3 May 2023 21:19:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA3403858289 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683148784; bh=Ram4VGizF1CvapatOZz67a8WtFR5qpsK2en802O0Vpk=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=VoepZWdqd0cxdEgoLtjtUle6odnBJ31cN92eCRRHd85ir1tsgcITrKO1znO5ENnJP ry+AQUEWsHRX88y1Z0wcF7xga50CHkan8eIZJC/SPlYzv+/q7eiiUHf1FD2AXjIb4M bvxYLli9XfM5xdIOa19GtIwhY85RFOMFZuf16mWQ= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id 2EC8B3858D28 for ; Wed, 3 May 2023 21:19:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2EC8B3858D28 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f1e2555b5aso39482915e9.0 for ; Wed, 03 May 2023 14:19:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683148758; x=1685740758; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ram4VGizF1CvapatOZz67a8WtFR5qpsK2en802O0Vpk=; b=RuaOi6ulOy1Xaz2yzDg46T5Tkcmb/ByhLX1i8JWKI1nHn9auJdPbs9wx+RlAn0sw7B ebJvxtK9P5ZW4U2tbOXzC3kEMHtSBNQ1XQsIScg8hYU0dsrVl5wXBcjzE5JXcqxsGq0O hNbfuvQWujsS0/KdMw9akwtp0OFfJTlUoI96F8kbOyT+5J+9z3ZmXFVk0SDvy3vrriCq HUb0ZNyrD6yb/WBwshGmjY1Lk9/p8vbx3yXJ35hHyDbz/QlFom9Cu3AD+5zCJJCeVaLS 5Tp2SyuPWjb6EQYMVyjL7WhFAeIqyxS0DUq2uYuWRH1ziAlH8ExLDTXdb9edufK+insD DpmA== X-Gm-Message-State: AC+VfDyE7ksRjOi6CbICXO1J2ejJKcIJzCMYpWmCG6GNlzRnse10qfAi 3NJZQ4OIeZnkVsIvzxhCxVAgLY8bdkY= X-Google-Smtp-Source: ACHHUZ7fFeRP7YJQonBwjE9YQlebNu1L3xLUiYDnDMMh3dFUa1TXX4bkwNjHLcVkknruAzLiQSc5Vg== X-Received: by 2002:a05:600c:2052:b0:3ee:ed5:6115 with SMTP id p18-20020a05600c205200b003ee0ed56115mr16259613wmg.19.1683148758390; Wed, 03 May 2023 14:19:18 -0700 (PDT) Received: from DESKTOP-FOQ07IR.localdomain ([2a00:a040:191:d233:a0d3:128:719:92d3]) by smtp.gmail.com with ESMTPSA id u24-20020a7bc058000000b003f173987ec2sm2873038wmc.22.2023.05.03.14.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 May 2023 14:19:17 -0700 (PDT) To: libc-alpha@sourceware.org Cc: Roy Eldar , carlos@redhat.com Subject: [PATCH] elf: fix handling of negative numbers in dl-printf Date: Thu, 4 May 2023 00:16:41 +0300 Message-Id: <20230503211641.5742-1-royeldar0@gmail.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Roy Eldar via Libc-alpha From: Roy Eldar Reply-To: Roy Eldar Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" _dl_debug_vdprintf is a bare-bones printf implementation; currently printing a signed integer (using "%d" format specifier) behaves incorrectly when the number is negative, as it just prints the corresponding unsigned integer, preceeded by a minus sign. For example, _dl_printf("%d", -1) would print '-4294967295'. Signed-off-by: Roy Eldar --- elf/dl-printf.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/elf/dl-printf.c b/elf/dl-printf.c index e8b9900370..977ac330b6 100644 --- a/elf/dl-printf.c +++ b/elf/dl-printf.c @@ -150,19 +150,25 @@ _dl_debug_vdprintf (int fd, int tag_p, const char *fmt, va_list arg) if (long_mod) { if ((long int) num < 0) - negative = true; + { + num = -num; + negative = true; + } } else { if ((int) num < 0) { - num = (unsigned int) num; + num = -(unsigned int) num; negative = true; } } #else if ((int) num < 0) - negative = true; + { + num = -num; + negative = true; + } #endif }