From patchwork Thu Aug 4 06:04:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fangrui Song X-Patchwork-Id: 56531 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 07AF63857363 for ; Thu, 4 Aug 2022 06:05:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07AF63857363 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659593111; bh=7eEz6LejeRGxqbPGVbR4BwJEmEuUAp+LRZPFsUHFLdU=; h=Date:Subject:To:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ZsndalcdPfWEizXdRos2OcAp8Sv7QihBDMgQesvJu/0LuRv936FRvPRo2AATAaTm3 222kkvfVBQRdUDFMxtkU4me8Rtz0KcDlBfq7XvWGSgBjY93rPNG3YuDSTjQlJ8nr7f ZQol8W4EJSDS8ckx9x+HXanOqRBkOfoHwQI/AVlA= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by sourceware.org (Postfix) with ESMTPS id 22E80385802E for ; Thu, 4 Aug 2022 06:04:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 22E80385802E Received: by mail-yb1-xb49.google.com with SMTP id t10-20020a5b07ca000000b0066ec1bb6e2cso14931335ybq.14 for ; Wed, 03 Aug 2022 23:04:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:mime-version:message-id:date:x-gm-message-state :from:to:cc; bh=7eEz6LejeRGxqbPGVbR4BwJEmEuUAp+LRZPFsUHFLdU=; b=T1ffxO5LcngIvK6Fr6N1QJl7Lq9gboQdB7FRh0ww5oHZ+orMvrmliSa5YZYvEyvqTt jo7og80pFFJJLthMaunoMpNjpx6jw9F6t6iFRJucxAGYQpWxtvn5Lx1vZ0XFMLzYGqTo pmYyN+/qH66fPrgwNhsxg4ZU31bm4PKx6kYa2CY6r19ASJcwdXxBnnE8HNzSfkoOpVCc 8yem3H4LwTFIJn00Ln1+A0TBx3PVfIhM4b4C6Na8sNwBvbMG+eu78Y8i1XUxHhQnxexE s3L88KaK/Upg/6u3mQEJ9PceRQwslJ1mft/3Z73oNZXWJ00/PU9vXC6kr89uTL1mCU67 0iYQ== X-Gm-Message-State: ACgBeo0s35qkr+7yJmigACzjwsKtGLMBdwWp+NlHK5DnU4BNV7r3JHQr HkCThqXKHW5EaEVy9OSBWCSYyeniIbDJxJZMG9FLZ4H2a31fOhxxJOJaTrMMs6nWpveDFHgWb2e 6h4yQudb7VkKhyyE1QssmogWKsDNEoh2paBG7tDpot2EpteR29gyyW5pLCqwF1SRhucqQ X-Google-Smtp-Source: AA6agR6qPRhYyEv5CJdvepjOMZRi0P2mIfGj+/o2eusYyGvBTI3JKh+uNQW3HXDXm3reS3V4WFLGRwCs1L7v X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:e5ae:2f94:d58d:3fd3]) (user=maskray job=sendgmr) by 2002:a25:8148:0:b0:67a:6ae6:8e18 with SMTP id j8-20020a258148000000b0067a6ae68e18mr211863ybm.289.1659593089403; Wed, 03 Aug 2022 23:04:49 -0700 (PDT) Date: Wed, 3 Aug 2022 23:04:32 -0700 Message-Id: <20220804060432.2200849-1-maskray@google.com> Mime-Version: 1.0 Subject: [PATCH] i386: Replace movzx with movzbl To: libc-alpha@sourceware.org, "H.J. Lu" X-Spam-Status: No, score=-20.0 required=5.0 tests=BAYES_00, DKIMWL_WL_MED, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Fangrui Song via Libc-alpha From: Fangrui Song Reply-To: Fangrui Song Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" Similar to 6720d36b6623c5e48c070d86acf61198b33e144e for x86-64. Clang cannot assemble movzx in the AT&T dialect mode. Change movzx to movzbl, which follows the AT&T dialect and is used elsewhere in the file. --- sysdeps/i386/i686/multiarch/strcmp-ssse3.S | 36 +++++++++++----------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S index ac5096f68d..3435691f23 100644 --- a/sysdeps/i386/i686/multiarch/strcmp-ssse3.S +++ b/sysdeps/i386/i686/multiarch/strcmp-ssse3.S @@ -2141,8 +2141,8 @@ L(less16bytes): jbe L(eq) #endif - movzx 7(%eax), %ecx - movzx 7(%edx), %eax + movzbl 7(%eax), %ecx + movzbl 7(%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC movl _nl_C_LC_CTYPE_tolower@GOTOFF+128*4(%ebx,%ecx,4), %ecx @@ -2161,8 +2161,8 @@ L(Byte0): cmp $0, REM jbe L(eq) #endif - movzx (%eax), %ecx - movzx (%edx), %eax + movzbl (%eax), %ecx + movzbl (%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC @@ -2182,8 +2182,8 @@ L(Byte1): cmp $1, REM jbe L(eq) #endif - movzx 1(%eax), %ecx - movzx 1(%edx), %eax + movzbl 1(%eax), %ecx + movzbl 1(%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC @@ -2203,8 +2203,8 @@ L(Byte2): cmp $2, REM jbe L(eq) #endif - movzx 2(%eax), %ecx - movzx 2(%edx), %eax + movzbl 2(%eax), %ecx + movzbl 2(%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC @@ -2224,8 +2224,8 @@ L(Byte3): cmp $3, REM jbe L(eq) #endif - movzx 3(%eax), %ecx - movzx 3(%edx), %eax + movzbl 3(%eax), %ecx + movzbl 3(%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC @@ -2245,8 +2245,8 @@ L(Byte4): cmp $4, REM jbe L(eq) #endif - movzx 4(%eax), %ecx - movzx 4(%edx), %eax + movzbl 4(%eax), %ecx + movzbl 4(%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC @@ -2266,8 +2266,8 @@ L(Byte5): cmp $5, REM jbe L(eq) #endif - movzx 5(%eax), %ecx - movzx 5(%edx), %eax + movzbl 5(%eax), %ecx + movzbl 5(%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC @@ -2287,8 +2287,8 @@ L(Byte6): cmp $6, REM jbe L(eq) #endif - movzx 6(%eax), %ecx - movzx 6(%edx), %eax + movzbl 6(%eax), %ecx + movzbl 6(%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC @@ -2337,8 +2337,8 @@ L(2next_8_bytes): cmp $7, REM jbe L(eq) #endif - movzx 7(%eax), %ecx - movzx 7(%edx), %eax + movzbl 7(%eax), %ecx + movzbl 7(%edx), %eax #if defined USE_AS_STRCASECMP_L || defined USE_AS_STRNCASECMP_L # ifdef PIC