diff mbox series

[v5] elf: fixes compile error when both enable -Werror and -DNDEBUG

Message ID 20220415092505.338-1-yangyanchao6@huawei.com
State Committed
Commit 5e89ed42fd8997414732525c9460878d65363b3f
Headers
Series [v5] elf: fixes compile error when both enable -Werror and -DNDEBUG |

Checks

Context Check Description
dj/TryBot-32bit success Build for i686
dj/TryBot-apply_patch success Patch applied to master at the time it was sent

Commit Message

Yang Yanchao April 15, 2022, 9:25 a.m. UTC 
  Use -Werror and -DNDEBUG at the same time will
causes the following compilation errors:

cache.c: In function 'save_cache':
cache.c:758:15: error: unused variable 'old_offset' [-Werror=unused-variable]
  758 |       off64_t old_offset = lseek64 (fd, extension_offset, SEEK_SET);
      |               ^~~~~~~~~~

-DNDEBUG will disables the assertion.
Therefore, only the variables used by assertions do not take effect.
use __attribute__ ((unused)) to disable this warning.
---
 elf/cache.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/elf/cache.c b/elf/cache.c
index dbf4c83a7a..e92860023c 100644
--- a/elf/cache.c
+++ b/elf/cache.c
@@ -754,7 +754,8 @@  save_cache (const char *cache_name)
   if (opt_format != opt_format_old)
     {
       /* Align file position to 4.  */
-      off64_t old_offset = lseek64 (fd, extension_offset, SEEK_SET);
+      __attribute__ ((unused)) off64_t old_offset
+        = lseek64 (fd, extension_offset, SEEK_SET);
       assert ((unsigned long long int) (extension_offset - old_offset) < 4);
       write_extensions (fd, str_offset, extension_offset);
     }