diff mbox series

[v4,5/5] NEWS: Mention DT_RELR support

Message ID 20220301161706.185216-6-hjl.tools@gmail.com
State Superseded
Headers
Series Support DT_RELR relative relocation format |

Checks

Context Check Description
dj/TryBot-32bit success Build for i686

Commit Message

H.J. Lu March 1, 2022, 4:17 p.m. UTC 
  ---
 NEWS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fangrui Song March 1, 2022, 7:21 p.m. UTC | #1 
On 2022-03-01, H.J. Lu wrote:
>---
> NEWS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/NEWS b/NEWS
>index 626eeabf5d..2122c1e23e 100644
>--- a/NEWS
>+++ b/NEWS
>@@ -9,7 +9,7 @@ Version 2.36
>
> Major new features:
>
>-  [Add new features here]
>+* Support DT_RELR relative relocation format.
>
> Deprecated and removed features, and other changes affecting compatibility:
>
>-- 
>2.35.1

Perhaps worth a bit more information like:

The position-indepdent executable/shared object using DT_RELR needs to be linked with -z pack-relative-relocs.

--pack-dyn-relocs=relr is pretty common but doesn't work. So worth
calling out the supported linker option.

Reviewed-by: Fangrui Song <maskray@google.com>
H.J. Lu March 1, 2022, 10:37 p.m. UTC | #2 
On Tue, Mar 1, 2022 at 11:21 AM Fangrui Song <maskray@google.com> wrote:
>
>
> On 2022-03-01, H.J. Lu wrote:
> >---
> > NEWS | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/NEWS b/NEWS
> >index 626eeabf5d..2122c1e23e 100644
> >--- a/NEWS
> >+++ b/NEWS
> >@@ -9,7 +9,7 @@ Version 2.36
> >
> > Major new features:
> >
> >-  [Add new features here]
> >+* Support DT_RELR relative relocation format.
> >
> > Deprecated and removed features, and other changes affecting compatibility:
> >
> >--
> >2.35.1
>
> Perhaps worth a bit more information like:
>
> The position-indepdent executable/shared object using DT_RELR needs to be linked with -z pack-relative-relocs.

How about

* Support DT_RELR relative relocation format generated with the linker
  option, -z pack-relative-relocs.

> --pack-dyn-relocs=relr is pretty common but doesn't work. So worth
> calling out the supported linker option.
>
> Reviewed-by: Fangrui Song <maskray@google.com>
Fangrui Song March 1, 2022, 10:38 p.m. UTC | #3 
On Tue, Mar 1, 2022 at 2:37 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> On Tue, Mar 1, 2022 at 11:21 AM Fangrui Song <maskray@google.com> wrote:
> >
> >
> > On 2022-03-01, H.J. Lu wrote:
> > >---
> > > NEWS | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/NEWS b/NEWS
> > >index 626eeabf5d..2122c1e23e 100644
> > >--- a/NEWS
> > >+++ b/NEWS
> > >@@ -9,7 +9,7 @@ Version 2.36
> > >
> > > Major new features:
> > >
> > >-  [Add new features here]
> > >+* Support DT_RELR relative relocation format.
> > >
> > > Deprecated and removed features, and other changes affecting compatibility:
> > >
> > >--
> > >2.35.1
> >
> > Perhaps worth a bit more information like:
> >
> > The position-indepdent executable/shared object using DT_RELR needs to be linked with -z pack-relative-relocs.
>
> How about
>
> * Support DT_RELR relative relocation format generated with the linker
>   option, -z pack-relative-relocs.

Looks good.

> > --pack-dyn-relocs=relr is pretty common but doesn't work. So worth
> > calling out the supported linker option.
> >
> > Reviewed-by: Fangrui Song <maskray@google.com>
>
>
>
> --
> H.J.
diff mbox series

Patch

diff --git a/NEWS b/NEWS
index 626eeabf5d..2122c1e23e 100644
--- a/NEWS
+++ b/NEWS
@@ -9,7 +9,7 @@  Version 2.36
 
 Major new features:
 
-  [Add new features here]
+* Support DT_RELR relative relocation format.
 
 Deprecated and removed features, and other changes affecting compatibility: