Message ID | 20220212102529.1380928-1-goldstein.w.n@gmail.com |
---|---|
State | Committed |
Commit | 7912236f4a597deb092650ca79f33504ddb4af28 |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 383C93858038 for <patchwork@sourceware.org>; Sat, 12 Feb 2022 10:25:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 383C93858038 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644661557; bh=ZAoZyZHi70v3n1FzRrQIBwf0hMMYwrdCYpeB784m/c0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=gRmnlxFcHhN8hiPq91llrQk/8uzFES0RlcIa10CcdJ3A6yNpChz4FogCNtJuHwYvF K4LOzxn52JWkNpsrMpCGFYaagXRjMFmXE/AdFdzq0OZCCHccfiWT00Td0q9Ove/E1/ m2Jhgd2YcaSlCHrStwTbCXDx7zqYsO1lJmjPcJkk= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-il1-x136.google.com (mail-il1-x136.google.com [IPv6:2607:f8b0:4864:20::136]) by sourceware.org (Postfix) with ESMTPS id 601943858D37 for <libc-alpha@sourceware.org>; Sat, 12 Feb 2022 10:25:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 601943858D37 Received: by mail-il1-x136.google.com with SMTP id o10so8765357ilh.0 for <libc-alpha@sourceware.org>; Sat, 12 Feb 2022 02:25:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ZAoZyZHi70v3n1FzRrQIBwf0hMMYwrdCYpeB784m/c0=; b=NRHE875aCN9AtNEkofMJn9juTkUg2u4pT1MHQfC+JUHQcqVaqVE4T5EU4DzhxxTUR0 +NH5+GLGZfCL7tJXC/8HIKMB4z3xPMm200ZiaWMYmJeGnA8plTJivWCxTotjlUyGNE3b krFBPVu9762IEic+yToZpe4puKzYclMYWISPzQQKiVMdp7M5mKCJpofuhJ5ZgqkRHKZJ PCxWtHQ3WiItw1aY1kFsXnbXw0iweaM5ShKzc67wApORH0bILfo5SQrrsbeKzFg8f1rx p2sIcE3eZ1tsKFsHYCiDo/m7BDoRODMDa1fsYVG2nX8bOmxcITZjps2QVOE+kIG1zxOH VY7A== X-Gm-Message-State: AOAM533Ntb/EvziFNYG73bnLbDIuBcqvN484GfnVaWOjjHM1rWaEGwHm lGW1QL4Q2SKMGg/xi85WaoLsvLjDttU= X-Google-Smtp-Source: ABdhPJwkjjywdiuy7bHBoOp7Eb2PNetFMNoOEetNAsuSraggzZ83sjdm9L5ImgJCDTPP1zMXj6UeAQ== X-Received: by 2002:a05:6e02:1b04:: with SMTP id i4mr3081501ilv.270.1644661535490; Sat, 12 Feb 2022 02:25:35 -0800 (PST) Received: from localhost.localdomain (node-17-161.flex.volo.net. [76.191.17.161]) by smtp.googlemail.com with ESMTPSA id e17sm13955707ilm.67.2022.02.12.02.25.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Feb 2022 02:25:35 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH v1] x86: Set .text section in memset-vec-unaligned-erms Date: Sat, 12 Feb 2022 04:25:29 -0600 Message-Id: <20220212102529.1380928-1-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Noah Goldstein <goldstein.w.n@gmail.com> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
[v1] x86: Set .text section in memset-vec-unaligned-erms
|
|
Checks
Context | Check | Description |
---|---|---|
dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
dj/TryBot-32bit | success | Build for i686 |
Commit Message
Noah Goldstein
Feb. 12, 2022, 10:25 a.m. UTC
commit 3d9f171bfb5325bd5f427e9fc386453358c6e840 Author: H.J. Lu <hjl.tools@gmail.com> Date: Mon Feb 7 05:55:15 2022 -0800 x86-64: Optimize bzero Remove setting the .text section for the code. This commit adds that back. --- sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 + 1 file changed, 1 insertion(+)
Comments
On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote: > > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840 > Author: H.J. Lu <hjl.tools@gmail.com> > Date: Mon Feb 7 05:55:15 2022 -0800 > > x86-64: Optimize bzero > > Remove setting the .text section for the code. This commit > adds that back. > --- > sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > index 7c94fcdae1..785fee1d57 100644 > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > @@ -114,6 +114,7 @@ > # error SECTION is not defined! > #endif > > + .section SECTION(.text), "ax", @progbits > #if IS_IN (libc) > # if defined SHARED > ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned)) > -- > 2.25.1 > LGTM. Reviewed-by: H.J. Lu <hjl.tools@gmail.com> Thanks.
On Sat, Feb 12, 2022 at 9:47 AM H.J. Lu <hjl.tools@gmail.com> wrote: > > On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote: > > > > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840 > > Author: H.J. Lu <hjl.tools@gmail.com> > > Date: Mon Feb 7 05:55:15 2022 -0800 > > > > x86-64: Optimize bzero > > > > Remove setting the .text section for the code. This commit > > adds that back. > > --- > > sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > index 7c94fcdae1..785fee1d57 100644 > > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > @@ -114,6 +114,7 @@ > > # error SECTION is not defined! > > #endif > > > > + .section SECTION(.text), "ax", @progbits > > #if IS_IN (libc) > > # if defined SHARED > > ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned)) > > -- > > 2.25.1 > > > > LGTM. > > Reviewed-by: H.J. Lu <hjl.tools@gmail.com> > > Thanks. > Thanks pushed. > -- > H.J.
On Sat, Feb 12, 2022 at 1:44 PM Noah Goldstein via Libc-alpha <libc-alpha@sourceware.org> wrote: > > On Sat, Feb 12, 2022 at 9:47 AM H.J. Lu <hjl.tools@gmail.com> wrote: > > > > On Sat, Feb 12, 2022 at 2:25 AM Noah Goldstein <goldstein.w.n@gmail.com> wrote: > > > > > > commit 3d9f171bfb5325bd5f427e9fc386453358c6e840 > > > Author: H.J. Lu <hjl.tools@gmail.com> > > > Date: Mon Feb 7 05:55:15 2022 -0800 > > > > > > x86-64: Optimize bzero > > > > > > Remove setting the .text section for the code. This commit > > > adds that back. > > > --- > > > sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > > index 7c94fcdae1..785fee1d57 100644 > > > --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > > +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S > > > @@ -114,6 +114,7 @@ > > > # error SECTION is not defined! > > > #endif > > > > > > + .section SECTION(.text), "ax", @progbits > > > #if IS_IN (libc) > > > # if defined SHARED > > > ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned)) > > > -- > > > 2.25.1 > > > > > > > LGTM. > > > > Reviewed-by: H.J. Lu <hjl.tools@gmail.com> > > > > Thanks. > > > > Thanks pushed. > > -- > > H.J. I would like to backport this patch to release branches. Any comments or objections? --Sunil
diff --git a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S index 7c94fcdae1..785fee1d57 100644 --- a/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S +++ b/sysdeps/x86_64/multiarch/memset-vec-unaligned-erms.S @@ -114,6 +114,7 @@ # error SECTION is not defined! #endif + .section SECTION(.text), "ax", @progbits #if IS_IN (libc) # if defined SHARED ENTRY_CHK (WMEMSET_CHK_SYMBOL (__wmemset_chk, unaligned))