diff mbox series

[2/2] x86-64: Fix strcmp-evex.S

Message ID 20220204191200.73982-2-hjl.tools@gmail.com
State Committed
Commit 0e0199a9e02ebe42e2b36958964d63f03573c382
Headers
Series [1/2] x86-64: Fix strcmp-avx2.S |

Checks

Context Check Description
dj/TryBot-apply_patch fail Patch failed to apply to master at the time it was sent
dj/TryBot-32bit fail Patch series failed to apply

Commit Message

H.J. Lu Feb. 4, 2022, 7:12 p.m. UTC 
  Change "movl %edx, %rdx" to "movl %edx, %edx" in:

commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9
Author: Noah Goldstein <goldstein.w.n@gmail.com>
Date:   Mon Jan 10 15:35:39 2022 -0600

    x86: Optimize strcmp-evex.S
---
 sysdeps/x86_64/multiarch/strcmp-evex.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sunil Pandey May 4, 2022, 5:44 a.m. UTC | #1 
On Fri, Feb 4, 2022 at 11:12 AM H.J. Lu via Libc-alpha
<libc-alpha@sourceware.org> wrote:
>
> Change "movl %edx, %rdx" to "movl %edx, %edx" in:
>
> commit 8418eb3ff4b781d31c4ed5dc6c0bd7356bc45db9
> Author: Noah Goldstein <goldstein.w.n@gmail.com>
> Date:   Mon Jan 10 15:35:39 2022 -0600
>
>     x86: Optimize strcmp-evex.S
> ---
>  sysdeps/x86_64/multiarch/strcmp-evex.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
> index e5070f3d53..6f42e3155a 100644
> --- a/sysdeps/x86_64/multiarch/strcmp-evex.S
> +++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
> @@ -116,7 +116,7 @@ ENTRY(STRCMP)
>  # ifdef USE_AS_STRNCMP
>  #  ifdef __ILP32__
>         /* Clear the upper 32 bits.  */
> -       movl    %edx, %rdx
> +       movl    %edx, %edx
>  #  endif
>         cmp     $1, %RDX_LP
>         /* Signed comparison intentional. We use this branch to also
> --
> 2.34.1
>

I would like to backport this patch to release branches.
Any comments or objections?

--Sunil
diff mbox series

Patch

diff --git a/sysdeps/x86_64/multiarch/strcmp-evex.S b/sysdeps/x86_64/multiarch/strcmp-evex.S
index e5070f3d53..6f42e3155a 100644
--- a/sysdeps/x86_64/multiarch/strcmp-evex.S
+++ b/sysdeps/x86_64/multiarch/strcmp-evex.S
@@ -116,7 +116,7 @@  ENTRY(STRCMP)
 # ifdef USE_AS_STRNCMP
 #  ifdef __ILP32__
 	/* Clear the upper 32 bits.  */
-	movl	%edx, %rdx
+	movl	%edx, %edx
 #  endif
 	cmp	$1, %RDX_LP
 	/* Signed comparison intentional. We use this branch to also