Message ID | 20211221221329.347210-1-eggert@cs.ucla.edu |
---|---|
State | Committed |
Commit | 7999b8a3aa76eae4f75b76fd6797e832274b8114 |
Headers |
Return-Path: <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BCB8B3858000 for <patchwork@sourceware.org>; Tue, 21 Dec 2021 22:14:10 +0000 (GMT) X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92]) by sourceware.org (Postfix) with ESMTPS id A7F163858C60 for <libc-alpha@sourceware.org>; Tue, 21 Dec 2021 22:13:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A7F163858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=cs.ucla.edu Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=cs.ucla.edu Received: from [2001:470:142:3::e] (port=40362 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eggert@cs.ucla.edu>) id 1mznOQ-0006T0-4m for libc-alpha@sourceware.org; Tue, 21 Dec 2021 17:13:58 -0500 Received: from eggs.gnu.org ([209.51.188.92]:53902) by fencepost.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eggert@cs.ucla.edu>) id 1mznOF-0007xO-RE for libc-alpha@gnu.org; Tue, 21 Dec 2021 17:13:51 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:54084) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eggert@cs.ucla.edu>) id 1mznOD-0006RC-TD for libc-alpha@gnu.org; Tue, 21 Dec 2021 17:13:47 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8D24F16011F for <libc-alpha@gnu.org>; Tue, 21 Dec 2021 14:13:43 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id J8eie6qtI6Dn; Tue, 21 Dec 2021 14:13:42 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E0D7216011C; Tue, 21 Dec 2021 14:13:42 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id CVwjTsalMvvl; Tue, 21 Dec 2021 14:13:42 -0800 (PST) Received: from day.example.com (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id B58E1160112; Tue, 21 Dec 2021 14:13:42 -0800 (PST) From: Paul Eggert <eggert@cs.ucla.edu> To: libc-alpha@gnu.org Subject: [PATCH] cdefs.h: fix "__clang_major" typo Date: Tue, 21 Dec 2021 14:13:29 -0800 Message-Id: <20211221221329.347210-1-eggert@cs.ucla.edu> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=131.179.128.68; envelope-from=eggert@cs.ucla.edu; helo=zimbra.cs.ucla.edu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-16.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces+patchwork=sourceware.org@sourceware.org> |
Series |
cdefs.h: fix "__clang_major" typo
|
|
Checks
Context | Check | Description |
---|---|---|
dj/TryBot-apply_patch | success | Patch applied to master at the time it was sent |
dj/TryBot-32bit | success | Build for i686 |
Commit Message
Paul Eggert
Dec. 21, 2021, 10:13 p.m. UTC
* misc/sys/cdefs.h: Fix misspelling of "__clang_major__". --- misc/sys/cdefs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 21/12/2021 19:13, Paul Eggert wrote: > * misc/sys/cdefs.h: Fix misspelling of "__clang_major__". LGTM, thanks. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > --- > misc/sys/cdefs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h > index a05b538579..f6e1db1954 100644 > --- a/misc/sys/cdefs.h > +++ b/misc/sys/cdefs.h > @@ -81,7 +81,7 @@ > # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct > # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct > # else > -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) > +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) > # if __cplusplus >= 201103L > # define __THROW noexcept (true) > # else
On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote: > > > On 21/12/2021 19:13, Paul Eggert wrote: >> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__". > > LGTM, thanks. > > Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> Ahemerval, In reviewing old patches to improve our SLI for patch review I noticed that this patch is reviewed and approved but not committed. The patch still looks correct to me. Would you mind committing this on behalf of Paul please? >> --- >> misc/sys/cdefs.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h >> index a05b538579..f6e1db1954 100644 >> --- a/misc/sys/cdefs.h >> +++ b/misc/sys/cdefs.h >> @@ -81,7 +81,7 @@ >> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct >> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct >> # else >> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) >> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) >> # if __cplusplus >= 201103L >> # define __THROW noexcept (true) >> # else >
On 23/02/23 15:30, Carlos O'Donell wrote: > On 12/30/21 06:20, Adhemerval Zanella via Libc-alpha wrote: >> >> >> On 21/12/2021 19:13, Paul Eggert wrote: >>> * misc/sys/cdefs.h: Fix misspelling of "__clang_major__". >> >> LGTM, thanks. >> >> Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org> > > Ahemerval, > > In reviewing old patches to improve our SLI for patch review I noticed that > this patch is reviewed and approved but not committed. The patch still looks > correct to me. > > Would you mind committing this on behalf of Paul please? > > Done. >>> --- >>> misc/sys/cdefs.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h >>> index a05b538579..f6e1db1954 100644 >>> --- a/misc/sys/cdefs.h >>> +++ b/misc/sys/cdefs.h >>> @@ -81,7 +81,7 @@ >>> # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct >>> # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct >>> # else >>> -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) >>> +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) >>> # if __cplusplus >= 201103L >>> # define __THROW noexcept (true) >>> # else >> >
diff --git a/misc/sys/cdefs.h b/misc/sys/cdefs.h index a05b538579..f6e1db1954 100644 --- a/misc/sys/cdefs.h +++ b/misc/sys/cdefs.h @@ -81,7 +81,7 @@ # define __NTH(fct) __attribute__ ((__nothrow__ __LEAF)) fct # define __NTHNL(fct) __attribute__ ((__nothrow__)) fct # else -# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major >= 4) +# if defined __cplusplus && (__GNUC_PREREQ (2,8) || __clang_major__ >= 4) # if __cplusplus >= 201103L # define __THROW noexcept (true) # else