From patchwork Thu Dec 9 20:35:56 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Khem Raj X-Patchwork-Id: 48726 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0D826385841F for ; Thu, 9 Dec 2021 20:36:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D826385841F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639082193; bh=qPELKOCGIfJk0gcGknHK6LqWpKku16jTu3WGfC6KOco=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=PjSAo066T/AKgfnAa/uSsj2gggbqKLcJstjq2f39undbk2yDzOviwnrWjO+dfW585 hBMnfl25AJ07CK6KSmWqpC08QtaOmUG80D1RpfL11/1j4OubrUQerrvT/sfYcPE2W8 t3hVpOxNVlf850J+GHoztWuhIKgmouHIbnOqnU0A= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pf1-x429.google.com (mail-pf1-x429.google.com [IPv6:2607:f8b0:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 2DBE43858C27 for ; Thu, 9 Dec 2021 20:36:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2DBE43858C27 Received: by mail-pf1-x429.google.com with SMTP id n26so6497671pff.3 for ; Thu, 09 Dec 2021 12:36:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qPELKOCGIfJk0gcGknHK6LqWpKku16jTu3WGfC6KOco=; b=wvjlX7k0kn0sxZNsmwwiqdDZoyeuTVDifcQuT3MKf9ZVZN2yEaTvEQQHWbz/bGJXhb 6nDvgMFUY7WRPBgkyVKC0ravIMNX9kCCcgw5wqWhyvjVFky2KukMN2m2a0Dk/++IMCuD jobT/ikQeBYs1udUKvOgIBvpi8p8W8MbTq3m1/D3FlvpL2ggr7lEkk/6CB19pPJaYRlN loM+nI07/qZfbHvpjQsj3ss7tdxDMskpj9rmldFdwwD/5rmuAgkDjgCc8Smn+/4wDEqY epkIbNdqACkfoqCchAhYkIa1lXqgCpAsVwQ19cTwjl5w/SuJDHxM6uAbypDifu6ghs3y LpUQ== X-Gm-Message-State: AOAM530vVHyQfxx0FOzNh2iatlYdv1IOEJIUcWDcaIxfAB68JLQ5e1k8 O9jtvx5gAsPY3v49PCMgmv58Ia2PmC5YFg== X-Google-Smtp-Source: ABdhPJzASEDM6T4mb7UD3bjex1s8MGgysUxikOOdGtE5zp914uRK7W2I/VG7UiSO4NR7PjAR55UJHA== X-Received: by 2002:a63:1950:: with SMTP id 16mr37374068pgz.422.1639082169982; Thu, 09 Dec 2021 12:36:09 -0800 (PST) Received: from apollo.hsd1.ca.comcast.net ([2601:646:9200:a0f0::ce68]) by smtp.gmail.com with ESMTPSA id h5sm582598pfc.113.2021.12.09.12.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 12:36:09 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH v2 1/2] Replace echo with printf builtin in nscd init script Date: Thu, 9 Dec 2021 12:35:56 -0800 Message-Id: <20211209203557.1318333-1-raj.khem@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Khem Raj via Libc-alpha From: Khem Raj Reply-To: Khem Raj Cc: Ross Burton Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The nscd init script calls for #! /bin/bash interpreter since it uses bash specific extentions namely (translated strings) and echo -n command, replace echo with printf and switch the shell interpreter to #!/bin/sh. Signed-off-by: Ross Burton Signed-off-by: Khem Raj --- v2: Replace echo with printf Try to improve commit msg nscd/nscd.init | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/nscd/nscd.init b/nscd/nscd.init index a882da7d8b..857b541381 100644 --- a/nscd/nscd.init +++ b/nscd/nscd.init @@ -1,4 +1,4 @@ -#!/bin/bash +#!/bin/sh # # nscd: Starts the Name Switch Cache Daemon # @@ -49,16 +49,16 @@ prog=nscd start () { [ -d /var/run/nscd ] || mkdir /var/run/nscd [ -d /var/db/nscd ] || mkdir /var/db/nscd - echo -n $"Starting $prog: " + printf "Starting $prog: " daemon /usr/sbin/nscd RETVAL=$? - echo + printf "\n" [ $RETVAL -eq 0 ] && touch /var/lock/subsys/nscd return $RETVAL } stop () { - echo -n $"Stopping $prog: " + printf "Stopping $prog: " /usr/sbin/nscd -K RETVAL=$? if [ $RETVAL -eq 0 ]; then @@ -67,11 +67,11 @@ stop () { # a non-privileged user rm -f /var/run/nscd/nscd.pid rm -f /var/run/nscd/socket - success $"$prog shutdown" + success "$prog shutdown" else - failure $"$prog shutdown" + failure "$prog shutdown" fi - echo + printf "\n" return $RETVAL } @@ -103,13 +103,13 @@ case "$1" in RETVAL=$? ;; force-reload | reload) - echo -n $"Reloading $prog: " + printf "Reloading $prog: " killproc /usr/sbin/nscd -HUP RETVAL=$? - echo + printf "\n" ;; *) - echo $"Usage: $0 {start|stop|status|restart|reload|condrestart}" + printf "Usage: $0 {start|stop|status|restart|reload|condrestart}\n" RETVAL=1 ;; esac