From patchwork Mon Nov 1 12:50:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 46900 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 778E93858033 for ; Mon, 1 Nov 2021 12:51:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 778E93858033 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1635771070; bh=zfvqPDxyCnkV+SU/WVjQlb0fsPQ69GwAZclcGLf6RmA=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=JkLUxGWIsAFFlmpC+KzRAHaIxSMMpAcI7UFsLspKjUoitsiI/C7vKukmlVVMEoqDx eWucvw51odLAgV56XYnfpHfk+A2pgIiA3SKJkfZBgahiv6S4o6v47ucEtr1pIIemQp pJbWNCjqgrkD9aHTeq3JxqwXwzMrXZbi0pXccgvs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by sourceware.org (Postfix) with ESMTPS id 62B233858432 for ; Mon, 1 Nov 2021 12:50:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 62B233858432 Received: by mail-qt1-x835.google.com with SMTP id v29so14321496qtc.10 for ; Mon, 01 Nov 2021 05:50:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zfvqPDxyCnkV+SU/WVjQlb0fsPQ69GwAZclcGLf6RmA=; b=j5uFof1+7VdeWiibZ0/tDjWdTwfTTnAmPYMSmfxNm3ysTKRxSuUtW/MMgJSY4QR9G7 8aan7P5WVMcVPlXmHAIThUZhClON84bmJQwUulka/C4EAEQL2sCuUWNrRpf8a7KUub3G 1ZBFOOZOLBDVLw/FPlH380dn1GZT6xB8QyXMJ2ZlL8uCIrvyj/JZUWDPwyGHm4oxDs17 kp1Hv90Nbwp0V83s6arlXWco+pwdFSe8ZU/R2b63bm3ivLRzsoZKB3aNE6E+PlV9H6r9 A7Ft61LwZ5zQVmRcXXJzXaJYvFFg6c1GaMsHIRKhkvso8y3apxrtrIljmEGT0DrAh1sk meeQ== X-Gm-Message-State: AOAM5303Ja3NV3aRIVbxjTg9eaJ2xT8Cn1KikLTfLc9yVrCvyG4f8g5V jHd58M7lyucIT1tqgxS6wxk9OeC+44Kl6Q== X-Google-Smtp-Source: ABdhPJz2EMpI07kQVnRngOciZYCswv4tVagXQWPfmjiVgdT66mimr1vN9Z1Y72krdl4JoQ3cCh4oAQ== X-Received: by 2002:ac8:7f8f:: with SMTP id z15mr2707425qtj.32.1635771007832; Mon, 01 Nov 2021 05:50:07 -0700 (PDT) Received: from birita.. ([2804:431:c7cb:b64f:7c54:165f:8728:a193]) by smtp.gmail.com with ESMTPSA id g1sm4958193qtb.7.2021.11.01.05.50.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Nov 2021 05:50:07 -0700 (PDT) To: libc-alpha@sourceware.org, =?utf-8?b?RsSBbmctcnXDrCBTw7JuZw==?= Subject: [PATCH 1/3] arm: Use internal symbol for _dl_argv on _dl_start_user Date: Mon, 1 Nov 2021 09:50:01 -0300 Message-Id: <20211101125003.500945-2-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211101125003.500945-1-adhemerval.zanella@linaro.org> References: <20211101125003.500945-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Adhemerval Zanella via Libc-alpha From: Adhemerval Zanella Reply-To: Adhemerval Zanella Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The lld does not support R_ARM_GOTOFF32 to preemptible symbol (_dl_argv has global visibility). Use the internal alias instead (one option would to use HIDDEN_JUMPTARGET, bu the macro is not defined for !__ASSEMBLER__ and I made this patch arm-specific to avoid require to check extensivelly on other architecture it this might break something). Checked on arm-linux-gnueabihf. Reviewed-by: Fangrui Song --- sysdeps/arm/dl-machine.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/arm/dl-machine.h b/sysdeps/arm/dl-machine.h index c758bba169..4ecdde4355 100644 --- a/sysdeps/arm/dl-machine.h +++ b/sysdeps/arm/dl-machine.h @@ -202,7 +202,7 @@ _dl_start_user:\n\ .L_FINI_PROC:\n\ .word _dl_fini(GOTOFF)\n\ .L_ARGV:\n\ - .word _dl_argv(GOTOFF)\n\ + .word __GI__dl_argv(GOTOFF)\n\ .L_LOADED:\n\ .word _rtld_local(GOTOFF)\n\ .previous\n\