diff mbox series

[v2,19/19] nptl: Remove INVALID_TD_P

Message ID 20210823195047.543237-20-adhemerval.zanella@linaro.org
State Superseded
Headers
Series Fix various NPTL synchronization issues |

Checks

Context Check Description
dj/TryBot-apply_patch success Patch applied to master at the time it was sent
dj/TryBot-32bit success Build for i686

Commit Message

Adhemerval Zanella Aug. 23, 2021, 7:50 p.m. UTC 
  It is not used anymore.
---
 sysdeps/nptl/pthreadP.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

Florian Weimer Aug. 26, 2021, 9:30 a.m. UTC | #1 
* Adhemerval Zanella:

> It is not used anymore.
> ---
>  sysdeps/nptl/pthreadP.h | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/sysdeps/nptl/pthreadP.h b/sysdeps/nptl/pthreadP.h
> index d366d691cd..67a9887da3 100644
> --- a/sysdeps/nptl/pthreadP.h
> +++ b/sysdeps/nptl/pthreadP.h
> @@ -239,11 +239,6 @@ libc_hidden_proto (__pthread_tpp_change_priority)
>  extern int __pthread_current_priority (void);
>  libc_hidden_proto (__pthread_current_priority)
>  
> -/* This will not catch all invalid descriptors but is better than
> -   nothing.  And if the test triggers the thread descriptor is
> -   guaranteed to be invalid.  */
> -#define INVALID_TD_P(pd) __builtin_expect ((pd)->tid <= 0, 0)
> -
>  extern void __pthread_unwind (__pthread_unwind_buf_t *__buf)
>       __cleanup_fct_attribute __attribute ((__noreturn__))
>  #if !defined SHARED && !IS_IN (libpthread)

Looks okay to me.

Reviewed-by: Florian Weimer <fweimer@redhat.com>

Thanks,
Florian
diff mbox series

Patch

diff --git a/sysdeps/nptl/pthreadP.h b/sysdeps/nptl/pthreadP.h
index d366d691cd..67a9887da3 100644
--- a/sysdeps/nptl/pthreadP.h
+++ b/sysdeps/nptl/pthreadP.h
@@ -239,11 +239,6 @@  libc_hidden_proto (__pthread_tpp_change_priority)
 extern int __pthread_current_priority (void);
 libc_hidden_proto (__pthread_current_priority)
 
-/* This will not catch all invalid descriptors but is better than
-   nothing.  And if the test triggers the thread descriptor is
-   guaranteed to be invalid.  */
-#define INVALID_TD_P(pd) __builtin_expect ((pd)->tid <= 0, 0)
-
 extern void __pthread_unwind (__pthread_unwind_buf_t *__buf)
      __cleanup_fct_attribute __attribute ((__noreturn__))
 #if !defined SHARED && !IS_IN (libpthread)