From patchwork Thu Jul 8 20:13:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 44274 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EEC073AA9415 for ; Thu, 8 Jul 2021 20:14:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EEC073AA9415 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625775283; bh=1fUuVh3ivfijnJMXB2hcKEBqpRRek0mbqPlxpnw87hc=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=K9yTIeT5uMMfA5DfQJv/onijSa8q5xTHfc2aUwf6v0T/JT9CtzgHHGkA6pTzZrK4C W6Y1Bz/WTyI+3Ln8gJJnpiJTQMasTCHo8Fe0brmdRTF6ytnZQI1K9KE6XLw9QqtQJr 4dzXEgDICTVyshLy9xQ6PgLomqkzzZyRFkuOSS8o= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) by sourceware.org (Postfix) with ESMTPS id 8A8EB3AA991F for ; Thu, 8 Jul 2021 20:14:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8A8EB3AA991F Received: by mail-qk1-x72b.google.com with SMTP id 77so5237662qkk.11 for ; Thu, 08 Jul 2021 13:14:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1fUuVh3ivfijnJMXB2hcKEBqpRRek0mbqPlxpnw87hc=; b=uGMlsm7aXhJJtRo9ahhn/cA5pz++dh9xjM0haobXcauMY86JeykeZ9HGDyKI/nnPWM V4vEO1+1ONgOPbRMygCNXtCMv8ieEXdPjxzvrjdjPXeg5ydFlzNhoXJUcNhoQEak4rEV fUi835M4oO6DSc3Vo1w1YWoqFBjiFJY0Vu/Wb8R5FeCts/sSSfSSbtzxZfsH8SvWexMl rp9aOzvFZ0esfE3Z21jepcMr3WEVO7aJqIp13V1K1e8lUxc91iO+zJBDKCje+JzoWrVP e8WyVKnHOrMER6j50Ng8jKfEMLtw1GicMOeILCS7dPqBaS8oebOlKPHXyxMvD0UoMffA /QWw== X-Gm-Message-State: AOAM530N2SXiKPTVzow5oZsa6p2dbYbBfW+Xd40gDjZqx5ZQt/GLicCw WoYt+bX3OYXNAXTKDEz3yXyt5QoGHKc= X-Google-Smtp-Source: ABdhPJytXZ1XO968aWHgTrHzgnPjmNM7UqOpohEI0/n5dOvQ84ETEfXIW0aXjoxx6Sqhq7rDRe8OKw== X-Received: by 2002:a05:620a:11b4:: with SMTP id c20mr16195105qkk.83.1625775242992; Thu, 08 Jul 2021 13:14:02 -0700 (PDT) Received: from localhost.localdomain (pool-173-75-15-191.pitbpa.fios.verizon.net. [173.75.15.191]) by smtp.googlemail.com with ESMTPSA id 11sm1462574qkp.115.2021.07.08.13.14.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Jul 2021 13:14:02 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v2 2/2] x86: Remove wcsnlen-sse4_1 from wcslen ifunc-impl-list [BZ #28064] Date: Thu, 8 Jul 2021 16:13:19 -0400 Message-Id: <20210708201318.1222367-2-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210708201318.1222367-1-goldstein.w.n@gmail.com> References: <20210708081308.640036-1-goldstein.w.n@gmail.com> <20210708201318.1222367-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Noah Goldstein via Libc-alpha From: Noah Goldstein Reply-To: Noah Goldstein Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" The following commit commit 6f573a27b6c8b4236445810a44660612323f5a73 Author: Noah Goldstein Date: Wed Jun 23 01:19:34 2021 -0400 x86-64: Add wcslen optimize for sse4.1 Added wcsnlen-sse4.1 to the wcslen ifunc implementation list and did not add wcslen-sse4.1 to wcslen ifunc implementation list. This commit fixes that by removing wcsnlen-sse4.1 from the wcslen ifunc implementation list and adding wcslen-sse4.1 to the ifunc implementation list. Testing: test-wcslen.c, test-rsi-wcslen.c, and test-rsi-strlen.c are passing as well as all other tests in wcsmbs and string. Signed-off-by: Noah Goldstein Reviewed-by: H.J. Lu Reviewed-by: H.J. Lu --- Confirmed test-rsi-wcslen.c failed before this fix. sysdeps/x86_64/multiarch/ifunc-impl-list.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/x86_64/multiarch/ifunc-impl-list.c b/sysdeps/x86_64/multiarch/ifunc-impl-list.c index dbd1ebf298..39ab10613b 100644 --- a/sysdeps/x86_64/multiarch/ifunc-impl-list.c +++ b/sysdeps/x86_64/multiarch/ifunc-impl-list.c @@ -684,9 +684,9 @@ __libc_ifunc_impl_list (const char *name, struct libc_ifunc_impl *array, && CPU_FEATURE_USABLE (AVX512BW) && CPU_FEATURE_USABLE (BMI2)), __wcslen_evex) - IFUNC_IMPL_ADD (array, i, wcsnlen, + IFUNC_IMPL_ADD (array, i, wcslen, CPU_FEATURE_USABLE (SSE4_1), - __wcsnlen_sse4_1) + __wcslen_sse4_1) IFUNC_IMPL_ADD (array, i, wcslen, 1, __wcslen_sse2)) /* Support sysdeps/x86_64/multiarch/wcsnlen.c. */