From patchwork Wed Jun 23 22:28:46 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 43988 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 70CB438930FE for ; Wed, 23 Jun 2021 22:30:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70CB438930FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624487430; bh=ViVTVfCwaioz2oIBHx35X8bsaqAai4/eULtqo9GCe1g=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=t5Bd2edqoB3qtsjUoOuIm8EsF9Hiqj2RPOqnZ61RD0LdWsFs7JYfAi9QUDqvEvuXH adejI3rlE6JXS9mXRQ3/xnNLc7dtn5pIatcY2w7UOmgnRT5FO18FXTKIoq+0is1hXY 4czm9RQpZ22MqBbqN5zrhZ+xiNzOYNNWF07eYkXg= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id EC185394AC37 for ; Wed, 23 Jun 2021 22:28:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org EC185394AC37 Received: by mail-pg1-x52f.google.com with SMTP id e22so2984772pgv.10 for ; Wed, 23 Jun 2021 15:28:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ViVTVfCwaioz2oIBHx35X8bsaqAai4/eULtqo9GCe1g=; b=EabYp8rDEr9aYZQ9FXD5DDdqQELtNTaEDLwSCYHpxEpmEaG4kNyWDGFNjjQ0sqOzp8 tIE0NxuCUTKEWJEVOPa8x7kOh3szPSq2HkrfIGqGPragayiv995/SYM34um9wBjUSL9v S1YHqKptmoFq1FaWeVpX5/ESYseVkqWIi7EwjkPNKBXRVvcRj17o1EqRiV+o+zD6eTfk iWMrDujwLh5YVqKvVj9GIgfWYuy05agvm8zuZo+aeBw0Pk0+g8UzuMYfDYkMz5zL6spN 9bXnjxrQzBS02MSfhxz8YDRKbRusiQfaxX3f6/nvF07sfBukpEPqBXuDABvl3tW/cWzJ RyFA== X-Gm-Message-State: AOAM533jUagHcN8ApUvcT+6OvePWoti7O6E4+OHITPpPFs9Rxpin8+kt rIWYtgjzYCLwUkZhhEU//aU= X-Google-Smtp-Source: ABdhPJybBloMx4HDIat6CubmOAPJ30GK5/VT22pxsPgyBwZj5UAQ2k7yDYWuYycD881lT3hy2NCNsw== X-Received: by 2002:a62:e717:0:b029:301:964e:49f0 with SMTP id s23-20020a62e7170000b0290301964e49f0mr1869444pfh.22.1624487338127; Wed, 23 Jun 2021 15:28:58 -0700 (PDT) Received: from gnu-cfl-2.localdomain ([172.56.39.115]) by smtp.gmail.com with ESMTPSA id m4sm6016681pjv.41.2021.06.23.15.28.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Jun 2021 15:28:57 -0700 (PDT) Received: from gnu-tgl-2.localdomain (gnu-tgl-2 [192.168.1.34]) by gnu-cfl-2.localdomain (Postfix) with ESMTPS id 9C260C05B2; Wed, 23 Jun 2021 15:28:56 -0700 (PDT) Received: from gnu-tgl-2.lan (localhost [IPv6:::1]) by gnu-tgl-2.localdomain (Postfix) with ESMTP id 8907A3002C1; Wed, 23 Jun 2021 15:28:46 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v8 4/4] Use GCC builtins for roundeven functions if desired. Date: Wed, 23 Jun 2021 15:28:46 -0700 Message-Id: <20210623222846.2162301-5-hjl.tools@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210623222846.2162301-1-hjl.tools@gmail.com> References: <20210623222846.2162301-1-hjl.tools@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-3032.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Cc: Shen-Ta Hsieh Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" From: Shen-Ta Hsieh This patch is using the corresponding GCC builtin for roundevenf, roundeven and roundevenl if the USE_FUNCTION_BUILTIN macros are defined to one in math-use-builtins.h. These builtin functions is supported since GCC 10. The code of the generic implementation is not changed. Signed-off-by: Shen-Ta Hsieh Reviewed-by: H.J. Lu --- sysdeps/generic/math-use-builtins-roundeven.h | 4 ++++ sysdeps/generic/math-use-builtins.h | 1 + sysdeps/ieee754/dbl-64/s_roundeven.c | 5 +++++ sysdeps/ieee754/float128/float128_private.h | 2 ++ sysdeps/ieee754/flt-32/s_roundevenf.c | 5 +++++ sysdeps/ieee754/ldbl-128/s_roundevenl.c | 5 +++++ 6 files changed, 22 insertions(+) create mode 100644 sysdeps/generic/math-use-builtins-roundeven.h diff --git a/sysdeps/generic/math-use-builtins-roundeven.h b/sysdeps/generic/math-use-builtins-roundeven.h new file mode 100644 index 0000000000..bd2e84c93f --- /dev/null +++ b/sysdeps/generic/math-use-builtins-roundeven.h @@ -0,0 +1,4 @@ +#define USE_ROUNDEVEN_BUILTIN 0 +#define USE_ROUNDEVENF_BUILTIN 0 +#define USE_ROUNDEVENL_BUILTIN 0 +#define USE_ROUNDEVENF128_BUILTIN 0 diff --git a/sysdeps/generic/math-use-builtins.h b/sysdeps/generic/math-use-builtins.h index cc3e9f2201..19d2d1cf3c 100644 --- a/sysdeps/generic/math-use-builtins.h +++ b/sysdeps/generic/math-use-builtins.h @@ -30,6 +30,7 @@ #include #include #include +#include #include #include #include diff --git a/sysdeps/ieee754/dbl-64/s_roundeven.c b/sysdeps/ieee754/dbl-64/s_roundeven.c index 5deff3bb8a..88c051e9fe 100644 --- a/sysdeps/ieee754/dbl-64/s_roundeven.c +++ b/sysdeps/ieee754/dbl-64/s_roundeven.c @@ -21,6 +21,7 @@ #include #include #include +#include #define BIAS 0x3ff #define MANT_DIG 53 @@ -29,6 +30,9 @@ double __roundeven (double x) { +#if USE_ROUNDEVEN_BUILTIN + return __builtin_roundeven (x); +#else uint64_t ix, ux; EXTRACT_WORDS64 (ix, x); ux = ix & 0x7fffffffffffffffULL; @@ -66,6 +70,7 @@ __roundeven (double x) ix &= 0x8000000000000000ULL; INSERT_WORDS64 (x, ix); return x; +#endif /* ! USE_ROUNDEVEN_BUILTIN */ } #ifndef __roundeven libm_alias_double (__roundeven, roundeven) diff --git a/sysdeps/ieee754/float128/float128_private.h b/sysdeps/ieee754/float128/float128_private.h index 979138851b..b6b6d3d5fd 100644 --- a/sysdeps/ieee754/float128/float128_private.h +++ b/sysdeps/ieee754/float128/float128_private.h @@ -152,6 +152,8 @@ #define USE_TRUNCL_BUILTIN USE_TRUNCF128_BUILTIN #undef USE_ROUNDL_BUILTIN #define USE_ROUNDL_BUILTIN USE_ROUNDF128_BUILTIN +#undef USE_ROUNDEVENL_BUILTIN +#define USE_ROUNDEVENL_BUILTIN USE_ROUNDEVENF128_BUILTIN #undef USE_COPYSIGNL_BUILTIN #define USE_COPYSIGNL_BUILTIN USE_COPYSIGNF128_BUILTIN #undef USE_FMAL_BUILTIN diff --git a/sysdeps/ieee754/flt-32/s_roundevenf.c b/sysdeps/ieee754/flt-32/s_roundevenf.c index 2cc0d7b001..4f568579d8 100644 --- a/sysdeps/ieee754/flt-32/s_roundevenf.c +++ b/sysdeps/ieee754/flt-32/s_roundevenf.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #define BIAS 0x7f @@ -30,6 +31,9 @@ float __roundevenf (float x) { +#if USE_ROUNDEVENF_BUILTIN + return __builtin_roundevenf (x); +#else uint32_t ix, ux; GET_FLOAT_WORD (ix, x); ux = ix & 0x7fffffff; @@ -67,6 +71,7 @@ __roundevenf (float x) ix &= 0x80000000; SET_FLOAT_WORD (x, ix); return x; +#endif /* ! USE_ROUNDEVENF_BUILTIN */ } #ifndef __roundevenf libm_alias_float (__roundeven, roundeven) diff --git a/sysdeps/ieee754/ldbl-128/s_roundevenl.c b/sysdeps/ieee754/ldbl-128/s_roundevenl.c index 7c9c11fad2..afbf13d4f2 100644 --- a/sysdeps/ieee754/ldbl-128/s_roundevenl.c +++ b/sysdeps/ieee754/ldbl-128/s_roundevenl.c @@ -21,6 +21,7 @@ #include #include #include +#include #include #define BIAS 0x3fff @@ -30,6 +31,9 @@ _Float128 __roundevenl (_Float128 x) { +#if USE_ROUNDEVENL_BUILTIN + return __builtin_roundevenl (x); +#else uint64_t hx, lx, uhx; GET_LDOUBLE_WORDS64 (hx, lx, x); uhx = hx & 0x7fffffffffffffffULL; @@ -101,5 +105,6 @@ __roundevenl (_Float128 x) } SET_LDOUBLE_WORDS64 (x, hx, lx); return x; +#endif /* ! USE_ROUNDEVENL_BUILTIN */ } libm_alias_ldouble (__roundeven, roundeven)