From patchwork Mon Jun 7 07:10:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Noah Goldstein X-Patchwork-Id: 43731 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC176383D010 for ; Mon, 7 Jun 2021 07:12:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC176383D010 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623049925; bh=uX6QcQqqbmUv73KYHgrMczk+hOEw9hNdTb59gv14X8E=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=nX/50Oz+1SNEUGkUoSYshNPPZZl2bGrjRy2I7qFSRS7ypKqMsfnS9rZ7b4dIRZ5D3 UucXhgiQg3xAfoW6B5wFUaU4pomERTiaN3DP/7B64zC5K7fqEfST9O7IN9k7yKuCWp zC5HUlUlYe5wZPpJcGllj+iRqd1A4RqgkJXTpA5s= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x82d.google.com (mail-qt1-x82d.google.com [IPv6:2607:f8b0:4864:20::82d]) by sourceware.org (Postfix) with ESMTPS id 361343853818 for ; Mon, 7 Jun 2021 07:11:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 361343853818 Received: by mail-qt1-x82d.google.com with SMTP id m13so11881939qtk.13 for ; Mon, 07 Jun 2021 00:11:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uX6QcQqqbmUv73KYHgrMczk+hOEw9hNdTb59gv14X8E=; b=DMGkjRAPF2zDoEVXQGS7skhPs1rfyUbn/dkVCak/8WzMEvZCpvzAjh0lzzJXH+nvkS 0bLlbpTFasI9GSPRNOEWPAIHxSjREtXdjSMWjT77D35JcYSqVkM9jZHBij8xkBsql1yC 8ltMm35WIrewF8e18cO+YOalMlHFeNJ/HquuyvJ4QFkb01Gd8T7j2m3UAyjz+Gc6ir26 TmDjA5Hnou+RgsKUYsWXqsAPBdLi/wUQ2DS7db8QGpTkcWhO/EeYulLnsNTGbOGYH1/C 1zxel1F4HfeGtgk7/ANo0vZRtiJv7rCdOXOV/UUOxY33MQ/JaRZTQCIlIPMIjnYxzIHI uxrw== X-Gm-Message-State: AOAM532zwbRFVC7LMmIebA3CA2SCJuzbZvNwh8CP5o8ilpo1dgMwFblk Flcm9FGN3evdGQHp1JvBwpPl2SDcwcs= X-Google-Smtp-Source: ABdhPJyQG8wRx4mHxtZFaolt9TPnRo9XX99lfCUaE2I4QM8Y29YlFgs+BymbrBUXogtJ4fy5FKwTJQ== X-Received: by 2002:a05:622a:309:: with SMTP id q9mr14959511qtw.320.1623049904688; Mon, 07 Jun 2021 00:11:44 -0700 (PDT) Received: from localhost.localdomain (pool-71-245-178-39.pitbpa.fios.verizon.net. [71.245.178.39]) by smtp.googlemail.com with ESMTPSA id 97sm8173094qte.20.2021.06.07.00.11.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jun 2021 00:11:44 -0700 (PDT) To: libc-alpha@sourceware.org Subject: [PATCH v1 2/3] String: test-memset.c strenthen test coverage Date: Mon, 7 Jun 2021 03:10:25 -0400 Message-Id: <20210607071025.449866-2-goldstein.w.n@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210607071025.449866-1-goldstein.w.n@gmail.com> References: <20210607071025.449866-1-goldstein.w.n@gmail.com> MIME-Version: 1.0 X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Noah Goldstein via Libc-alpha From: Noah Goldstein Reply-To: Noah Goldstein Errors-To: libc-alpha-bounces+patchwork=sourceware.org@sourceware.org Sender: "Libc-alpha" This commit adds some additional tests cases that seemed lacking. Signed-off-by: Noah Goldstein --- string/test-memset.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/string/test-memset.c b/string/test-memset.c index 82bfcd6ad4..473bf1d1f5 100644 --- a/string/test-memset.c +++ b/string/test-memset.c @@ -101,7 +101,7 @@ inhibit_loop_to_libcall SIMPLE_MEMSET (CHAR *s, int c, size_t n) { CHAR *r = s, *end = s + n; - while (r < end) + while (r != end) *r++ = c; return s; } @@ -237,7 +237,7 @@ do_random_tests (void) int test_main (void) { - size_t i; + size_t i, j; int c = 0; test_init (); @@ -252,15 +252,29 @@ test_main (void) #endif { for (i = 0; i < 18; ++i) - do_test (0, c, 1 << i); - for (i = 1; i < 64; ++i) + { + do_test (0, c, 1 << i); + do_test (i, c, 1 << i); + do_test (0, c, (1 << i) + 1); + do_test (i, c, (1 << i) + 1); + do_test (0, c, (1 << i) - 1); + do_test (i, c, (1 << i) - 1); + } + for (i = 1; i < 128; ++i) { - do_test (i, c, i); - do_test (4096 - i, c, i); - do_test (4095, c, i); + for (j = i; j <= 2500; j += 15) + { + do_test (i, c, j); + do_test (4096 - i, c, j); + do_test (4095, c, j); + } if (i & (i - 1)) do_test (0, c, i); } + do_test (0, c, 257); + do_test (0, c, 383); + do_test (0, c, 384); + do_test (0, c, 385); do_test (1, c, 14); do_test (3, c, 1024); do_test (4, c, 64);