From patchwork Tue Jun 1 09:46:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Szabolcs Nagy X-Patchwork-Id: 43645 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 783DD3947C3E; Tue, 1 Jun 2021 09:47:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 783DD3947C3E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1622540848; bh=f27PvHPTBJny+1r+4XlOy4ULooOFixRJZLKudkHFh2w=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=CnJfH6bdqbVeqF6W2MRW3g7s1++MWNfpr2OdOgC6mlwZ3qWYmu3QuLsHqS5nAxhyU dpCVtecQHqxR67nGEx+x8TpSJnyYy84FBJ/764t62094+utgcu91dYxG7mHFjI1lB/ dZTHw4kmYurkiV5qry8T9O/hU43g32mCnfyNYfbA= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2089.outbound.protection.outlook.com [40.107.22.89]) by sourceware.org (Postfix) with ESMTPS id 36CAB385802E for ; Tue, 1 Jun 2021 09:47:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 36CAB385802E Received: from AS8PR04CA0159.eurprd04.prod.outlook.com (2603:10a6:20b:331::14) by AM0PR08MB5138.eurprd08.prod.outlook.com (2603:10a6:208:15a::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20; Tue, 1 Jun 2021 09:47:22 +0000 Received: from AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:331:cafe::e5) by AS8PR04CA0159.outlook.office365.com (2603:10a6:20b:331::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Tue, 1 Jun 2021 09:47:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; sourceware.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;sourceware.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM5EUR03FT047.mail.protection.outlook.com (10.152.16.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4150.30 via Frontend Transport; Tue, 1 Jun 2021 09:47:22 +0000 Received: ("Tessian outbound f02dc08cb398:v93"); Tue, 01 Jun 2021 09:47:22 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: f32e4cf178ea33a3 X-CR-MTA-TID: 64aa7808 Received: from b97b215d1c3a.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id A37C5CF8-2BB7-4909-AAED-E78B904B14C5.1; Tue, 01 Jun 2021 09:47:07 +0000 Received: from FRA01-MR2-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b97b215d1c3a.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 01 Jun 2021 09:47:07 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L/jqd2VfCWxEZ7flelTGfWCI0lNUqZkbyWjpu2OZJdin7dyfCpsQuxrXdOke6WtNGDLCbKoFkA7GfVIPpwwkoA87AhhT9I8SCCBWwfrNLjVWWgdyYkA6Ll7JlbcrNE18vaVS30lWPFi4JYkwR1gtmLnWkHnrgdXZVFzPKVlgcK/tFYvt+sL5uMBUAk7YL/gc2UkzSrizcCaws7jo+WFpZlWs8InlBrw0SvW3ImWvSzep05QkoaVtNmug77Vhm2LtyLF3tH+gASsD9vRts4ZeWL/zJ7zsKEkYWwx8u5eFnWWPNrkLWNhIfjrY/UUyN/LJRAVzWJlscC9FZYILBzLy3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=f27PvHPTBJny+1r+4XlOy4ULooOFixRJZLKudkHFh2w=; b=Qp/4BncKWi83iJqaQ+losjLNh9JuY8KIZhzYjr0iDDyWbZE1D45HVK+48+3ORNpijKopIzUL5sovWlck746+9VMVUL7BhmVrnAHCLlapIROyN9yT+K5kH/QhNPI/dm0GHzZW4tjmzpBlM0MKB8yR3/0VdjkM1bMjoV2Km5YfgTVgcVdlAfrbOYhku44sevIal9SPxKm8JkvQr/WkGqfdAx0BRS8H+kGfH3lna4V2NPhXJ/6nuG/yt018kHDz5Z1KFJTpVLH9V24aTmlFjUEH+s48YZXhMr7Ij6m3YQiuXDFpGPppgqBXte7RM7idY42cteKFcztdGyz873mt8rJMJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: sourceware.org; dkim=none (message not signed) header.d=none;sourceware.org; dmarc=none action=none header.from=arm.com; Received: from PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) by PR2PR08MB4650.eurprd08.prod.outlook.com (2603:10a6:101:19::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.22; Tue, 1 Jun 2021 09:46:58 +0000 Received: from PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b]) by PA4PR08MB6320.eurprd08.prod.outlook.com ([fe80::c99f:671d:bb2c:f20b%7]) with mapi id 15.20.4173.030; Tue, 1 Jun 2021 09:46:58 +0000 To: libc-alpha@sourceware.org Subject: [COMMITTED] aarch64: align stack in clone [BZ #27939] Date: Tue, 1 Jun 2021 10:46:47 +0100 Message-Id: <20210601094647.27238-1-szabolcs.nagy@arm.com> X-Mailer: git-send-email 2.17.1 X-Originating-IP: [217.140.106.55] X-ClientProxiedBy: SA0PR11CA0176.namprd11.prod.outlook.com (2603:10b6:806:1bb::31) To PA4PR08MB6320.eurprd08.prod.outlook.com (2603:10a6:102:e5::9) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from localhost.localdomain (217.140.106.55) by SA0PR11CA0176.namprd11.prod.outlook.com (2603:10b6:806:1bb::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4173.20 via Frontend Transport; Tue, 1 Jun 2021 09:46:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b4ddb479-26ba-43f8-049a-08d924e2413a X-MS-TrafficTypeDiagnostic: PR2PR08MB4650:|AM0PR08MB5138: X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:2733;OLM:2733; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: vGFQOGE/+xG6jwv4ovL67/nrAR74A4umIGgjWL3G2nP9UT1k5MJ0ROCjTSDjdadJoS5kmUhSwcD9BvaHR9/HGin49j++M181xFdl3vegfYoWnUuv42Acg/+tlmg2zb0MsHNptrgms9KL92EVZoI4viemmyqbdk5UkS0bCc6DXbCnY8jJImkTmrUcckNmkDsJjdM3Tv8ds7S8Q7eKdmsxzDtxq/722+RZVTEMvbrJHl6mX26TVOX3VRHwR9LRjD9+jwYLUR5EgezW59BWy5E+fRVETs36OkaEa8/UwSPSenXahAHN/KpfgOFAQqxM5cFy+wbOH3oi8u57i8AH6whA2k8y1DdWVFMUB8OFdOnx/ICMupdSvdIMbuYDiZuxLsx2rykFUkdoXT+n6JvUEcCBJ2SThLPztjuXDQhcSwrWelfl2tYddsQkZEQoeqd1+e1eSq6oL0jx/J03glzz7E7tB+T+whq1dUeAMcusAkEcDx13AEansF/CoSVbLvATwrsfoEKTQ45uKnaI5J/DgT4/vggqPwegY/Wt3ZjTWYsR6T3feyKbFAplO3wbYLENG6I/iHNvsGo9pLGJ54l5gFMEFnK/3cUioS8kHzAAuDKcO5Hr+naJaGUEsFFGwpbNdzLSuOQRc1RLUzLB0QPOqFJI5sf6Q42jQRFplWZWuQJ9dqkSb0roI7Xcn94ziGbtySiD X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PA4PR08MB6320.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(39860400002)(346002)(366004)(396003)(136003)(478600001)(38350700002)(6512007)(316002)(5660300002)(6666004)(52116002)(6486002)(66556008)(2906002)(66476007)(38100700002)(2616005)(16526019)(186003)(956004)(8936002)(8676002)(26005)(1076003)(6506007)(6916009)(4744005)(66946007)(36756003)(44832011)(86362001)(69590400013); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: yIGq8+YsLw217RHiqrFTpgu/tRDBTisDyJEXIsjP3qkE4Bv49U39JpmDvMfsc3lfJhIsj7prtI/P5zdn5f08ChePMn7OYjc4OdylluvXZxqflGf5GzJvRSzOXGpv5js/WXfLWLgCmfaEB92n/Six5IW+cM3a9CI2bL6aRZH3RvFcXvrLdCYQ2MdQHEY4wA/rXZO4eR9d9/5qMuj4mzJblLmWD6PT7IlHWZ2CwVIAYSfxZ+kXZ7cAW+2KI7Cmd8ye9YHRvRK0uWsHlWkF7+qEt+1jDp0P3mlYliVSa9RKF+zwqfAAjvL+XcdF8DA0rf0osqAnbsTOjy/CZlHjwNV+xzO+j3EGicyihQPuz42VtJQgSyb++a7AQlsrCOPGI+9l+2zVne50hgCyL+DDBNCkQ2avWfGCpY7cEef8gYsc0jSKOMTK7WW2zrcmtCPboAEb51oTjDSV6+nV1RboIawZ2Wo0Clnkkeb7/G5B/nXTDU5+vQCBz/Zm75d7LDfjbLrBYroGWB94WOq6lKiTBqNKkXUp8cMo0zY62oC/Dz5OctbU/V3I3Ua07jXgxZRalY2xWkckYR9vLorvHc33veZL0qd8WLAcFiS7+IUdh65l3mAcIeHsfAFfYN0r7NfAp9wshS3GgN9V2bGGzInC9WC2eg2ugyR9f747XUZeUEbcxd3z0TMy1FmLU/4RhRRd1lLVMO/DGjgZLekl5MRquLnjk+YmxwM5va/AWkowehlbDEB7MSVU383xr7YbQTLQWHuYYtI8pWjy19BAAJWFsvYN/Cxf6OK3v5E3ENsufHxCkI5u++oNb6FSJVe7UHffKhMjnVcmtUHeCNdtUg0B8k9BO7a2tBgixpnwvDjjvQM6/sE5r36XANHHngtvi8UolGODUmEXxnRl7HARBSvVEF20yJtpYkaKFM5bYkSsbf2CtGwd64hydU4rA3NL97n7mCRdB3B+a5ck+OVeqcJ9KnPzrwHFAXzFr7mzl1m0qju+GrOthfg50pddTwCVfF37YXSJ0PiAiX482H/t3T1jMpgJANO3U2a33lHJ89JuZHr9dZ+NLO3Mk6Jtiw0APqfTi38GODylnkTSGprzwWdVxL7CHou6+sTvcHtRNk4sY2VH5cu8lYgmIsM7OTCLoOQOUZVbieeIj0/7rX//s2VU4G0Dymajmx33H+FAyU47O1EUMHa8AR9ojmSGd5A/+Z3W9sJE+E1uNp5dw+aFbSiex78R7wgzocMBsRWC1gG8WRQS+6ZMPxBbmzTF87z1Ls5QNk1A0yJX39WJ9Il0BO8OqVnqwFw1f073TFdVcuLjJfmwG/+Drx6VXb+xNOmK5oAadBEM X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR2PR08MB4650 Original-Authentication-Results: sourceware.org; dkim=none (message not signed) header.d=none; sourceware.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: 5920e682-03f8-4675-cc46-08d924e232db X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: T+Aoo+Z3cNbQ7znvN3sH5cwCDQzV9/GrXiWbcmw1cTwafsGMxaW60W1+kmoLFGTzZ+GSyF5R22MCpPETB/incQUaEj5dvDrRdxkR1zDvkMxdtbhAUdGRVDd/K6EPAItiwx9AJWT2SzSQbvbJcfrzYJQ35eeyzDUq7n2VHVwYQXYRdSG8JDCEpYbTgFvRI67U2pVWmV3YK4KWEGb3uCuF9BcOBioTtOktG5rE1C4vuxjr7JA3tI7l1HGBHGM8nnEvrLHoWeN9mcjSUNOVqnIATXeqmzgXeX3aAuKGlQJml+Zp3xIGd55S9sSQSTQzPzWEUo9uNl2F/e8xqF6xCUOEnAGHHE7PhmN2aEquraN8397T70GQ3fj0nDvDfFJBMWXqzqT71h0/m8Z0VCJYH6jvxqzMIwG2xCcB+K5wEo8YV9JnEocgpfZoE5uJ+VkPHMSfu6krFAw7Ty9uZ+rMozgeQBDjlmg6Dm4vj4bx26z25S4dGng20syQpItgtzRGe1KIdJLFR+ZLWSQpt/Os/ypiWRBMGYUKVDqFmVQvJluBj3xA5YCTx76td2mnUumhTpcEoQzBd3PClmWoGsiBelnQ0nOTCwvehiHEQNTnivN/KLXZXH3wri7hyi0WG70US8+pqFXXpbftkDRKcgjY8XGS0/Hfn2/jJsOUMGzBxoCjqEUtxAx0qU52l3aLNoLdGSwG X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(396003)(39860400002)(36840700001)(46966006)(336012)(82310400003)(36756003)(478600001)(956004)(6506007)(5660300002)(2616005)(2906002)(8936002)(4744005)(6916009)(44832011)(186003)(16526019)(6512007)(1076003)(86362001)(316002)(70206006)(81166007)(70586007)(82740400003)(6666004)(47076005)(36860700001)(26005)(6486002)(8676002)(356005)(69590400013); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2021 09:47:22.4396 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4ddb479-26ba-43f8-049a-08d924e2413a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM5EUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB5138 X-Spam-Status: No, score=-14.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Szabolcs Nagy via Libc-alpha From: Szabolcs Nagy Reply-To: Szabolcs Nagy Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" The AArch64 PCS requires 16 byte aligned stack. Previously if the caller passed an unaligned stack to clone then the child crashed. Fixes bug 27939. --- sysdeps/unix/sysv/linux/aarch64/clone.S | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sysdeps/unix/sysv/linux/aarch64/clone.S b/sysdeps/unix/sysv/linux/aarch64/clone.S index c9e63bae48..fe04bce6b6 100644 --- a/sysdeps/unix/sysv/linux/aarch64/clone.S +++ b/sysdeps/unix/sysv/linux/aarch64/clone.S @@ -47,6 +47,8 @@ ENTRY(__clone) /* Sanity check args. */ mov x0, #-EINVAL cbz x10, .Lsyscall_error + /* Align sp. */ + and x1, x1, -16 cbz x1, .Lsyscall_error /* Do the system call. */