diff mbox series

[3/3] tst: Add test for clock_settime

Message ID 20210118160336.2553-3-lukma@denx.de
State Superseded
Delegated to: Adhemerval Zanella Netto
Headers show
Series [1/3] tst: Extend cross-test-ssh.sh to specify if target date can be altered | expand

Commit Message

Lukasz Majewski Jan. 18, 2021, 4:03 p.m. UTC
This code brings test to check if time on target machine is properly set.
To avoid any issues with altering the time:

- The time, which was set before the test was executed is restored.

- The time is altered only when cross-test-ssh.sh is executed with
  --allow-time-setting flag
---
 time/Makefile            |  2 +-
 time/tst-clock_settime.c | 45 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 46 insertions(+), 1 deletion(-)
 create mode 100644 time/tst-clock_settime.c

Comments

Lukasz Majewski Feb. 3, 2021, 2:19 p.m. UTC | #1
Dear Community,

> This code brings test to check if time on target machine is properly
> set. To avoid any issues with altering the time:
> 
> - The time, which was set before the test was executed is restored.
> 
> - The time is altered only when cross-test-ssh.sh is executed with
>   --allow-time-setting flag

Gentle ping on this patch.

> ---
>  time/Makefile            |  2 +-
>  time/tst-clock_settime.c | 45
> ++++++++++++++++++++++++++++++++++++++++ 2 files changed, 46
> insertions(+), 1 deletion(-) create mode 100644
> time/tst-clock_settime.c
> 
> diff --git a/time/Makefile b/time/Makefile
> index e6f448d938..e469cacb4a 100644
> --- a/time/Makefile
> +++ b/time/Makefile
> @@ -50,7 +50,7 @@ tests	:= test_time clocktest tst-posixtz
> tst-strptime tst_wcsftime \ tst-tzname tst-y2039 bug-mktime4
> tst-strftime2 tst-strftime3 \ tst-clock tst-clock2
> tst-clock_nanosleep tst-cpuclock1 \ tst-adjtime tst-clock-y2038
> tst-clock2-y2038 \
> -	   tst-cpuclock1-y2038 tst-clock_nanosleep-y2038
> +	   tst-cpuclock1-y2038 tst-clock_nanosleep-y2038
> tst-clock_settime 
>  include ../Rules
>  
> diff --git a/time/tst-clock_settime.c b/time/tst-clock_settime.c
> new file mode 100644
> index 0000000000..2abf6b8eb8
> --- /dev/null
> +++ b/time/tst-clock_settime.c
> @@ -0,0 +1,45 @@
> +/* Test for clock_settime (in VM)
> +   Copyright (C) 2021 Free Software Foundation, Inc.
> +   This file is part of the GNU C Library.
> +
> +   The GNU C Library is free software; you can redistribute it and/or
> +   modify it under the terms of the GNU Lesser General Public
> +   License as published by the Free Software Foundation; either
> +   version 2.1 of the License, or (at your option) any later version.
> +
> +   The GNU C Library is distributed in the hope that it will be
> useful,
> +   but WITHOUT ANY WARRANTY; without even the implied warranty of
> +   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +   Lesser General Public License for more details.
> +
> +   You should have received a copy of the GNU Lesser General Public
> +   License along with the GNU C Library; if not, see
> +   <https://www.gnu.org/licenses/>.  */
> +
> +#include <time.h>
> +#include <support/check.h>
> +#include <support/xtime.h>
> +
> +#define TIMESPEC_SEC_Y2038_OV 0x7FFFFFFF
> +#define FUTURE_TIME (TIMESPEC_SEC_Y2038_OV - 10)
> +
> +static int
> +do_test (void)
> +{
> +  const struct timespec tv = { FUTURE_TIME, 0};
> +  struct timespec tv_future, tv_now;
> +
> +  tv_now = xclock_now(CLOCK_REALTIME);
> +  xclock_settime(CLOCK_REALTIME, &tv);
> +  tv_future = xclock_now(CLOCK_REALTIME);
> +
> +  /* Restore old time value on target machine.  */
> +  xclock_settime(CLOCK_REALTIME, (const struct timespec*) &tv_now);
> +
> +  if (tv_future.tv_sec < tv.tv_sec)
> +    FAIL_EXIT1 ("clock_settime set wrong time!\n");
> +
> +  return 0;
> +}
> +
> +#include <support/test-driver.c>




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
diff mbox series

Patch

diff --git a/time/Makefile b/time/Makefile
index e6f448d938..e469cacb4a 100644
--- a/time/Makefile
+++ b/time/Makefile
@@ -50,7 +50,7 @@  tests	:= test_time clocktest tst-posixtz tst-strptime tst_wcsftime \
 	   tst-tzname tst-y2039 bug-mktime4 tst-strftime2 tst-strftime3 \
 	   tst-clock tst-clock2 tst-clock_nanosleep tst-cpuclock1 \
 	   tst-adjtime tst-clock-y2038 tst-clock2-y2038 \
-	   tst-cpuclock1-y2038 tst-clock_nanosleep-y2038
+	   tst-cpuclock1-y2038 tst-clock_nanosleep-y2038 tst-clock_settime
 
 include ../Rules
 
diff --git a/time/tst-clock_settime.c b/time/tst-clock_settime.c
new file mode 100644
index 0000000000..2abf6b8eb8
--- /dev/null
+++ b/time/tst-clock_settime.c
@@ -0,0 +1,45 @@ 
+/* Test for clock_settime (in VM)
+   Copyright (C) 2021 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
+#include <time.h>
+#include <support/check.h>
+#include <support/xtime.h>
+
+#define TIMESPEC_SEC_Y2038_OV 0x7FFFFFFF
+#define FUTURE_TIME (TIMESPEC_SEC_Y2038_OV - 10)
+
+static int
+do_test (void)
+{
+  const struct timespec tv = { FUTURE_TIME, 0};
+  struct timespec tv_future, tv_now;
+
+  tv_now = xclock_now(CLOCK_REALTIME);
+  xclock_settime(CLOCK_REALTIME, &tv);
+  tv_future = xclock_now(CLOCK_REALTIME);
+
+  /* Restore old time value on target machine.  */
+  xclock_settime(CLOCK_REALTIME, (const struct timespec*) &tv_now);
+
+  if (tv_future.tv_sec < tv.tv_sec)
+    FAIL_EXIT1 ("clock_settime set wrong time!\n");
+
+  return 0;
+}
+
+#include <support/test-driver.c>