Message ID | 20210116145632.7636-1-alx.manpages@gmail.com |
---|---|
State | Not applicable |
Headers |
Return-Path: <libc-alpha-bounces@sourceware.org> X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B58023870841; Sat, 16 Jan 2021 14:57:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B58023870841 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1610809044; bh=GBNeTSu04ixKYSzbYAV+880sIV5+lGfcrwYBDcoDztA=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=ikFqJS+2MVUC/79VHaWL3MRXMpdCdFsAjoMxAkTrePK7wTx1dlUml/rWwUnxUL9yV ai7Td9xAQmM5LG/4CG/R1fqBRUzxzC9JrAld4wjFrArMGP0HcEt9znw54KE168Rk5w j3bU897Xp8/tfIm0siQNUHYCgze1Aa8McVhMj8Os= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 3EB03385802A for <libc-alpha@sourceware.org>; Sat, 16 Jan 2021 14:57:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3EB03385802A Received: by mail-wm1-x32e.google.com with SMTP id r4so10061346wmh.5 for <libc-alpha@sourceware.org>; Sat, 16 Jan 2021 06:57:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=GBNeTSu04ixKYSzbYAV+880sIV5+lGfcrwYBDcoDztA=; b=OnKkEhGT+IBeEPKk8octtWyLMYTEZGahC8QKjt774xtImeyTm7f/Akn2cM05/rJZOZ 7KuI2k9HcR+yPYveT5Bs7z2gZ92pMH1X9JVACdRD72vz6quBRxMdPalx6xvRLAnHLyN1 RzReuTznAunI30f6ydOIJrU1jfQMJxZ1v0uUDDyO5W0dZ8/wCxVY7cINxxJyDtUklMok RE5WG2WPQt4o/od8rFp5N6dzjA674F7SI6sEukB2bXiCUdECVx+f/jucakqkPa1lbc41 sHFFGOyW5aMmZcxT4nihIF1a/Ymr7KN1+TZLzA5oRUPLjOLi09/9KIeaQjjOudRnPBtR XtMQ== X-Gm-Message-State: AOAM5301Gj3N6PfTzUkixAlOa9RkdtNrgXEWBoguLpN+dO4xJxqZ80Cq siqU5icGsY8hI220mjS2BOY= X-Google-Smtp-Source: ABdhPJwm71FymYwD2RCaAQe0ruh5XNahsyLNfkIwL+NUnHq8L9JrVeaj5YOOjlfFOQEHLVAB1cN/oQ== X-Received: by 2002:a1c:e0d4:: with SMTP id x203mr13318861wmg.160.1610809041319; Sat, 16 Jan 2021 06:57:21 -0800 (PST) Received: from debian.vlc ([170.253.51.130]) by smtp.gmail.com with ESMTPSA id h83sm17285824wmf.9.2021.01.16.06.57.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 Jan 2021 06:57:20 -0800 (PST) To: mtk.manpages@gmail.com Subject: [PATCH] cacheflush.2: Update SYNOPSIS for glibc wrapper Date: Sat, 16 Jan 2021 15:56:33 +0100 Message-Id: <20210116145632.7636-1-alx.manpages@gmail.com> X-Mailer: git-send-email 2.30.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list <libc-alpha.sourceware.org> List-Unsubscribe: <https://sourceware.org/mailman/options/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=unsubscribe> List-Archive: <https://sourceware.org/pipermail/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-request@sourceware.org?subject=help> List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-alpha>, <mailto:libc-alpha-request@sourceware.org?subject=subscribe> From: Alejandro Colomar via Libc-alpha <libc-alpha@sourceware.org> Reply-To: Alejandro Colomar <alx.manpages@gmail.com> Cc: Alejandro Colomar <alx.manpages@gmail.com>, linux-man@vger.kernel.org, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Vincent Chen <deanbo422@gmail.com>, Nick Hu <nickhu@andestech.com>, Heinrich Schuchardt <xypron.glpk@gmx.de>, linux-mips@vger.kernel.org, linux-csky@vger.kernel.org, Martin Sebor <msebor@redhat.com>, Guo Ren <guoren@kernel.org>, Greentime Hu <green.hu@gmail.com>, Vineet Gupta <vgupta@synopsys.com>, libc-alpha@sourceware.org, linux-snps-arc@lists.infradead.org, Dave Martin <Dave.Martin@arm.com> Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" <libc-alpha-bounces@sourceware.org> |
Series |
cacheflush.2: Update SYNOPSIS for glibc wrapper
|
|
Commit Message
Alejandro Colomar
Jan. 16, 2021, 2:56 p.m. UTC
Glibc uses 'void *' instead of 'char *'.
And the prototype is declared in <sys/cacheflush.h>.
......
$ syscall='cacheflush';
$ ret='int';
$ find glibc/ -type f -name '*.h' \
|xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;";
glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27:
extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
glibc/sysdeps/unix/sysv/linux/mips/sys/cachectl.h:35:
extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW;
glibc/sysdeps/unix/sysv/linux/arc/sys/cachectl.h:30:
extern int cacheflush (void *__addr, int __nbytes, int __op) __THROW;
glibc/sysdeps/unix/sysv/linux/csky/sys/cachectl.h:30:
extern int cacheflush (void *__addr, const int __nbytes,
const int __op) __THROW;
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
---
man2/cacheflush.2 | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hi Alex, On 1/16/21 3:56 PM, Alejandro Colomar wrote: > Glibc uses 'void *' instead of 'char *'. > And the prototype is declared in <sys/cacheflush.h>. > > ...... > > $ syscall='cacheflush'; > $ ret='int'; > $ find glibc/ -type f -name '*.h' \ > |xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;"; > glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27: > extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW; > glibc/sysdeps/unix/sysv/linux/mips/sys/cachectl.h:35: > extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW; > glibc/sysdeps/unix/sysv/linux/arc/sys/cachectl.h:30: > extern int cacheflush (void *__addr, int __nbytes, int __op) __THROW; > glibc/sysdeps/unix/sysv/linux/csky/sys/cachectl.h:30: > extern int cacheflush (void *__addr, const int __nbytes, > const int __op) __THROW; > > Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> Thanks. Patch applied. Cheers, Michael > --- > man2/cacheflush.2 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/man2/cacheflush.2 b/man2/cacheflush.2 > index 2cf624f3a..0496879ca 100644 > --- a/man2/cacheflush.2 > +++ b/man2/cacheflush.2 > @@ -27,9 +27,9 @@ > cacheflush \- flush contents of instruction and/or data cache > .SH SYNOPSIS > .nf > -.B #include <asm/cachectl.h> > +.B #inlcude <sys/cacheflush.h> > .PP > -.BI "int cacheflush(char *" addr ", int "nbytes ", int "cache ); > +.BI "int cacheflush(void *" addr ", int "nbytes ", int "cache ); > .fi > .PP > .IR Note : >
Hi Michael, On 1/17/21 9:34 PM, Michael Kerrisk (man-pages) wrote: > Hi Alex, > > On 1/16/21 3:56 PM, Alejandro Colomar wrote: >> Glibc uses 'void *' instead of 'char *'. >> And the prototype is declared in <sys/cacheflush.h>. D'oh! >> >> ...... >> >> $ syscall='cacheflush'; >> $ ret='int'; >> $ find glibc/ -type f -name '*.h' \ >> |xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;"; >> glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27: It is defined in <sys/cachectl.h> Please fix that. Thanks, Alex >> extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW; >> glibc/sysdeps/unix/sysv/linux/mips/sys/cachectl.h:35: >> extern int cacheflush (void *__addr, const int __nbytes, const int __op) __THROW; >> glibc/sysdeps/unix/sysv/linux/arc/sys/cachectl.h:30: >> extern int cacheflush (void *__addr, int __nbytes, int __op) __THROW; >> glibc/sysdeps/unix/sysv/linux/csky/sys/cachectl.h:30: >> extern int cacheflush (void *__addr, const int __nbytes, >> const int __op) __THROW; >> >> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> > > Thanks. Patch applied. > > Cheers, > > Michael > >> --- >> man2/cacheflush.2 | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/man2/cacheflush.2 b/man2/cacheflush.2 >> index 2cf624f3a..0496879ca 100644 >> --- a/man2/cacheflush.2 >> +++ b/man2/cacheflush.2 >> @@ -27,9 +27,9 @@ >> cacheflush \- flush contents of instruction and/or data cache >> .SH SYNOPSIS >> .nf >> -.B #include <asm/cachectl.h> >> +.B #inlcude <sys/cacheflush.h> s/cacheflush.h/cachectl.h/ >> .PP >> -.BI "int cacheflush(char *" addr ", int "nbytes ", int "cache ); >> +.BI "int cacheflush(void *" addr ", int "nbytes ", int "cache ); >> .fi >> .PP >> .IR Note : >> > >
On 1/17/21 9:43 PM, Alejandro Colomar (man-pages) wrote: > Hi Michael, > > On 1/17/21 9:34 PM, Michael Kerrisk (man-pages) wrote: >> Hi Alex, >> >> On 1/16/21 3:56 PM, Alejandro Colomar wrote: >>> Glibc uses 'void *' instead of 'char *'. >>> And the prototype is declared in <sys/cacheflush.h>. > > D'oh! > >>> >>> ...... >>> >>> $ syscall='cacheflush'; >>> $ ret='int'; >>> $ find glibc/ -type f -name '*.h' \ >>> |xargs pcregrep -Mn "(?s)^[\w\s]*${ret}\s*${syscall}\s*\(.*?;"; >>> glibc/sysdeps/unix/sysv/linux/nios2/sys/cachectl.h:27: > > It is defined in <sys/cachectl.h> > > Please fix that. Fixed! (Everything pushed now.)
diff --git a/man2/cacheflush.2 b/man2/cacheflush.2 index 2cf624f3a..0496879ca 100644 --- a/man2/cacheflush.2 +++ b/man2/cacheflush.2 @@ -27,9 +27,9 @@ cacheflush \- flush contents of instruction and/or data cache .SH SYNOPSIS .nf -.B #include <asm/cachectl.h> +.B #inlcude <sys/cacheflush.h> .PP -.BI "int cacheflush(char *" addr ", int "nbytes ", int "cache ); +.BI "int cacheflush(void *" addr ", int "nbytes ", int "cache ); .fi .PP .IR Note :