From patchwork Wed Dec 2 23:09:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 41274 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DD52396E467; Wed, 2 Dec 2020 23:09:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DD52396E467 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1606950591; bh=jkO6XtqUnXeXEWRsuwONebKLXVGeq1pQkLMETH/tBxQ=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=twVNuL7M+ZZWxBMcbvj1BjXH7MuinmgDz2LduRdIGpXuD16r11u2aBVTM9+HGpKlH dlyf9CdGs278GIQRK6B3HDWNDpbgwp8frdbLqzRubpeEUTTij2+xa+1N1Qpj7Sw0eG jisq6JrZUdL6nuHuzO8tYkXY/DrqvfhDRw/YIdBs= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by sourceware.org (Postfix) with ESMTPS id 261AF396E437 for ; Wed, 2 Dec 2020 23:09:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 261AF396E437 Received: by mail-pj1-x1031.google.com with SMTP id j13so27074pjz.3 for ; Wed, 02 Dec 2020 15:09:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=jkO6XtqUnXeXEWRsuwONebKLXVGeq1pQkLMETH/tBxQ=; b=STPptcVfsVOIKVAxixUxZ+nezua4JGTdyZ90w4296GqJyPe5t+DYKT6vIwZdRoTXJm CTs+LWIZ443u0tUo2hPecus+umDQqnbtbFxDbqsSJsGFt9lNERjIkV/hOVdYWg6i9NGH wgfvqNIYftQ8uXjAtmMjsNZsWXv8oRe5KYkubDTpiRE/G8CdznIJsIf59+3HQ2pkw6BH Ah61N2tc7S9WCPclw9G0hlwsdoy8sHXbpAaK7Lr+ogLiTQnXvGZ/7lxTLrp9+5XDdd7t nFcLxQ80GuJTBqpthuESq3PR0s2WtYJiIF4W7Hus4osmsFrSCKyj3KLkXKJSVJFrA1Qg K9Zg== X-Gm-Message-State: AOAM531+43J42PdKzt6KSmhszfA8UnNBKVSz2SRWxqxxnZCOr4W7GJon 0kchf8x+4FI+wHNPlvQsp58Nq69hWOI= X-Google-Smtp-Source: ABdhPJyKxmaTHFw70Qj17MnGULld11FXxf3WhCXfvsMfGggfbMZnW5u0vG5eouDrN4WM4UCLzBfjXQ== X-Received: by 2002:a17:90a:c901:: with SMTP id v1mr230632pjt.7.1606950587023; Wed, 02 Dec 2020 15:09:47 -0800 (PST) Received: from gnu-cfl-2.localdomain (c-69-181-90-243.hsd1.ca.comcast.net. [69.181.90.243]) by smtp.gmail.com with ESMTPSA id p1sm132728pfb.208.2020.12.02.15.09.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Dec 2020 15:09:45 -0800 (PST) Received: from gnu-cfl-2.localdomain (localhost [IPv6:::1]) by gnu-cfl-2.localdomain (Postfix) with ESMTP id EADB81A0177 for ; Wed, 2 Dec 2020 15:09:44 -0800 (PST) To: libc-alpha@sourceware.org Subject: [PATCH] Mark __libc_freeres_fn as used [# 27002] Date: Wed, 2 Dec 2020 15:09:43 -0800 Message-Id: <20201202230943.4027351-1-hjl.tools@gmail.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Spam-Status: No, score=-3039.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: "H.J. Lu via Libc-alpha" From: "H.J. Lu" Reply-To: "H.J. Lu" Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" GCC 11 with commit 6fbec038f7a7ddf29f074943611b53210d17c40c Author: H.J. Lu Date: Mon Feb 3 11:55:43 2020 -0800 Use SHF_GNU_RETAIN to preserve symbol definitions places used symbols in SECTION_RETAIN sections if assembler supports it. Mark __libc_freeres_fn as used to avoid In file included from : gconv_dl.c: In function 'free_mem': gconv_dl.c:202:18: error: 'free_mem' causes a section type conflict with 'do_release_all' 202 | libc_freeres_fn (free_mem) | ^~~~~~~~ ./../include/libc-symbols.h:316:15: note: in definition of macro 'libc_freeres_fn' 316 | static void name (void) | ^~~~ gconv_dl.c:191:1: note: 'do_release_all' was declared here 191 | do_release_all (void *nodep) | ^~~~~~~~~~~~~~ where free_mem is marked as used. --- include/libc-symbols.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/libc-symbols.h b/include/libc-symbols.h index b8103b98bb..b8fc1584d2 100644 --- a/include/libc-symbols.h +++ b/include/libc-symbols.h @@ -307,7 +307,7 @@ for linking") /* Resource freeing functions from libc.so go in this section. */ #define __libc_freeres_fn_section \ - __attribute__ ((section ("__libc_freeres_fn"))) + __attribute__ ((__used__, section ("__libc_freeres_fn"))) /* Resource freeing functions for libc.so. */ #define libc_freeres_fn(name) \