From patchwork Tue Oct 13 21:16:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Ludovic_Court=C3=A8s?= X-Patchwork-Id: 40717 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6F271388CC18; Tue, 13 Oct 2020 21:17:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6F271388CC18 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1602623858; bh=ToQuqP1UzdTltgAe8M0hCX+QbWYXdhQNQx3+NrkQpK0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=s0Y8xf9QQJM5EykY64IZbqezFEYPBLabwWBnwPGBNs7u/e8JsTN0MOcMRuincwfP0 xUe5YUwramqj2QhmXKqdY+QK084FPgBbe06qwlYVR+qgwVjqI4GING3D21yh29LPl3 NEuTXv3O8T9Ko7G3UhvMyBFTh4QYghTN3/0NAkko= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 9C0FF385042A for ; Tue, 13 Oct 2020 21:17:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9C0FF385042A Received: from fencepost.gnu.org ([2001:470:142:3::e]:44339) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSRfr-0006Z6-IB; Tue, 13 Oct 2020 17:17:35 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=59590 helo=gnu.org) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kSRfr-0002CY-5N; Tue, 13 Oct 2020 17:17:35 -0400 To: libc-alpha@sourceware.org Subject: [PATCH] hurd: '_hurd_raise_signal' checks signal number is valid Date: Tue, 13 Oct 2020 23:16:57 +0200 Message-Id: <20201013211657.1869-1-ludo@gnu.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201013135744.mpizainhz43e5vkl@function> References: <20201013135744.mpizainhz43e5vkl@function> MIME-Version: 1.0 X-Spam-Status: No, score=-10.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Ludovic_Court=C3=A8s_via_Libc-alpha?= From: =?utf-8?q?Ludovic_Court=C3=A8s?= Reply-To: =?utf-8?q?Ludovic_Court=C3=A8s?= Cc: =?utf-8?q?Ludovic_Court=C3=A8s?= , bug-hurd@gnu.org, Samuel Thibault Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" Previously, 'pthread_kill (pthread_self (), -1)' would wrongfully succeed: https://lists.gnu.org/archive/html/guix-devel/2020-10/msg00152.html Reported-by: Jan Nieuwenhuizen --- hurd/hurd-raise.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hurd/hurd-raise.c b/hurd/hurd-raise.c index d53fd417d2..58b4ffcc83 100644 --- a/hurd/hurd-raise.c +++ b/hurd/hurd-raise.c @@ -28,6 +28,9 @@ int _hurd_raise_signal (struct hurd_sigstate *ss, int signo, const struct hurd_signal_detail *detail) { + if (signo < 1 || signo >= _NSIG) + return EINVAL; + if (ss == NULL) { ss = _hurd_self_sigstate ();