diff mbox series

[1/2] rtld: fix typo in comment

Message ID 20200922121300.3503-1-eb@emlix.com
State New
Headers show
Series [1/2] rtld: fix typo in comment | expand

Commit Message

Rolf Eike Beer Sept. 22, 2020, 12:12 p.m. UTC
---
 elf/rtld.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

H.J. Lu Sept. 22, 2020, 12:23 p.m. UTC | #1
On Tue, Sep 22, 2020 at 5:13 AM Rolf Eike Beer <eb@emlix.com> wrote:
>
> ---
>  elf/rtld.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/elf/rtld.c b/elf/rtld.c
> index 5b882163fa..99d130cd1c 100644
> --- a/elf/rtld.c
> +++ b/elf/rtld.c
> @@ -352,7 +352,7 @@ struct rtld_global _rtld_global =
>    };
>  /* If we would use strong_alias here the compiler would see a
>     non-hidden definition.  This would undo the effect of the previous
> -   declaration.  So spell out was strong_alias does plus add the
> +   declaration.  So spell out what strong_alias does plus add the
>     visibility attribute.  */
>  extern struct rtld_global _rtld_local
>      __attribute__ ((alias ("_rtld_global"), visibility ("hidden")));
> --
> 2.28.0
>

LGTM.

Thanks.
Rolf Eike Beer Oct. 12, 2020, 7:08 a.m. UTC | #2
Am Dienstag, 22. September 2020, 14:23:40 CEST schrieb H.J. Lu:
> On Tue, Sep 22, 2020 at 5:13 AM Rolf Eike Beer <eb@emlix.com> wrote:
> > ---
> > 
> >  elf/rtld.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/elf/rtld.c b/elf/rtld.c
> > index 5b882163fa..99d130cd1c 100644
> > --- a/elf/rtld.c
> > +++ b/elf/rtld.c
> > @@ -352,7 +352,7 @@ struct rtld_global _rtld_global =
> > 
> >    };
> >  
> >  /* If we would use strong_alias here the compiler would see a
> >  
> >     non-hidden definition.  This would undo the effect of the previous
> > 
> > -   declaration.  So spell out was strong_alias does plus add the
> > +   declaration.  So spell out what strong_alias does plus add the
> > 
> >     visibility attribute.  */
> >  
> >  extern struct rtld_global _rtld_local
> >  
> >      __attribute__ ((alias ("_rtld_global"), visibility ("hidden")));
> > 
> > --
> > 2.28.0
> 
> LGTM.

Is anyone going to pick it up?

Eike
H.J. Lu Oct. 13, 2020, 12:52 p.m. UTC | #3
On Mon, Oct 12, 2020 at 12:08 AM Rolf Eike Beer <eb@emlix.com> wrote:
>
> Am Dienstag, 22. September 2020, 14:23:40 CEST schrieb H.J. Lu:
> > On Tue, Sep 22, 2020 at 5:13 AM Rolf Eike Beer <eb@emlix.com> wrote:
> > > ---
> > >
> > >  elf/rtld.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/elf/rtld.c b/elf/rtld.c
> > > index 5b882163fa..99d130cd1c 100644
> > > --- a/elf/rtld.c
> > > +++ b/elf/rtld.c
> > > @@ -352,7 +352,7 @@ struct rtld_global _rtld_global =
> > >
> > >    };
> > >
> > >  /* If we would use strong_alias here the compiler would see a
> > >
> > >     non-hidden definition.  This would undo the effect of the previous
> > >
> > > -   declaration.  So spell out was strong_alias does plus add the
> > > +   declaration.  So spell out what strong_alias does plus add the
> > >
> > >     visibility attribute.  */
> > >
> > >  extern struct rtld_global _rtld_local
> > >
> > >      __attribute__ ((alias ("_rtld_global"), visibility ("hidden")));
> > >
> > > --
> > > 2.28.0
> >
> > LGTM.
>
> Is anyone going to pick it up?

I checked it in for you.

Thanks.
diff mbox series

Patch

diff --git a/elf/rtld.c b/elf/rtld.c
index 5b882163fa..99d130cd1c 100644
--- a/elf/rtld.c
+++ b/elf/rtld.c
@@ -352,7 +352,7 @@  struct rtld_global _rtld_global =
   };
 /* If we would use strong_alias here the compiler would see a
    non-hidden definition.  This would undo the effect of the previous
-   declaration.  So spell out was strong_alias does plus add the
+   declaration.  So spell out what strong_alias does plus add the
    visibility attribute.  */
 extern struct rtld_global _rtld_local
     __attribute__ ((alias ("_rtld_global"), visibility ("hidden")));