From patchwork Mon Jun 22 21:10:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alistair Francis X-Patchwork-Id: 39773 Return-Path: X-Original-To: patchwork@sourceware.org Delivered-To: patchwork@sourceware.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6113C38930E3; Mon, 22 Jun 2020 21:19:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6113C38930E3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1592860785; bh=YiPqo6h8gNIjQ1pFlT/TvG0SGpVlxNrfYWZ6nAPasXk=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=EsSGvBLDlP7DTrIEnLnw1RlyeyqH/86ZjkPmrSnE9SQe52KJ8q8GEWaHAIiBhcwfB /54pUkpD7eW2ho9Sxm0mmH6kwEmA1P1sTtdcKAHTiCz5m05AKr4Zy4LDEoIchDsDKL 8U+lb2skCNlYlT3vdYdbPmf/s8Hcm8dI+fjh01u0= X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from esa3.hgst.iphmx.com (esa3.hgst.iphmx.com [216.71.153.141]) by sourceware.org (Postfix) with ESMTPS id 862D1388B009 for ; Mon, 22 Jun 2020 21:19:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 862D1388B009 IronPort-SDR: vz4FzxF6+Pzme81fxEP9Pz96N5KzuLvsnSNIN6YFb0X6OYvPwuMIP0Mp3bcRck/69BBg9Hi+cm MTlD50ryQ0x6PPM84bdC149RVVmV+Ob5UZ2kN0xCpo0HPAvcyUoPdUSZ6btwRnolZU1Ni7lgRQ iSkA6GcOerPrxnnZ03fENNF4bwv0tyhrmud/xj3Q6f+LmKu4TVKUq0nWjSGE83HbxeXAhoB0IW +GS2on8kgzEXB+Th89/TF20BliHdi96BhDuR8xDVTL18EGtnKjpKlj0Eh6jQPIBLa546ClFuDH lb8= X-IronPort-AV: E=Sophos;i="5.75,268,1589212800"; d="scan'208";a="144959560" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 23 Jun 2020 05:19:41 +0800 IronPort-SDR: epmk/B8sY6mnf1Ji+pJcVLvT4JBaBAtIeRCzqs7a+30hJl6+NDutE9EObd4R+laQP/LHNT9A28 K75gVoHFUBgSmCzIGBV98CYzXuFNwJ0bU= Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2020 14:08:46 -0700 IronPort-SDR: JXu/nHX1kAgoz7obQHwjJfmr3Sg/E4CciCDECvBOnULTwCT3cHjKH8k0NW6vwJbtLysKcm/j7w N6WthawplPOQ== WDCIronportException: Internal Received: from lpt-kalia-a.ad.shared (HELO risc6-mainframe.hgst.com) ([10.86.58.195]) by uls-op-cesaip01.wdc.com with ESMTP; 22 Jun 2020 14:19:42 -0700 To: libc-alpha@sourceware.org Subject: [PATCH] Allow memset local PLT reference for RISC-V. Date: Mon, 22 Jun 2020 14:10:34 -0700 Message-Id: <20200622211034.659739-1-alistair.francis@wdc.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Spam-Status: No, score=-15.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Alistair Francis via Libc-alpha From: Alistair Francis Reply-To: Alistair Francis Cc: Alistair Francis Errors-To: libc-alpha-bounces@sourceware.org Sender: "Libc-alpha" This is similar to commit a26e2e9feab87d4f745c31411458b048742ac733 "Allow memset local PLT reference for powerpc soft-float.". GCC 10.1 results in the localplt test failing for RISC-V. From the original commit for power-pc: Since memset is documented as a function GCC may always implicitly generate calls to, it seems reasonable to allow that local PLT reference (just like those for libgcc functions that GCC implicitly generates calls to and that are also exported from libc.so), which this patch does. Acked-by: Palmer Dabbelt --- sysdeps/unix/sysv/linux/riscv/localplt.data | 1 + 1 file changed, 1 insertion(+) diff --git a/sysdeps/unix/sysv/linux/riscv/localplt.data b/sysdeps/unix/sysv/linux/riscv/localplt.data index 0ed8650b65..0a235592c3 100644 --- a/sysdeps/unix/sysv/linux/riscv/localplt.data +++ b/sysdeps/unix/sysv/linux/riscv/localplt.data @@ -5,6 +5,7 @@ libc.so: calloc libc.so: free libc.so: malloc libc.so: memalign +libc.so: memset ? libc.so: realloc # The TLS-enabled version of these functions is interposed from libc.so. ld.so: _dl_signal_error