diff mbox series

powerpc: Add new hwcap values

Message ID 20200615175057.296354-1-tuliom@linux.ibm.com
State Committed
Delegated to: Florian Weimer
Headers
Series powerpc: Add new hwcap values |

Commit Message

Tulio Magno Quites Machado Filho June 15, 2020, 5:50 p.m. UTC 
  Linux commit ID ee988c11acf6f9464b7b44e9a091bf6afb3b3a49 reserved 2 new
bits in AT_HWCAP2:
 - PPC_FEATURE2_ARCH_3_1 indicates the availability of the POWER ISA
   3.1;
 - PPC_FEATURE2_MMA indicates the availability of the Matrix-Multiply
   Assist facility.
---
 sysdeps/powerpc/bits/hwcap.h  | 2 ++
 sysdeps/powerpc/dl-procinfo.c | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Florian Weimer June 15, 2020, 6:26 p.m. UTC | #1 
* Tulio Magno Quites Machado Filho via Libc-alpha:

> Linux commit ID ee988c11acf6f9464b7b44e9a091bf6afb3b3a49 reserved 2 new
> bits in AT_HWCAP2:
>  - PPC_FEATURE2_ARCH_3_1 indicates the availability of the POWER ISA
>    3.1;
>  - PPC_FEATURE2_MMA indicates the availability of the Matrix-Multiply
>    Assist facility.
> ---
>  sysdeps/powerpc/bits/hwcap.h  | 2 ++
>  sysdeps/powerpc/dl-procinfo.c | 2 +-
>  2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sysdeps/powerpc/bits/hwcap.h b/sysdeps/powerpc/bits/hwcap.h
> index 4a5a7bcded..e8f3fdea92 100644
> --- a/sysdeps/powerpc/bits/hwcap.h
> +++ b/sysdeps/powerpc/bits/hwcap.h
> @@ -74,3 +74,5 @@
>  #define PPC_FEATURE2_SCV	   0x00100000 /* scv syscall.  */
>  #define PPC_FEATURE2_HTM_NO_SUSPEND  0x00080000 /* TM without suspended
>  						   state.  */
> +#define PPC_FEATURE2_ARCH_3_1	   0x00040000 /* ISA 3.1.  */
> +#define PPC_FEATURE2_MMA	   0x00020000 /* Matrix-Multiply Assist.  */
> diff --git a/sysdeps/powerpc/dl-procinfo.c b/sysdeps/powerpc/dl-procinfo.c
> index 7a7d93dd0a..8dc07728f0 100644
> --- a/sysdeps/powerpc/dl-procinfo.c
> +++ b/sysdeps/powerpc/dl-procinfo.c
> @@ -77,7 +77,7 @@ PROCINFO_CLASS const char _dl_powerpc_cap_flags[64][15]
>      "", "", "", "",
>      "", "", "", "",
>      "", "", "", "",
> -    "", "", "", "htm-no-suspend",
> +    "", "mma", "arch_3_1", "htm-no-suspend",
>      "scv", "darn", "ieee128", "arch_3_00",
>      "htm-nosc", "vcrypto", "tar", "isel",
>      "ebb", "dscr", "htm", "arch_2_07",

Change looks good to me.

Do we want to update HWCAP_IMPORTANT at this point?  I don't think so.
It's already not very helpful on powerpc64le at least.

Thanks,
Florian
Tulio Magno Quites Machado Filho June 16, 2020, 1:23 p.m. UTC | #2 
Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> writes:

> Do we want to update HWCAP_IMPORTANT at this point?  I don't think so.
> It's already not very helpful on powerpc64le at least.

I agree.
Tulio Magno Quites Machado Filho June 23, 2020, 9:41 p.m. UTC | #3 
Tulio Magno Quites Machado Filho via Libc-alpha <libc-alpha@sourceware.org> writes:

> Florian Weimer via Libc-alpha <libc-alpha@sourceware.org> writes:
>
>> Do we want to update HWCAP_IMPORTANT at this point?  I don't think so.
>> It's already not very helpful on powerpc64le at least.
>
> I agree.

Pushed as ae725e3f9cb4e1eb825ebe1d55241c98c2ea32f1.

Thanks!
diff mbox series

Patch

diff --git a/sysdeps/powerpc/bits/hwcap.h b/sysdeps/powerpc/bits/hwcap.h
index 4a5a7bcded..e8f3fdea92 100644
--- a/sysdeps/powerpc/bits/hwcap.h
+++ b/sysdeps/powerpc/bits/hwcap.h
@@ -74,3 +74,5 @@ 
 #define PPC_FEATURE2_SCV	   0x00100000 /* scv syscall.  */
 #define PPC_FEATURE2_HTM_NO_SUSPEND  0x00080000 /* TM without suspended
 						   state.  */
+#define PPC_FEATURE2_ARCH_3_1	   0x00040000 /* ISA 3.1.  */
+#define PPC_FEATURE2_MMA	   0x00020000 /* Matrix-Multiply Assist.  */
diff --git a/sysdeps/powerpc/dl-procinfo.c b/sysdeps/powerpc/dl-procinfo.c
index 7a7d93dd0a..8dc07728f0 100644
--- a/sysdeps/powerpc/dl-procinfo.c
+++ b/sysdeps/powerpc/dl-procinfo.c
@@ -77,7 +77,7 @@  PROCINFO_CLASS const char _dl_powerpc_cap_flags[64][15]
     "", "", "", "",
     "", "", "", "",
     "", "", "", "",
-    "", "", "", "htm-no-suspend",
+    "", "mma", "arch_3_1", "htm-no-suspend",
     "scv", "darn", "ieee128", "arch_3_00",
     "htm-nosc", "vcrypto", "tar", "isel",
     "ebb", "dscr", "htm", "arch_2_07",