From patchwork Fri Apr 17 13:22:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella X-Patchwork-Id: 38823 Return-Path: X-Original-To: libc-alpha@sourceware.org Delivered-To: libc-alpha@sourceware.org Received: from mail-qt1-x843.google.com (mail-qt1-x843.google.com [IPv6:2607:f8b0:4864:20::843]) by sourceware.org (Postfix) with ESMTPS id 7E5CE385DC0B for ; Fri, 17 Apr 2020 13:22:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7E5CE385DC0B Received: by mail-qt1-x843.google.com with SMTP id 71so1815677qtc.12 for ; Fri, 17 Apr 2020 06:22:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=PaVnCyQRIeb6GRBpshB3U/qkN5F+pOCW+UfkrwievVA=; b=OpALXjkGq6fsuxwiGhqCodneG7wPAR0umvjNIyR30kTT+A583Ucoo3b1RH/MIuxtWA eSBtqjEECi+SSGnmmSdzJebAdQOdEJ5/7MGVTIFpp5TRZZr5EUbHNi6WhAfBlxSqJSnY Pkb93btzRxWTHtV+KfNhVFRWQF0LBzQ+tZKaxqg0KwQDOUhRfdwEj2hH/2cRLY878qx3 KAFnZbDFBCq5EjFjQafBcpdT+e+LD8c0rthNLwyiIH3fAnZkU/AT5S6JgBf00uLzEQdM 3ByQPDDsBX5RnP9wilwyb6WHmBjcUaln/qIN56g8bk/xeV+cEPCDwkM7xsbIY3hHXTM6 KGTQ== X-Gm-Message-State: AGi0Puaah9Z4VMyPMowZ2mq3GGzs4IhenQ1mHviY4ap2SGsTBrh8NvGk faH+FYldzbe2eIYQ1nPynob13Fh1SifE4A== X-Google-Smtp-Source: APiQypJTjNZa2fNXUeLPW1028jxdQgntaBmvM5pEtwMBW/ICQbDZ3zBz41UvBQgv6lQ13i6Yz3kL6A== X-Received: by 2002:aed:3a86:: with SMTP id o6mr2926171qte.262.1587129738928; Fri, 17 Apr 2020 06:22:18 -0700 (PDT) Received: from localhost.localdomain ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id s14sm14737571qts.70.2020.04.17.06.22.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2020 06:22:18 -0700 (PDT) From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH 04/10] linux: Use internal DIR locks when accessing filepos on telldir Date: Fri, 17 Apr 2020 10:22:03 -0300 Message-Id: <20200417132209.22065-4-adhemerval.zanella@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200417132209.22065-1-adhemerval.zanella@linaro.org> References: <20200417132209.22065-1-adhemerval.zanella@linaro.org> X-Spam-Status: No, score=-25.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2020 13:22:20 -0000 Since it might change during a readdir call. Checked on x86_64-linux-gnu and i686-linux-gnu. --- sysdeps/unix/sysv/linux/telldir.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/sysdeps/unix/sysv/linux/telldir.c b/sysdeps/unix/sysv/linux/telldir.c index 1bb822c807..57d435ed21 100644 --- a/sysdeps/unix/sysv/linux/telldir.c +++ b/sysdeps/unix/sysv/linux/telldir.c @@ -23,5 +23,11 @@ long int telldir (DIR *dirp) { - return dirp->filepos; + long int ret; + + __libc_lock_lock (dirp->lock); + ret = dirp->filepos; + __libc_lock_unlock (dirp->lock); + + return ret; }