Message ID | 20200305140105.22734-2-adhemerval.zanella@linaro.org |
---|---|
State | Dropped |
Headers |
Received: (qmail 76323 invoked by alias); 5 Mar 2020 14:01:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 75057 invoked by uid 89); 5 Mar 2020 14:01:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qk1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=wey0csPxmJBrSwm8ExPnmgRut4jgQ88OC24DDIRNyww=; b=b9zPSYyQgHgj9qhWbe8kTLRxhwqt2TyO5eeU8r4Ad+OyTjRIYKPOEokH9Oa7ULkvd+ 4tymbaZsyDHqZqEB5dhOGwop+1hvHMSzuF9fqUZEIsGq2x4wO4Y6XxkyuhHygy2tO1Vr jsdDck31XThmLNkc7FDVUivl8NjtKER2rwKWq5fMGkU30h6WSxhiQ6ZL0HAk/0nD6khA GU8JMMBj+g6dJbhowJWdNwZqOQpfczdUYJVcOxsWpTVPUYfYRXKFr37ZiRx1jU0wo9gk SfyR3rrhOSdYX0ukObn8dTDU1LsNBQd/99QxwojVDUQLJmKa284jUEQXC6oqCXuEdb3W HFuQ== Return-Path: <adhemerval.zanella@linaro.org> From: Adhemerval Zanella <adhemerval.zanella@linaro.org> To: libc-alpha@sourceware.org Subject: [PATCH v2 2/2] arm: Fix softp-fp Implies (BZ #25635) Date: Thu, 5 Mar 2020 11:01:05 -0300 Message-Id: <20200305140105.22734-2-adhemerval.zanella@linaro.org> In-Reply-To: <20200305140105.22734-1-adhemerval.zanella@linaro.org> References: <20200305140105.22734-1-adhemerval.zanella@linaro.org> |
Commit Message
Adhemerval Zanella
March 5, 2020, 2:01 p.m. UTC
Changes from previous version: - Remove wrong --without-fp mention. - Change the order on generic sysdep Implies instead of Linux one. -- The commit "arm: Split BE/LE abilist" (1673ba87fefe019c834c09d33673d1d453ea698d) changed the soft-fp order for ARM selection when __SOFTFP__ is defined by the compiler. On 2.31 the sysdeps order is: 2.31 sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptl sysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/ieee754 sysdeps/generic While on master is: sysdeps/unix/sysv/linux/arm/le sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptl sysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/le sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/ieee754 sysdeps/generic It make the build select some routines (fadd, fdiv, fmul, fsub, and fma) on ieee754/flt-32 and ieee754/dbl-64 that requires fenv support to be correctly rounded which in turns lead to math failures since the __SOFTFP__ does not have fenv support. With this patch the order is now: sysdeps/unix/sysv/linux/arm/le sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptlsysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/le/nofpu sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/arm/le sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/ieee754 sysdeps/generic Checked on arm-linux-gnuaebi. --- sysdeps/arm/be/nofpu/Implies | 1 + sysdeps/arm/le/nofpu/Implies | 1 + 2 files changed, 2 insertions(+) create mode 100644 sysdeps/arm/be/nofpu/Implies create mode 100644 sysdeps/arm/le/nofpu/Implies
Comments
On Thu, 5 Mar 2020, Adhemerval Zanella wrote: > Changes from previous version: > > - Remove wrong --without-fp mention. > - Change the order on generic sysdep Implies instead of Linux one. > > -- > > The commit "arm: Split BE/LE abilist" > (1673ba87fefe019c834c09d33673d1d453ea698d) changed the soft-fp order for > ARM selection when __SOFTFP__ is defined by the compiler. > > On 2.31 the sysdeps order is: > > 2.31 "git tag --contains 1673ba87fefe019c834c09d33673d1d453ea698d" says that commit is in 2.31, so I suppose this should actually be a reference to 2.30 as the version the old sysdeps order comes from. OK with that fix to the commit message.
diff --git a/sysdeps/arm/be/nofpu/Implies b/sysdeps/arm/be/nofpu/Implies new file mode 100644 index 0000000000..c90dd7fd5c --- /dev/null +++ b/sysdeps/arm/be/nofpu/Implies @@ -0,0 +1 @@ +arm/nofpu diff --git a/sysdeps/arm/le/nofpu/Implies b/sysdeps/arm/le/nofpu/Implies new file mode 100644 index 0000000000..c90dd7fd5c --- /dev/null +++ b/sysdeps/arm/le/nofpu/Implies @@ -0,0 +1 @@ +arm/nofpu