From patchwork Mon Dec 16 14:34:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alexandra_H=C3=A1jkov=C3=A1?= X-Patchwork-Id: 36896 Received: (qmail 125999 invoked by alias); 16 Dec 2019 14:34:40 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 125984 invoked by uid 89); 16 Dec 2019 14:34:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy=filtered, H*RU:209.85.221.67, HX-Spam-Relays-External:209.85.221.67 X-HELO: mail-wr1-f67.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KLE9Z3IjTs+Mo3X20pqS3wqGib3gJIHGK6BSaQkrJDY=; b=IUKuZAyckwpg4Yseh7SYOFjPenFsdyU9YZG6jRdiP/ic+UJYQsM4OGKs32WFT6LL3i Hd5Q6oe4BPsR7LJGp9KJCX3XZsbkmVA4zFBdTIb/gRFzNRPSybe4l7Gq8AGuNRn9uTYt OlHKEra4kpX5NeZSHYw1f7xVQCcYZz/VpE7iS6DBlu6MeI2bVnZUzRphnxd19vuMbzcs D53EqaCSABOgGs4k3qEUSRD0x+prSuVoAMB+EOt3EVLV4IYFLLAExlLo8vZLmodUS3qa NXBycpXWX439AYnAw4hZMr0GniJgG6WKBHsGwVpi2KdRnjY5jm4Anp7Znq8r7oe6bTO+ AcYg== Return-Path: From: =?UTF-8?Q?Alexandra_H=C3=A1jkov=C3=A1?= To: libc-alpha@sourceware.org Cc: =?UTF-8?q?Alexandra=20H=C3=A1jkov=C3=A1?= Subject: [PATCH v2] elf: Add tst-ldconfig-ld_so_conf-update test Date: Mon, 16 Dec 2019 15:34:24 +0100 Message-Id: <20191216143424.22882-1-ahajkova@redhat.com> In-Reply-To: <20191205172608.GA57577@aloka.lostca.se> References: <20191205172608.GA57577@aloka.lostca.se> MIME-Version: 1.0 From: Alexandra Hájková Test ldconfig after /etc/ld.so.conf update and verify a running process observes changes to /etc/ld.so.cache. The test uses the test-in-container framework. --- elf/Makefile | 11 +- elf/tst-ldconfig-ld-mod.c | 8 ++ elf/tst-ldconfig-ld_so_conf-update.c | 115 ++++++++++++++++++ .../postclean.req | 0 .../tst-ldconfig-ld_so_conf-update.script | 1 + 5 files changed, 132 insertions(+), 3 deletions(-) create mode 100644 elf/tst-ldconfig-ld-mod.c create mode 100644 elf/tst-ldconfig-ld_so_conf-update.c create mode 100644 elf/tst-ldconfig-ld_so_conf-update.root/postclean.req create mode 100644 elf/tst-ldconfig-ld_so_conf-update.root/tst-ldconfig-ld_so_conf-update.script diff --git a/elf/Makefile b/elf/Makefile index 72a5aa88b1..a89226f163 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -162,8 +162,9 @@ tests-static-internal := tst-tls1-static tst-tls2-static \ CRT-tst-tls1-static-non-pie := $(csu-objpfx)crt1.o tst-tls1-static-non-pie-no-pie = yes -tests-container = \ - tst-ldconfig-bad-aux-cache +tests-container := \ + tst-ldconfig-bad-aux-cache \ + tst-ldconfig-ld_so_conf-update tests := tst-tls9 tst-leaks1 \ tst-array1 tst-array2 tst-array3 tst-array4 tst-array5 \ @@ -309,7 +310,8 @@ modules-names = testobj1 testobj2 testobj3 testobj4 testobj5 testobj6 \ tst-auditmanymod4 tst-auditmanymod5 tst-auditmanymod6 \ tst-auditmanymod7 tst-auditmanymod8 tst-auditmanymod9 \ tst-initlazyfailmod tst-finilazyfailmod \ - tst-dlopenfailmod1 tst-dlopenfaillinkmod tst-dlopenfailmod2 + tst-dlopenfailmod1 tst-dlopenfaillinkmod tst-dlopenfailmod2 \ + tst-ldconfig-ld-mod # Most modules build with _ISOMAC defined, but those filtered out # depend on internal headers. modules-names-tests = $(filter-out ifuncmod% tst-libc_dlvsym-dso tst-tlsmod%,\ @@ -1689,3 +1691,6 @@ $(objpfx)tst-dlopen-nodelete-reloc-mod17.so: \ $(objpfx)tst-dlopen-nodelete-reloc-mod15.so \ $(objpfx)tst-dlopen-nodelete-reloc-mod16.so LDFLAGS-tst-dlopen-nodelete-reloc-mod17.so = -Wl,--no-as-needed + +$(objpfx)tst-ldconfig-ld_so_conf-update.out: $(objpfx)tst-ldconfig-ld-mod.so +$(objpfx)tst-ldconfig-ld_so_conf-update: $(libdl) diff --git a/elf/tst-ldconfig-ld-mod.c b/elf/tst-ldconfig-ld-mod.c new file mode 100644 index 0000000000..f8f658d03b --- /dev/null +++ b/elf/tst-ldconfig-ld-mod.c @@ -0,0 +1,8 @@ +#include +#include + +void +bar (void) +{ + printf ("Called DSO.\n"); +} diff --git a/elf/tst-ldconfig-ld_so_conf-update.c b/elf/tst-ldconfig-ld_so_conf-update.c new file mode 100644 index 0000000000..54fae5c829 --- /dev/null +++ b/elf/tst-ldconfig-ld_so_conf-update.c @@ -0,0 +1,115 @@ +/* Test ldconfig after /etc/ld.so.conf update and verify that a running process + observes changes to /etc/ld.so.cache. + + Copyright (C) 2019 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public License as + published by the Free Software Foundation; either version 2.1 of the + License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; see the file COPYING.LIB. If + not, see . */ + +#include +#include +#include +#include + +#include +#include +#include +#include +#include +#include + + +#define DSO "libldconfig-ld-mod.so" +#define DSO_DIR "/tmp/tst-ldconfig" +#define CONF "/etc/ld.so.conf" + + +static void +run_ldconfig (void *x __attribute__((unused))) +{ + char *prog = xasprintf ("%s/ldconfig", support_install_rootsbindir); + char *args[] = { prog, NULL }; + + execv (args[0], args); + FAIL_EXIT1 ("execv: %m"); +} + + +/* Create a new directory. + Copy a test shared object there. + Try to dlopen it by soname. This should fail. + (Directory is not searched.) + Run ldconfig. + Try to dlopen it again. It should still fail. + (Directory is still not searched.) + Add the directory to /etc/ld.so.conf. + Try to dlopen it again. It should still fail. + (The loader does not read /etc/ld.so.conf, only /etc/ld.so.cache.) + Run ldconfig. + Try to dlopen it again. This should finally succeed. */ +static int +do_test (void) +{ + struct support_capture_subprocess result; + + /* Create the needed directories. */ + xmkdirp ("/var/cache/ldconfig", 0777); + xmkdirp (DSO_DIR, 0777); + + /* Rename the DSO to start with "lib" because there's an undocumented + filter in ldconfig where it ignores any file that doesn't start with + "lib" (for regular shared libraries) or "ld-" (for ld-linux-*). */ + if (rename ("/usr/lib64/tst-ldconfig-ld-mod.so", + "/tmp/tst-ldconfig/libldconfig-ld-mod.so")) + FAIL_EXIT1 ("Renaming/moving the DSO failed: %m"); + + + /* Open the DSO. We expect this to fail - tst-ldconfig directory + is not searched. */ + TEST_VERIFY_EXIT (dlopen (DSO, RTLD_NOW | RTLD_GLOBAL) == NULL); + + FILE *fp = xfopen (CONF, "a+"); + if (!fp) + FAIL_EXIT1 ("creating /etc/ld.so.conf failed: %m"); + xfclose (fp); + + /* Run ldconfig. */ + result = support_capture_subprocess (run_ldconfig, NULL); + support_capture_subprocess_check (&result, "execv", 0, sc_allow_none); + + /* Try to dlopen the same DSO again, we expect this to fail again. */ + TEST_VERIFY_EXIT (dlopen (DSO, RTLD_NOW | RTLD_GLOBAL) == NULL); + + /* Add tst-ldconfig directory to /etc/ld.so.conf. */ + fp = xfopen (CONF, "w"); + if (!(fwrite (DSO_DIR, 1, sizeof (DSO_DIR), fp))) + FAIL_EXIT1 ("updating /etc/ld.so.conf failed: %m"); + xfclose (fp); + + /* Try to dlopen the same DSO again, we expect this to still fail. */ + TEST_VERIFY_EXIT (dlopen (DSO, RTLD_NOW | RTLD_GLOBAL) == NULL); + + /* Run ldconfig again. */ + result = support_capture_subprocess (run_ldconfig, NULL); + support_capture_subprocess_check (&result, "execv", 0, sc_allow_none); + support_capture_subprocess_free (&result); + + /* Finally, we expect dlopen to pass now. */ + TEST_VERIFY_EXIT (dlopen (DSO, RTLD_NOW | RTLD_GLOBAL) != NULL); + + return 0; +} + +#include diff --git a/elf/tst-ldconfig-ld_so_conf-update.root/postclean.req b/elf/tst-ldconfig-ld_so_conf-update.root/postclean.req new file mode 100644 index 0000000000..e69de29bb2 diff --git a/elf/tst-ldconfig-ld_so_conf-update.root/tst-ldconfig-ld_so_conf-update.script b/elf/tst-ldconfig-ld_so_conf-update.root/tst-ldconfig-ld_so_conf-update.script new file mode 100644 index 0000000000..be562ba554 --- /dev/null +++ b/elf/tst-ldconfig-ld_so_conf-update.root/tst-ldconfig-ld_so_conf-update.script @@ -0,0 +1 @@ +cp $B/elf/tst-ldconfig-ld-mod.so $L/tst-ldconfig-ld-mod.so