Make tst-strftime2 depend on locale generation
Commit Message
From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
Building the test cases in parallel might make tst-strftime2 fail.
Simply re-running the test case (or building with -j1) makes the problem
go away. This patch adds the necessary dependency to allow parallel
builds in the time subdirectory.
Tested for powerpc64le.
---
time/Makefile | 1 +
1 file changed, 1 insertion(+)
Comments
* Gabriel F. T. Gomes:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>
> Building the test cases in parallel might make tst-strftime2 fail.
> Simply re-running the test case (or building with -j1) makes the problem
> go away. This patch adds the necessary dependency to allow parallel
> builds in the time subdirectory.
>
> Tested for powerpc64le.
> ---
> time/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/time/Makefile b/time/Makefile
> index b9217992a6..cface6f68a 100644
> --- a/time/Makefile
> +++ b/time/Makefile
> @@ -61,6 +61,7 @@ include ../gen-locales.mk
>
> $(objpfx)tst-ftime_l.out: $(gen-locales)
> $(objpfx)tst-strptime.out: $(gen-locales)
> +$(objpfx)tst-strftime2.out: $(gen-locales)
> endif
>
> tz-cflags = -DTZDIR='"$(zonedir)"' \
Doesn't tst-strftime3 have the same problem? Looks good otherwise.
(We still don't have the official switchover to ChangeLog-less
commits, so this still needs an entry there.)
"Gabriel F. T. Gomes" <gabriel@inconstante.net.br> writes:
> From: "Gabriel F. T. Gomes" <gabrielftg@linux.ibm.com>
>
> Building the test cases in parallel might make tst-strftime2 fail.
> Simply re-running the test case (or building with -j1) makes the problem
> go away. This patch adds the necessary dependency to allow parallel
> builds in the time subdirectory.
>
> Tested for powerpc64le.
LGTM as-is. I confirmed it solves the issue.
Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
> diff --git a/time/Makefile b/time/Makefile
> index b9217992a6..cface6f68a 100644
> --- a/time/Makefile
> +++ b/time/Makefile
> @@ -61,6 +61,7 @@ include ../gen-locales.mk
>
> $(objpfx)tst-ftime_l.out: $(gen-locales)
> $(objpfx)tst-strptime.out: $(gen-locales)
> +$(objpfx)tst-strftime2.out: $(gen-locales)
Likewise for tst-strftime3.out ?
I've never seen an error there, but the test does depend on locales too.
@@ -61,6 +61,7 @@ include ../gen-locales.mk
$(objpfx)tst-ftime_l.out: $(gen-locales)
$(objpfx)tst-strptime.out: $(gen-locales)
+$(objpfx)tst-strftime2.out: $(gen-locales)
endif
tz-cflags = -DTZDIR='"$(zonedir)"' \