From patchwork Sun Mar 24 12:21:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konstantin Kharlamov X-Patchwork-Id: 31961 Received: (qmail 4099 invoked by alias); 24 Mar 2019 12:21:38 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 3982 invoked by uid 89); 24 Mar 2019 12:21:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1343, H*F:D*ru, HContent-Transfer-Encoding:8bit X-HELO: forward106p.mail.yandex.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1553430093; bh=9HCVISdNLnU4fyPNoV8uffyuDE7CQCmwARpkdCEcb1k=; h=In-Reply-To:Subject:To:From:References:Date:Message-Id; b=nwMor1x4A9byJ0fAqyWdVXttUFxWKiG0fPwMPscC1e3q4XZwcIp/POW6kTWA4pLTu n38w+rtqWdDBAZVSnk6UMTZ9pxasvTguhEJZK5MO2SRPo+kGazZk+jbILQFUqgP3RJ NwBdOOAHH7HSXNrKIFvtAEl9yaJ1t+zwQmSDsX7k= Authentication-Results: mxback10j.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Konstantin Kharlamov To: libc-alpha@sourceware.org Subject: [PATCH 4/5] resolv: don't pass struct ns_mst by value Date: Sun, 24 Mar 2019 15:21:20 +0300 Message-Id: <20190324122121.6430-5-Hi-Angel@yandex.ru> In-Reply-To: <20190324122121.6430-1-Hi-Angel@yandex.ru> References: <20190324122121.6430-1-Hi-Angel@yandex.ru> MIME-Version: 1.0 Fixes LGTM warning: "This parameter of type ns_msg is 80 bytes - consider passing a const pointer/reference instead." Signed-off-by: Konstantin Kharlamov --- resolv/arpa/nameser.h | 2 +- resolv/ns_parse.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/resolv/arpa/nameser.h b/resolv/arpa/nameser.h index a99d5ec508..7d2f717848 100644 --- a/resolv/arpa/nameser.h +++ b/resolv/arpa/nameser.h @@ -390,7 +390,7 @@ typedef enum __ns_cert_types { } while (0) __BEGIN_DECLS -int ns_msg_getflag (ns_msg, int) __THROW; +int ns_msg_getflag (const ns_msg*, int) __THROW; unsigned int ns_get16 (const unsigned char *) __THROW; unsigned long ns_get32 (const unsigned char *) __THROW; void ns_put16 (unsigned int, unsigned char *) __THROW; diff --git a/resolv/ns_parse.c b/resolv/ns_parse.c index 863b20a9f7..5211bcdd49 100644 --- a/resolv/ns_parse.c +++ b/resolv/ns_parse.c @@ -57,8 +57,8 @@ const struct _ns_flagdata _ns_flagdata[16] = { }; #undef ns_msg_getflag -int ns_msg_getflag(ns_msg handle, int flag) { - return(((handle)._flags & _ns_flagdata[flag].mask) >> _ns_flagdata[flag].shift); +int ns_msg_getflag(const ns_msg *handle, int flag) { + return(((handle)->_flags & _ns_flagdata[flag].mask) >> _ns_flagdata[flag].shift); } int