From patchwork Sun Mar 24 12:21:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konstantin Kharlamov X-Patchwork-Id: 31960 Received: (qmail 3734 invoked by alias); 24 Mar 2019 12:21:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 3719 invoked by uid 89); 24 Mar 2019 12:21:35 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_PASS autolearn=ham version=3.3.1 spammy=H*F:D*ru, HContent-Transfer-Encoding:8bit X-HELO: forward102p.mail.yandex.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1553430091; bh=pNelHR6zrE4HWo8ZONw31IcZcBlpZLKR1mOp1blN8pM=; h=In-Reply-To:Subject:To:From:References:Date:Message-Id; b=qt1fSA+cnodJBOTpM4hqvkV7mPKGikAR1RXvKFcnFnKAvimoL+WeUtbT9wX9VlIHh zgaO9yTGih7QlI4T63410BpDyhVmK8R6iYlTDJrFqjnEZNaoV2O+NETt+ds9WYcJxr b5IKRTqGNrSBra1L/f2c1xRBLE26NvaFIYoMbyOw= Authentication-Results: mxback20g.mail.yandex.net; dkim=pass header.i=@yandex.ru From: Konstantin Kharlamov To: libc-alpha@sourceware.org Subject: [PATCH 1/5] support: don't pass to set_search_path a big struct by value Date: Sun, 24 Mar 2019 15:21:17 +0300 Message-Id: <20190324122121.6430-2-Hi-Angel@yandex.ru> In-Reply-To: <20190324122121.6430-1-Hi-Angel@yandex.ru> References: <20190324122121.6430-1-Hi-Angel@yandex.ru> MIME-Version: 1.0 Fixes LGTM warning: " This parameter of type resolv_redirect_config is 88 bytes - consider passing a const pointer/reference instead." Signed-off-by: Konstantin Kharlamov --- support/resolv_test.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/support/resolv_test.c b/support/resolv_test.c index 903ab2ac05..f400026cd1 100644 --- a/support/resolv_test.c +++ b/support/resolv_test.c @@ -1079,7 +1079,7 @@ resolv_test_init (void) /* Copy the search path from CONFIG.search to the _res object. */ static void -set_search_path (struct resolv_redirect_config config) +set_search_path (const struct resolv_redirect_config* config) { memset (_res.defdname, 0, sizeof (_res.defdname)); memset (_res.dnsrch, 0, sizeof (_res.dnsrch)); @@ -1088,15 +1088,15 @@ set_search_path (struct resolv_redirect_config config) char *end = current + sizeof (_res.defdname); for (unsigned int i = 0; - i < sizeof (config.search) / sizeof (config.search[0]); ++i) + i < sizeof (config->search) / sizeof (config->search[0]); ++i) { - if (config.search[i] == NULL) + if (config->search[i] == NULL) continue; - size_t length = strlen (config.search[i]) + 1; + size_t length = strlen (config->search[i]) + 1; size_t remaining = end - current; TEST_VERIFY_EXIT (length <= remaining); - memcpy (current, config.search[i], length); + memcpy (current, config->search[i], length); _res.dnsrch[i] = current; current += length; } @@ -1203,7 +1203,7 @@ resolv_test_start (struct resolv_redirect_config config) } } - set_search_path (config); + set_search_path (&config); return obj; }