[v3] localedata: Add Minguo calendar support to zh_TW [BZ #24293]

  Minguo calendar is the official calendar system, and very widely used in
Taiwan, it would be nice to have the support in glibc.

Some background information: The government website (www.gov.tw) uses it,
popular public services like Taiwan HSR also uses this calendar system.

Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar

        [BZ #24293]
        * localedata/locales/zh_TW (era): Add, support Minguo calendar.
---
 localedata/locales/cmn_TW | 4 ++++
 localedata/locales/hak_TW | 4 ++++
 localedata/locales/lzh_TW | 4 ++++
 localedata/locales/nan_TW | 4 ++++
 localedata/locales/zh_TW  | 4 ++++
 5 files changed, 20 insertions(+)
  

Hello Felix,

Thank you for the next version of your patch.

2.03.2019 18:11 Felix Yan <felixonmars@archlinux.org> wrote:
> 
> Minguo calendar is the official calendar system, and very widely used in
> Taiwan, it would be nice to have the support in glibc.

The commit language should be straight and simple, "it would be nice..."
is nice but not necessary, I think.  Also, it will be part of the
repository,
no need to express a wish when it will have been already fulfilled. :-)

> Some background information: The government website (www.gov.tw) uses it,
> popular public services like Taiwan HSR also uses this calendar system.

"also uses" -> "also use" (plural).

> Link to wikipedia: https://en.wikipedia.org/wiki/Minguo_calendar

"wikipedia" -> "Wikipedia".  Otherwise correct.

> 
>         [BZ #24293]
>         * localedata/locales/zh_TW (era): Add, support Minguo calendar.

All updated files must be listed here alphabetically, if the comment is
the same it should be replaced with "Likewise." E.g.,

        [BZ #24293]
        * localedata/locales/cmn_TW (era): Add, support Minguo calendar.
        * localedata/locales/hak_TW (era): Likewise.
        * ...

> ---
>  localedata/locales/cmn_TW | 4 ++++
>  localedata/locales/hak_TW | 4 ++++
>  localedata/locales/lzh_TW | 4 ++++
>  localedata/locales/nan_TW | 4 ++++
>  localedata/locales/zh_TW  | 4 ++++
>  5 files changed, 20 insertions(+)
> 
> diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW
> index cca7cc19af..9d9aca0f9e 100644
> --- a/localedata/locales/cmn_TW
> +++ b/localedata/locales/cmn_TW
> @@ -119,6 +119,10 @@ am_pm         "<U4E0A><U5348>";/
>  t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
>  % %Y年 %b %-d號 %A %H:%M:%S %Z
>  date_fmt      "%Y<U5E74> %b %-d<U865F> %A %H:%M:%S %Z"
> +
> +era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
> +    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
> +    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
>  END LC_TIME

Do I see correctly that the content of "era" is the same in all locales?
Please forgive me my ignorance, is this correct despite these are different
languages?

Regards,

Rafal
  

On 2019/3/6 上午7:45, Rafal Luzynski wrote:
>>  localedata/locales/cmn_TW | 4 ++++
>>  localedata/locales/hak_TW | 4 ++++
>>  localedata/locales/lzh_TW | 4 ++++
>>  localedata/locales/nan_TW | 4 ++++
>>  localedata/locales/zh_TW  | 4 ++++
>>  5 files changed, 20 insertions(+)
>>
>> diff --git a/localedata/locales/cmn_TW b/localedata/locales/cmn_TW
>> index cca7cc19af..9d9aca0f9e 100644
>> --- a/localedata/locales/cmn_TW
>> +++ b/localedata/locales/cmn_TW
>> @@ -119,6 +119,10 @@ am_pm         "<U4E0A><U5348>";/
>>  t_fmt_ampm    "%p %I<U9EDE>%M<U5206>%S<U79D2>"
>>  % %Y年 %b %-d號 %A %H:%M:%S %Z
>>  date_fmt      "%Y<U5E74> %b %-d<U865F> %A %H:%M:%S %Z"
>> +
>> +era "+:2:1913//01//01:+*:<U6C11><U570B>:%EC%Ey<U5E74>";/
>> +    "+:1:1912//01//01:1912//12//31:<U6C11><U570B>:%EC<U5143><U5E74>";/
>> +    "+:1:1911//12//31:-*:<U6C11><U524D>:%EC%Ey<U5E74>"
>>  END LC_TIME
> 
> Do I see correctly that the content of "era" is the same in all locales?
> Please forgive me my ignorance, is this correct despite these are different
> languages?

zh_TW is locale for the writing system of Traditional Chinese in Taiwan,
while the others are for different pronunciation systems. They are
reflecting different aspects (or variants) of the same language. I
believe most users uses zh_TW and very few uses the others. The others
can be useful for a TTS system, though.

I'll correct the issues and send next version shortly.
  

7.03.2019 10:35 Felix Yan <felixonmars@archlinux.org> wrote:
> On 2019/3/6 上午7:45, Rafal Luzynski wrote:
> > [...]
> > Do I see correctly that the content of "era" is the same in all locales?
> > Please forgive me my ignorance, is this correct despite these are
> > different
> > languages?
> 
> zh_TW is locale for the writing system of Traditional Chinese in Taiwan,
> while the others are for different pronunciation systems. They are
> reflecting different aspects (or variants) of the same language.

I don't think I understand this paragraph but I believe that you mean
that this is correct despite the language difference.  Due to my lack
of knowledge about Chinese language I am unable to verify this.

> I
> believe most users uses zh_TW and very few uses the others. The others
> can be useful for a TTS system, though.

That few people use a language is not a reason not to provide the
correct translation.  But that's irrelevant since (IIUC) the patch
provides correct locale data for all these languages.

> I'll correct the issues and send next version shortly.

Thank you, I will move to the new version.

Regards,

Rafal