Message ID | 20190110001717.25717-1-dilfridge@gentoo.org |
---|---|
State | Committed |
Commit | 5494af04adabe72cbd0055fe9ed466af529eaafd |
Headers |
Received: (qmail 103246 invoked by alias); 10 Jan 2019 00:17:37 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 102866 invoked by uid 89); 10 Jan 2019 00:17:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mo4-p00-ob.smtp.rzone.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1547079452; s=strato-dkim-0002; d=akhuettel.de; h=Message-Id:Date:Subject:Cc:To:From:X-RZG-CLASS-ID:X-RZG-AUTH:From: Subject:Sender; bh=yz+rj/aBem2lQBflCHFzPKx/W2ob9Np4Xv0nQzjq9eA=; b=tJbTVMT3t/GrYuwJkmq063r6vYO6SRocYg2ViGMMCJuV/QNouauI3V2Yes48dCkVJl pI6MtCg6uRrDLk6YM/cGXNU5TQ1WXVKfou4LcvIubbY4Gv6MsJOyMJVUwkK5zQZoT+J2 UwXfhfnKZdYq4PS7tNa8trUbyclkZOgqt++B9NHiiDQFkSoi2tnLk86ioLvv5PHB7Ozl 5xKO4s+/oo/Rfb3xqCdurll9JHcNKvMT6zZYSpujjp/Ac4S6YnE5VHpo7SjfEPE2bbD2 0aX/vJYLY+OMw+IH+DxL6k3IawoXR0M9b60yo5FqDMpkH1P9rg0m43tDNSVoWs586gLT yoeA== From: =?UTF-8?q?Andreas=20K=2E=20H=C3=BCttel?= <dilfridge@gentoo.org> To: libc-alpha@sourceware.org Cc: =?UTF-8?q?Andreas=20K=2E=20H=C3=BCttel?= <dilfridge@gentoo.org> Subject: [PATCH] resolv: AAAA (28) is valid, no fallthrough to default Date: Thu, 10 Jan 2019 01:17:17 +0100 Message-Id: <20190110001717.25717-1-dilfridge@gentoo.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit |
Commit Message
Andreas K. Huettel
Jan. 10, 2019, 12:17 a.m. UTC
The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling output "invalid qtype: 28". Puzzling since 28 is an AAAA record. Turns out the switch statement is missing a break, so the "T_AAAA" case continues with "default". --- resolv/tst-resolv-ai_idn-common.c | 1 + 1 file changed, 1 insertion(+)
Comments
* Andreas K. Hüttel: > The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the puzzling > output "invalid qtype: 28". Puzzling since 28 is an AAAA record. > Turns out the switch statement is missing a break, so the "T_AAAA" case > continues with "default". > --- > resolv/tst-resolv-ai_idn-common.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c > index bb81c2ca23..61cc81b71f 100644 > --- a/resolv/tst-resolv-ai_idn-common.c > +++ b/resolv/tst-resolv-ai_idn-common.c > @@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx, > qname[0] }; > resolv_response_add_data (b, &addr, sizeof (addr)); > } > + break; > default: > FAIL_EXIT1 ("invalid qtype: %d", qtype); > } The change is obviously correct. I will commit it for you. However, how do you encounter this issue? Did you change some test? The current IDN tests do not actually send AAAA queries, I think. Thanks, Florian
Am Donnerstag, 10. Januar 2019, 12:00:08 CET schrieb Florian Weimer: > * Andreas K. Hüttel: > > The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the > > puzzling > > output "invalid qtype: 28". Puzzling since 28 is an AAAA record. > > Turns out the switch statement is missing a break, so the "T_AAAA" case > > continues with "default". > > The change is obviously correct. I will commit it for you. > > However, how do you encounter this issue? Did you change some test? > The current IDN tests do not actually send AAAA queries, I think. > > Thanks, > Florian That's a puzzling question indeed. I didnt change anything with the test suite; the code is ~ tip of 2.28 release branch (plus few Gentoo-specific patches). The only Gentoo-specific commit which could be relevant is that we revert 8479f23aa1d5e5477a37f46823856bdafaedfa46 ("sysdeps/posix/getaddrinfo.c (gaih_inet): Only use gethostbyname4_r ..."). For the background see https://bugs.gentoo.org/600632
* Andreas K. Huettel: > Am Donnerstag, 10. Januar 2019, 12:00:08 CET schrieb Florian Weimer: >> * Andreas K. Hüttel: >> > The test resolv/tst-resolv-ai_idn-nolibidn2 kept failing, with the >> > puzzling >> > output "invalid qtype: 28". Puzzling since 28 is an AAAA record. >> > Turns out the switch statement is missing a break, so the "T_AAAA" case >> > continues with "default". >> >> The change is obviously correct. I will commit it for you. >> >> However, how do you encounter this issue? Did you change some test? >> The current IDN tests do not actually send AAAA queries, I think. >> >> Thanks, >> Florian > > That's a puzzling question indeed. I didnt change anything with the test > suite; the code is ~ tip of 2.28 release branch (plus few Gentoo-specific > patches). > > The only Gentoo-specific commit which could be relevant is that we revert > 8479f23aa1d5e5477a37f46823856bdafaedfa46 ("sysdeps/posix/getaddrinfo.c > (gaih_inet): Only use gethostbyname4_r ..."). For the background see > https://bugs.gentoo.org/600632 Yes, that is indeed the cause. Reverting that commit is a bit aggressive, though. Clearly you do not need to perform dual queries if the requested address family is AF_INET because that hasn't got any scope IDs. Thanks, Florian
diff --git a/resolv/tst-resolv-ai_idn-common.c b/resolv/tst-resolv-ai_idn-common.c index bb81c2ca23..61cc81b71f 100644 --- a/resolv/tst-resolv-ai_idn-common.c +++ b/resolv/tst-resolv-ai_idn-common.c @@ -241,6 +241,7 @@ response (const struct resolv_response_context *ctx, qname[0] }; resolv_response_add_data (b, &addr, sizeof (addr)); } + break; default: FAIL_EXIT1 ("invalid qtype: %d", qtype); }