| Message ID | 20181206180824.1761-2-gabriel@inconstante.eti.br |
|---|---|
| State | Committed |
| Delegated to: | Joseph Myers |
| Headers |
Received: (qmail 8969 invoked by alias); 6 Dec 2018 18:08:48 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: <libc-alpha.sourceware.org> List-Unsubscribe: <mailto:libc-alpha-unsubscribe-##L=##H@sourceware.org> List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org> List-Archive: <http://sourceware.org/ml/libc-alpha/> List-Post: <mailto:libc-alpha@sourceware.org> List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs> Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 8939 invoked by uid 89); 6 Dec 2018 18:08:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.2 spammy=H*F:D*br X-HELO: mo20.mail-out.ovh.net From: "Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> To: <libc-alpha@sourceware.org> Subject: [PATCH v1 1/7] Remove redirection of _IO_vfprintf Date: Thu, 6 Dec 2018 16:08:18 -0200 Message-ID: <20181206180824.1761-2-gabriel@inconstante.eti.br> In-Reply-To: <20181206180824.1761-1-gabriel@inconstante.eti.br> References: <20181206180824.1761-1-gabriel@inconstante.eti.br> MIME-Version: 1.0 Content-Type: text/plain X-Ovh-Tracer-Id: 7323415947871440579 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrudefjedguddtkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecu |
Commit Message
Gabriel F. T. Gomes
Dec. 6, 2018, 6:08 p.m. UTC
Since the commit
commit 698fb75b9ff5ae454a1344b5f9fafa0ca367c555
Author: Zack Weinberg <zackw@panix.com>
Date: Wed Mar 7 14:32:01 2018 -0500
Add __v*printf_internal with flags arguments
_IO_vfprintf is gone. This did not trigger any test case failures on
powerpc and powerpc64le, because there were no tests that covered it.
However, new test cases for nldbl versions of argp.h functions exposed
the problem.
Tested for powerpc64 and powerpc64le.
* libio/libio.h: Remove redirection for _IO_vfprintf.
---
libio/libio.h | 1 -
1 file changed, 1 deletion(-)
Comments
On Thu, 6 Dec 2018, Gabriel F. T. Gomes wrote: > Since the commit > > commit 698fb75b9ff5ae454a1344b5f9fafa0ca367c555 > Author: Zack Weinberg <zackw@panix.com> > Date: Wed Mar 7 14:32:01 2018 -0500 > > Add __v*printf_internal with flags arguments > > _IO_vfprintf is gone. This did not trigger any test case failures on I see that libio/iolibio.h has a call to _IO_vfprintf in a definition of _IO_vprintf as a macro. I suppose that's just left over from a previous patch? Other than that, yes, _IO_vfprintf seems gone apart from the aliases for ABI compatibility, so this patch is OK.
On Thu, Dec 6, 2018 at 3:34 PM Joseph Myers <joseph@codesourcery.com> wrote: > On Thu, 6 Dec 2018, Gabriel F. T. Gomes wrote: > > > > _IO_vfprintf is gone. This did not trigger any test case failures on > > I see that libio/iolibio.h has a call to _IO_vfprintf in a definition of > _IO_vprintf as a macro. I suppose that's just left over from a previous > patch? When I did the patches to stop installing libio.h, I noticed there were a whole bunch of stale definitions and prototypes in iolibio.h, but I decided it wasn't worth cleaning them up in that patch series, since iolibio.h has never (AFAICT) been installed. "Minimize the use of _IO_ interfaces throughout glibc" would be a good patch series for someone [who has more time than I do right now ;-)] to tackle, and maybe we would discover that iolibio.h was completely redundant at the end of it. zw
On Thu, 06 Dec 2018, Joseph Myers wrote: >I see that libio/iolibio.h has a call to _IO_vfprintf in a definition of >_IO_vprintf as a macro. I suppose that's just left over from a previous >patch? Other than that, yes, _IO_vfprintf seems gone apart from the >aliases for ABI compatibility, so this patch is OK. Thanks, now committed.
diff --git a/libio/libio.h b/libio/libio.h index 3a93807efc..e19d860dc6 100644 --- a/libio/libio.h +++ b/libio/libio.h @@ -300,7 +300,6 @@ extern void _IO_free_wbackup_area (FILE *) __THROW; #ifdef __LDBL_COMPAT __LDBL_REDIR_DECL (_IO_vfscanf) -__LDBL_REDIR_DECL (_IO_vfprintf) #endif libc_hidden_proto (__overflow)