Upstreaming the glibc Hurd port
Commit Message
Hello,
Joseph Myers, le mar. 03 avril 2018 00:13:43 +0000, a ecrit:
> On Mon, 2 Apr 2018, Samuel Thibault wrote:
> > Samuel Thibault, on lun. 02 avril 2018 17:50:17 +0200, wrote:
> > > There are a few remaining namespace issues due to missing __ marking or
> > > spurious #includes.
> >
> > One issue is with struct sched_param. The __sched_param definition
> > was removed in glibc while htl's pthread_attr uses it. For now I just
> > made struct___pthread_attr.h include <sched.h> but that brings things
> > unwanted for <sys/types.h> (which is supposed to pull pthread_attr).
> >
> > So I guess we should revert to defining __sched_param?
>
> If you need, on Hurd, in installed headers, a type "struct __sched_param",
> that would most naturally go in a Hurd-specific
> bits/types/struct___sched_param.h.
Well, there is actually nothing hurd-specific in struct sched_param,
except the fact that the __sched_param name is needed so
sys/types.h can have pthread_attr (which uses it) without exposing
sched_param, as required by some levels of standard (e.g.
./conform/POSIX/fcntl.h/conform.out complains about the presence of
sched_param currently). Linux doesn't have that issue because it just
always completely hides the content of pthread types.
The patch below would just introduce bits/types/struct___sched_param.h.
and bits/types/struct_sched_param.h for all ports since it's the same.
> Anything restoring the old __need_* mechanism for any glibc-internal
> definitions is not appropriate
Sure!
Samuel
Comments
On Wed, 18 Apr 2018, Samuel Thibault wrote:
> The patch below would just introduce bits/types/struct___sched_param.h.
> and bits/types/struct_sched_param.h for all ports since it's the same.
A bits/types/struct_sched_param.h that does "#define sched_param
__sched_param" is not appropriate for Linux, because it would change the
C++ mangling of struct sched_param.
@@ -29,10 +29,6 @@
#define SCHED_FIFO 1
#define SCHED_RR 2
-/* Data structure to describe a process' schedulability. */
-struct sched_param
-{
- int sched_priority;
-};
+#include <bits/types/struct_sched_param.h>
#endif /* bits/sched.h */
new file mode 100644
@@ -0,0 +1,28 @@
+/* Sched parameter structure. Generic version.
+ Copyright (C) 1996-2018 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef _BITS_TYPES_STRUCT___SCHED_PARAM
+#define _BITS_TYPES_STRUCT___SCHED_PARAM 1
+
+/* Data structure to describe a process' schedulability. */
+struct __sched_param
+{
+ int __sched_priority;
+};
+
+#endif /* bits/types/struct___sched_param.h */
new file mode 100644
@@ -0,0 +1,27 @@
+/* Sched parameter structure. Generic version.
+ Copyright (C) 1996-2018 Free Software Foundation, Inc.
+ This file is part of the GNU C Library.
+
+ The GNU C Library is free software; you can redistribute it and/or
+ modify it under the terms of the GNU Lesser General Public
+ License as published by the Free Software Foundation; either
+ version 2.1 of the License, or (at your option) any later version.
+
+ The GNU C Library is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ Lesser General Public License for more details.
+
+ You should have received a copy of the GNU Lesser General Public
+ License along with the GNU C Library; if not, see
+ <http://www.gnu.org/licenses/>. */
+
+#ifndef _BITS_TYPES_STRUCT_SCHED_PARAM
+#define _BITS_TYPES_STRUCT_SCHED_PARAM 1
+
+#include <bits/types/struct___sched_param.h>
+/* Define the real names for the elements of `struct sched_param'. */
+#define sched_param __sched_param
+#define sched_priority __sched_priority
+
+#endif /* bits/types/struct_sched_param.h */
@@ -31,7 +31,8 @@ headers := sys/utsname.h sys/times.h sys/wait.h sys/types.h unistd.h \
bits/local_lim.h tar.h bits/utsname.h bits/confname.h \
bits/waitflags.h bits/waitstatus.h sys/unistd.h sched.h \
bits/sched.h bits/cpu-set.h re_comp.h wait.h bits/environments.h \
- cpio.h spawn.h bits/unistd.h
+ cpio.h spawn.h bits/unistd.h \
+ bits/types/struct___sched_param.h bits/types/struct_sched_param.h
routines := \
uname \
@@ -43,11 +43,6 @@ typedef __pid_t pid_t;
#include <bits/sched.h>
#include <bits/cpu-set.h>
-/* Backward compatibility. */
-#define sched_priority sched_priority
-#define __sched_priority sched_priority
-
-
__BEGIN_DECLS
/* Set scheduling parameters for a process. */
@@ -19,7 +19,7 @@
#ifndef _BITS_TYPES_STRUCT___PTHREAD_ATTR
#define _BITS_TYPES_STRUCT___PTHREAD_ATTR 1
-#include <sched.h>
+#include <bits/types/struct___sched_param.h>
#define __need_size_t
#include <stddef.h>
@@ -32,7 +32,7 @@ enum __pthread_contentionscope;
that not all of them are supported on all systems. */
struct __pthread_attr
{
- struct sched_param __schedparam;
+ struct __sched_param __schedparam;
void *__stackaddr;
size_t __stacksize;
size_t __guardsize;
@@ -24,7 +24,7 @@
#include <pt-internal.h>
const struct __pthread_attr __pthread_default_attr = {
- __schedparam: { sched_priority: 0 },
+ __schedparam: { __sched_priority: 0 },
__stacksize: 0,
__stackaddr: NULL,
#ifdef PAGESIZE
@@ -32,8 +32,8 @@ thread_attr_compare (const pthread_attr_t * left, const pthread_attr_t * right)
struct __pthread_attr *ileft = (struct __pthread_attr *) left;
struct __pthread_attr *iright = (struct __pthread_attr *) right;
- return ileft->__schedparam.sched_priority
- == iright->__schedparam.sched_priority
+ return ileft->__schedparam.__sched_priority
+ == iright->__schedparam.__sched_priority
&& ileft->__stackaddr == iright->__stackaddr
&& ileft->__stacksize == iright->__stacksize
&& ileft->__guardsize == iright->__guardsize
@@ -71,11 +71,7 @@
# define CLONE_IO 0x80000000 /* Clone I/O context. */
#endif
-/* Data structure to describe a process' schedulability. */
-struct sched_param
-{
- int sched_priority;
-};
+#include <bits/types/struct_sched_param.h>
__BEGIN_DECLS