From patchwork Mon Feb 26 14:20:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 26057 Received: (qmail 74317 invoked by alias); 26 Feb 2018 14:20:57 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 74304 invoked by uid 89); 26 Feb 2018 14:20:57 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.8 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-pl0-f65.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=LXdzEW70AhMwtzkf58VYzHjWzxdyYIhz1kjR1ulY1t8=; b=SdHHG1f0ZoRiNOlWlzyCyF4FZUmSpmCMFSWKZNbSY3nmUnWLQjSn0OrAAzdugAwKZb +MP8tvIjXrrtftIRPE4pi4WOdJgNra1Ry8U5gyMop7H6mcybnnNy7tgHRKzBvSb+Rewx wBOEJk4f8a5zQT3hAMQe44RzRfbayx9uwg+CKDKQCv76qjsRd7fGZBGtgi9tj0nWjKin 7SQILIoGGx/HbR6pFZDM06N83yWjqpBID4oVvAsLJPWWzwceXOf0CkGeVjYsDXQvH3QU zoCkt4SX7BMgtGPJhWZ6va4me6Kgbdd4Nr+aMrDfuSpgvs2wDtiWJE6n2bzx5LcNWMKz zPRw== X-Gm-Message-State: APf1xPBfur2vIcApDcdPpn42v0P7tr11cT+uotK2w6A3gooTntIg30rX 38eb40OvuABTobAvmokwFpYk3Q== X-Google-Smtp-Source: AH8x224zr3iC92CYfxHL34LzlzQueRiz/OHHhoAA6oK/XD6BmQZvgZGIpOGgNgIgq96zSa0RsJ5pAQ== X-Received: by 2002:a17:902:6041:: with SMTP id a1-v6mr10563585plt.225.1519654854061; Mon, 26 Feb 2018 06:20:54 -0800 (PST) Date: Mon, 26 Feb 2018 06:20:51 -0800 From: "H.J. Lu" To: GNU C Library Subject: [PATCH] Remove hidden __libc_longjmp Message-ID: <20180226142051.GA23428@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.2 (2017-12-15) Since __libc_longjmp is a private interface for cancellation implementation in libpthread, there is no need to provide hidden __libc_longjmp in libc. Tested with build-many-glibcs.py. OK for master? H.J. --- * include/setjmp.h (__libc_longjmp): Remove libc_hidden_proto. * setjmp/longjmp.c (__libc_longjmp): Remove libc_hidden_def. * sysdeps/s390/longjmp.c (__libc_longjmp): Likewise. * sysdeps/unix/sysv/linux/sparc/sparc64/longjmp.S (__libc_longjmp): Likewise. --- include/setjmp.h | 1 - setjmp/longjmp.c | 3 ++- sysdeps/s390/longjmp.c | 1 - sysdeps/unix/sysv/linux/sparc/sparc64/longjmp.S | 1 - 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/include/setjmp.h b/include/setjmp.h index f1b19f5ceb..263bc64b3d 100644 --- a/include/setjmp.h +++ b/include/setjmp.h @@ -23,7 +23,6 @@ extern void __libc_siglongjmp (sigjmp_buf env, int val) __attribute__ ((noreturn)); extern void __libc_longjmp (sigjmp_buf env, int val) __attribute__ ((noreturn)); -libc_hidden_proto (__libc_longjmp) libc_hidden_proto (_setjmp) libc_hidden_proto (__sigsetjmp) diff --git a/setjmp/longjmp.c b/setjmp/longjmp.c index 6b4737605a..a2a7065a85 100644 --- a/setjmp/longjmp.c +++ b/setjmp/longjmp.c @@ -40,8 +40,9 @@ __libc_siglongjmp (sigjmp_buf env, int val) } #ifndef __libc_siglongjmp +/* __libc_longjmp is a private interface for cancellation implementation + in libpthread. */ strong_alias (__libc_siglongjmp, __libc_longjmp) -libc_hidden_def (__libc_longjmp) weak_alias (__libc_siglongjmp, _longjmp) weak_alias (__libc_siglongjmp, longjmp) weak_alias (__libc_siglongjmp, siglongjmp) diff --git a/sysdeps/s390/longjmp.c b/sysdeps/s390/longjmp.c index 6343c261b5..e61cdba2a3 100644 --- a/sysdeps/s390/longjmp.c +++ b/sysdeps/s390/longjmp.c @@ -33,7 +33,6 @@ but were reverted before 2.20. Thus both versions are the same function. */ strong_alias (__libc_siglongjmp, __libc_longjmp) -libc_hidden_def (__libc_longjmp) weak_alias (__libc_siglongjmp, __v1_longjmp) weak_alias (__libc_siglongjmp, __v2_longjmp) diff --git a/sysdeps/unix/sysv/linux/sparc/sparc64/longjmp.S b/sysdeps/unix/sysv/linux/sparc/sparc64/longjmp.S index 208c6db3a9..5937396fc7 100644 --- a/sysdeps/unix/sysv/linux/sparc/sparc64/longjmp.S +++ b/sysdeps/unix/sysv/linux/sparc/sparc64/longjmp.S @@ -45,7 +45,6 @@ END(__libc_siglongjmp) strong_alias(__libc_siglongjmp, __longjmp) strong_alias(__libc_siglongjmp, __libc_longjmp) -libc_hidden_def (__libc_longjmp) weak_alias (__libc_siglongjmp, longjmp) weak_alias (__libc_siglongjmp, _longjmp) weak_alias (__libc_siglongjmp, siglongjmp)