diff mbox

string: Replace = with += in CFLAGS-tst-xbzero-opt.c

Message ID 20171211131849.GA35836@intel.com
State New, archived
Headers

Commit Message

Lu, Hongjiu Dec. 11, 2017, 1:18 p.m. UTC 
  Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
to define CFLAGS-tst-xbzero-opt.c.

Any comments?

H.J.
	* string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.
---
 string/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andreas Schwab Dec. 11, 2017, 1:32 p.m. UTC | #1 
On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote:

> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
> to define CFLAGS-tst-xbzero-opt.c.
>
> Any comments?
>
> H.J.
> 	* string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.

I think that should be done for all such assignments.

Andreas.
H.J. Lu Dec. 11, 2017, 1:35 p.m. UTC | #2 
On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote:
> On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote:
>
>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
>> to define CFLAGS-tst-xbzero-opt.c.
>>
>> Any comments?
>>
>> H.J.
>>       * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.
>
> I think that should be done for all such assignments.
>

By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in
string/Makefile?
Andreas Schwab Dec. 11, 2017, 1:39 p.m. UTC | #3 
On Dez 11 2017, "H.J. Lu" <hjl.tools@gmail.com> wrote:

> On Mon, Dec 11, 2017 at 5:32 AM, Andreas Schwab <schwab@suse.de> wrote:
>> On Dez 11 2017, "H.J. Lu" <hongjiu.lu@intel.com> wrote:
>>
>>> Replace = with += in CFLAGS-tst-xbzero-opt.c to allow sysdeps Makefile
>>> to define CFLAGS-tst-xbzero-opt.c.
>>>
>>> Any comments?
>>>
>>> H.J.
>>>       * string/Makefile (CFLAGS-tst-xbzero-opt.c): Replace = with +=.
>>
>> I think that should be done for all such assignments.
>>
>
> By "all", did you mean CFLAGS-xxx in */Makefile or CFLAGS-xxx in
> string/Makefile?

Everywhere, if you like to work on that.

Andreas.
diff mbox

Patch

diff --git a/string/Makefile b/string/Makefile
index d7e90a38a5..618b737b13 100644
--- a/string/Makefile
+++ b/string/Makefile
@@ -75,7 +75,7 @@  CFLAGS-tst-strlen.c = -fno-builtin
 CFLAGS-stratcliff.c = -fno-builtin
 CFLAGS-test-ffs.c = -fno-builtin
 CFLAGS-tst-inlcall.c = -fno-builtin
-CFLAGS-tst-xbzero-opt.c = -O3
+CFLAGS-tst-xbzero-opt.c += -O3
 # BZ 21006: Resolve all functions but at least explicit_bzero at startup.
 # Otherwise the test fails on s390x as the memcpy in prepare_test_buffer is
 # done by loading r4 / r5 with the test_pattern and using store multiple