From patchwork Fri Sep 29 21:31:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H.J. Lu" X-Patchwork-Id: 23242 Received: (qmail 125112 invoked by alias); 29 Sep 2017 21:31:49 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 124765 invoked by uid 89); 29 Sep 2017 21:31:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.0 required=5.0 tests=AWL, BAYES_00, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, RCVD_IN_SORBS_SPAM, SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:726 X-HELO: mail-io0-f178.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=UNjQjPXdfdGap8Dac0PrcrnmWeqau5mWx+p478W7xas=; b=TfYKEAFANpRrwLsZhpeEUUfrQmsJ0tcnRbm+MKbQayMwmO5dIcCVafBMjh2euWppXZ x3ANvCQAe75+0XJE2Xa1mcMoOvGnZ30PWrCb1zbmUsMBVSy2vxtSLG/ChNHE+xq6MkIR isUwiH3JFMY9hc2HogG0LY+cHDdzW/OJ0CaOjPfwi8kdF8ngfbmkGcae+as3wo/hV04P toiIMHu8oN6E8I0rmZZDgxhtX3PRa/2go2W8sehcaEA5CXU5xQBNzmKdMZR4K3FfBlV/ LtveqGPSFgV+7SyXfSArWV9BPJU2077HFN7PEy7B8nntNrtWmR2A3/S7ZcsJxp3H1EzJ 0geA== X-Gm-Message-State: AMCzsaW4bVW5xaB7832qM23h3or6lGfMUOfF0pgiBqsxvmSVJCMpt/ig hImD5F0mx6bciEobx1/eXp1MPWKp X-Google-Smtp-Source: AOwi7QCfhn5TCFGk6yeFyFYLvPVbFEsogsrLWdXvVY9MQalUEnVwI2DK4Q2OBiKVIAO29g9cfyP/rg== X-Received: by 10.107.69.4 with SMTP id s4mr14062097ioa.185.1506720706236; Fri, 29 Sep 2017 14:31:46 -0700 (PDT) Date: Fri, 29 Sep 2017 14:31:39 -0700 From: "H.J. Lu" To: GNU C Library Subject: [PATCH] arm: Check PIC instead of SHARED in start.S Message-ID: <20170929213138.GF2482@gmail.com> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.0 (2017-09-02) Since start.o may be compiled as PIC, we should check PIC instead of SHARED. OK for master? * sysdeps/arm/start.S (_start): Check PIC instead of SHARED. --- sysdeps/arm/start.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/arm/start.S b/sysdeps/arm/start.S index 4973878f05..a5c678b6c5 100644 --- a/sysdeps/arm/start.S +++ b/sysdeps/arm/start.S @@ -89,7 +89,7 @@ _start: /* Push rtld_fini */ push { a1 } -#ifdef SHARED +#ifdef PIC ldr sl, .L_GOT adr a4, .L_GOT add sl, sl, a4 @@ -127,7 +127,7 @@ _start: /* should never get here....*/ bl abort -#ifdef SHARED +#ifdef PIC .align 2 .L_GOT: .word _GLOBAL_OFFSET_TABLE_ - .L_GOT