diff mbox

[v3,1/5] powerpc64le: Add -mfloat128 to tst-strtod-nan-locale testcase

Message ID 20170912123435.6592-2-gabriel@inconstante.eti.br
State Committed
Delegated to: Tulio Magno Quites Machado Filho
Headers

Commit Message

Gabriel F. T. Gomes Sept. 12, 2017, 12:34 p.m. UTC 
  No changes since v2.

No changes since v1.

-- 8< --
On powerpc64le, not all files can have the flag -mfloat128 passed as an
option on the compile command, since that could conflict with other
flags, such as -mno-vsx.  Each file that needs the flag, gets it through
a CFLAGS-filename variable on sysdeps/powerpc/powerpc64le/Makefile.

The test cases tst-strtod-nan-locale and tst-wcstod-nan-locale are
missing this flag.

Tested for powerpc64le.

	* sysdeps/powerpc/powerpc64le/Makefile
	(CFLAGS-tst-strtod-nan-locale.c): New variable.
	(CFLAGS-tst-wcstod-nan-locale.c): New variable.
---
 sysdeps/powerpc/powerpc64le/Makefile | 3 +++
 1 file changed, 3 insertions(+)

Comments

Tulio Magno Quites Machado Filho Sept. 18, 2017, 8:45 p.m. UTC | #1 
"Gabriel F. T. Gomes" <gabriel@inconstante.eti.br> writes:

> On powerpc64le, not all files can have the flag -mfloat128 passed as an
> option on the compile command, since that could conflict with other
> flags, such as -mno-vsx.  Each file that needs the flag, gets it through
> a CFLAGS-filename variable on sysdeps/powerpc/powerpc64le/Makefile.
>
> The test cases tst-strtod-nan-locale and tst-wcstod-nan-locale are
> missing this flag.
>
> Tested for powerpc64le.
>
> 	* sysdeps/powerpc/powerpc64le/Makefile
> 	(CFLAGS-tst-strtod-nan-locale.c): New variable.
> 	(CFLAGS-tst-wcstod-nan-locale.c): New variable.

Looks good to me.
diff mbox

Patch

diff --git a/sysdeps/powerpc/powerpc64le/Makefile b/sysdeps/powerpc/powerpc64le/Makefile
index dea2290736..3fd9d9a715 100644
--- a/sysdeps/powerpc/powerpc64le/Makefile
+++ b/sysdeps/powerpc/powerpc64le/Makefile
@@ -33,12 +33,15 @@  CFLAGS-bug-strtod.c += -mfloat128
 CFLAGS-bug-strtod2.c += -mfloat128
 CFLAGS-tst-strtod-round.c += -mfloat128
 CFLAGS-tst-wcstod-round.c += -mfloat128
+CFLAGS-tst-strtod-nan-locale.c += -mfloat128
+CFLAGS-tst-wcstod-nan-locale.c += -mfloat128
 CFLAGS-tst-strtod6.c += -mfloat128
 CFLAGS-tst-strfrom.c += -mfloat128
 CFLAGS-tst-strfrom-locale.c += -mfloat128
 CFLAGS-strfrom-skeleton.c += -mfloat128
 $(foreach test,bug-strtod bug-strtod2 bug-strtod2 tst-strtod-round \
 tst-wcstod-round tst-strtod6 tst-strrom tst-strfrom-locale \
+tst-strtod-nan-locale tst-wcstod-nan-locale \
 strfrom-skeleton,$(objpfx)$(test)): gnulib-tests += $(f128-loader-link)
 
 # When building glibc with support for _Float128, the powers of ten tables in