From patchwork Fri Aug 18 20:30:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lu, Hongjiu" X-Patchwork-Id: 22233 Received: (qmail 79077 invoked by alias); 18 Aug 2017 20:31:04 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 78578 invoked by uid 89); 18 Aug 2017 20:30:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, NO_DNS_FOR_FROM, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=csu X-HELO: mga03.intel.com X-ExtLoop1: 1 Date: Fri, 18 Aug 2017 13:30:21 -0700 From: "H.J. Lu" To: GNU C Library Subject: [PATCH 1/3] Mark __libc_multiple_libcs with attribute_hidden [BZ #18822] Message-ID: <20170818203021.GA15188@gmail.com> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.8.3 (2017-05-23) Since __libc_multiple_libcs is defined as hidden symbol in init-first.c, it should be marked with attribute_hidden. OK for master? H.J. --- [BZ #18822] * csu/libc-start.c (__libc_multiple_libcs): Add attribute_hidden. * elf/dl-open.c (__libc_multiple_libcs): Likewise. --- csu/libc-start.c | 2 +- elf/dl-open.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/csu/libc-start.c b/csu/libc-start.c index 6720617188..31a30d7197 100644 --- a/csu/libc-start.c +++ b/csu/libc-start.c @@ -27,7 +27,7 @@ extern void __libc_init_first (int argc, char **argv, char **envp); -extern int __libc_multiple_libcs; +extern int __libc_multiple_libcs attribute_hidden; #include #ifndef SHARED diff --git a/elf/dl-open.c b/elf/dl-open.c index 2d8948aab1..a0817aa066 100644 --- a/elf/dl-open.c +++ b/elf/dl-open.c @@ -37,7 +37,8 @@ #include -extern int __libc_multiple_libcs; /* Defined in init-first.c. */ +/* Defined in init-first.c. */ +extern int __libc_multiple_libcs attribute_hidden; /* We must be careful not to leave us in an inconsistent state. Thus we catch any error and re-raise it after cleaning up. */