From patchwork Tue Aug 15 17:38:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lu, Hongjiu" X-Patchwork-Id: 22126 Received: (qmail 74076 invoked by alias); 15 Aug 2017 17:39:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 73612 invoked by uid 89); 15 Aug 2017 17:39:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, KAM_LAZY_DOMAIN_SECURITY, NO_DNS_FOR_FROM, RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1440 X-HELO: mga04.intel.com X-ExtLoop1: 1 Date: Tue, 15 Aug 2017 10:38:55 -0700 From: "H.J. Lu" To: GNU C Library Subject: [PATCH] x86-64: Put L(SP_INF_0) in .rodata.cst4 section [BZ #21955] Message-ID: <20170815173855.GA19119@gmail.com> Reply-To: "H.J. Lu" MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.8.3 (2017-05-23) sysdeps/x86_64/fpu/e_expf.S has /* Here if |x| is Inf */ lea L(SP_INF_0)(%rip), %rdx /* depending on sign of x: */ movss (%rdx,%rax,4), %xmm0 /* return zero or Inf */ ret ... .section .rodata.cst8,"aM",@progbits,8 ... .p2align 2 L(SP_INF_0): .long 0x7f800000 /* single precision Inf */ .long 0 /* single precision zero */ .type L(SP_INF_0), @object ASM_SIZE_DIRECTIVE(L(SP_INF_0)) Since L(SP_INF_0) is accessed as an array of 4-byte elements, it should be placed in .section .rodata.cst4,"aM",@progbits,4 Tested on x86-64. Any comments? H.J. --- [BZ #21955] * sysdeps/x86_64/fpu/e_expf.S (L(SP_INF_0)): Place it in .rodata.cst4 section. --- sysdeps/x86_64/fpu/e_expf.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/x86_64/fpu/e_expf.S b/sysdeps/x86_64/fpu/e_expf.S index 4fd2bb1fb5..0d84e31615 100644 --- a/sysdeps/x86_64/fpu/e_expf.S +++ b/sysdeps/x86_64/fpu/e_expf.S @@ -304,6 +304,7 @@ L(SP_RANGE): /* single precision overflow/underflow bounds */ .type L(SP_RANGE), @object ASM_SIZE_DIRECTIVE(L(SP_RANGE)) + .section .rodata.cst4,"aM",@progbits,4 .p2align 2 L(SP_INF_0): .long 0x7f800000 /* single precision Inf */ @@ -311,7 +312,6 @@ L(SP_INF_0): .type L(SP_INF_0), @object ASM_SIZE_DIRECTIVE(L(SP_INF_0)) - .section .rodata.cst4,"aM",@progbits,4 .p2align 2 L(SP_RS): /* single precision 2^23+2^22 */ .long 0x4b400000